All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net/mlx5e: Release FIB event work flows before dropping RTNL
Date: Wed, 18 Nov 2026 14:49:54 +0000	[thread overview]
Message-ID: <sashiko-outbox-221255@kernel.org> (raw)
In-Reply-To: <20261118143653.1915247-1-tariqt@nvidia.com>

> From: Gal Pressman <gal@nvidia.com>
> 
> The FIB event work, neigh update work and the neigh stats work all use
> flow->tmp_list to hold the encap flows they work on, while RTNL is what
> keeps them from using it at the same time.
> 
> mlx5e_tc_fib_event_work() drops RTNL before it is done with its list.
> A neigh work can then take the same flows while the FIB work is still
> walking them, and the two overwrite each other's list.
> 
> Release the flow list before dropping RTNL.
> 
> The issue was hit once in our regression testing (OVS connection
> tracking with the VXLAN endpoint on a VF, KASAN build):
>   BUG: KASAN: stack-out-of-bounds in mlx5e_flow_put+0x23/0x80 [mlx5_core]
> [ ... ]
> 
> Fixes: 8914add2c9e5 ("net/mlx5e: Handle FIB events to update tunnel endpoint device")
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Jianbo Liu <jianbol@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118143653.1915247-1-tariqt@nvidia.com?part=1


      reply	other threads:[~2026-11-18 14:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:36 [PATCH net] net/mlx5e: Release FIB event work flows before dropping RTNL Tariq Toukan
2026-11-18 14:49 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221255@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.