All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org
Subject: Re: [PATCH v3 5/6] selftests/landlock: Test capability checks outside the capable hook
Date: Wed, 18 Nov 2026 14:58:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-221274@kernel.org> (raw)
In-Reply-To: <20261118145217.2551053-6-mic@digikod.net>

> Test the commoncap checks that the previous commits make Landlock
> restrict: mapping below vm.mmap_min_addr (CAP_SYS_RAWIO) and adding
> inheritable capabilities (CAP_SETPCAP).  Each test checks that the
> operation needs the capability, then runs it with the capability in four
> variants: unsandboxed, denied, allowed and unhandled.  The mmap_addr
> tests skip if the architecture rejects the low page before the hook
> (e.g. 32-bit ARM).
> 
> Audit tests check that these denials are logged, and that the admin
> reserve check and allowed uses are not.  The admin reserve has no
> functional test because it depends on vm.overcommit_memory=2, a
> system-wide setting.
> 
> Add CAP_SETPCAP and CAP_SYS_RAWIO to the capabilities that the tests may
> raise.
> 
> Without the mmap_addr and capset fixes, their denied variants and the
> denial audit test fail.
> 
> Cc: Günther Noack <gnoack@google.com>
> Cc: Paul Moore <paul@paul-moore.com>
> Cc: Serge Hallyn <serge@hallyn.com>
> Acked-by: Serge Hallyn (AMD) <sergeh@kernel.org>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118145217.2551053-1-mic@digikod.net?part=5


  reply	other threads:[~2026-11-18 14:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 14:52 [PATCH v3 0/6] Fix Landlock mediation of commoncap's capability checks Mickaël Salaün
2026-11-18 14:52 ` [PATCH v3 1/6] landlock: Factor out capability denial checks Mickaël Salaün
2026-11-18 14:55   ` sashiko-bot
2026-11-18 14:52 ` [PATCH v3 2/6] landlock: Mediate CAP_SYS_RAWIO for mappings below mmap_min_addr Mickaël Salaün
2026-11-18 14:57   ` sashiko-bot
2026-11-18 14:52 ` [PATCH v3 3/6] landlock: Mediate CAP_SETPCAP for inheritable capabilities Mickaël Salaün
2026-11-18 14:58   ` sashiko-bot
2026-11-18 14:52 ` [PATCH v3 4/6] landlock: Mediate CAP_SYS_ADMIN for the admin memory reserve Mickaël Salaün
2026-11-18 14:56   ` sashiko-bot
2026-11-18 14:52 ` [PATCH v3 5/6] selftests/landlock: Test capability checks outside the capable hook Mickaël Salaün
2026-11-18 14:58   ` sashiko-bot [this message]
2026-11-18 14:52 ` [PATCH v3 6/6] landlock: Fix capability restriction documentation Mickaël Salaün
2026-11-18 14:55   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221274@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.