All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Olivier Moysan" <olivier.moysan@foss.st.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-sound@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, media-ci@linuxtv.org
Subject: Re: [PATCH v2 09/11] iio: adc: stm32-mdf: add external timer trigger support
Date: Wed, 18 Nov 2026 15:37:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-221349@kernel.org> (raw)
In-Reply-To: <20261118-upstream_mdf_v2-v2-9-7939d3c3720a@foss.st.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] iio: adc: stm32-mdf: non-zero return in
  stm32_mdf_adc_get_trig() rejects trig
- [High] iio: adc: stm32-mdf: unassigned trgsrc in
  stm32_mdf_adc_filter_set_trig()
- [Medium] iio: adc: stm32-mdf: unpropagated trigger in
  stm32_mdf_adc_filter_set_trig()
--

commit 2310fd550deab336f6cec980952473a0c65d6371
Author: Olivier Moysan <olivier.moysan@foss.st.com>

iio: adc: stm32-mdf: add external timer trigger support

This commit adds STM32 timer and low-power timer trigger definitions, a
trigger validation callback, and filter trigger source and polarity
configuration for the STM32 MDF ADC driver.

> diff --git a/drivers/iio/adc/stm32-mdf-adc.c b/drivers/iio/adc/stm32-mdf-adc.c
> index 046ca3943a397..97099b4adffc6 100644
> --- a/drivers/iio/adc/stm32-mdf-adc.c
> +++ b/drivers/iio/adc/stm32-mdf-adc.c
[ ... ]
> @@ -365,9 +405,63 @@ static void stm32_mdf_adc_stop_filter(struct stm32_mdf_adc *adc)
>  				stm32_mdf_adc_stop_filter(adc_inter);
>  }
>  
> +static int stm32_mdf_adc_get_trig(struct iio_dev *indio_dev, struct iio_trigger *trig)
> +{
> +	int i;
> +
> +	/* lookup triggers registered by stm32 timer trigger driver */
> +	for (i = 0; stm32_mdf_trigs[i].name; i++) {
> +		/**
> +		 * Checking both stm32 timer trigger type and trig name
> +		 * should be safe against arbitrary trigger names.
> +		 */
> +		if ((is_stm32_timer_trigger(trig) ||
> +		     is_stm32_lptim_trigger(trig)) &&
> +		     !strcmp(stm32_mdf_trigs[i].name, trig->name)) {
> +			dev_dbg(&indio_dev->dev, "Trigger [%d] found\n", i);
> +			return stm32_mdf_trigs[i].trgsrc;
> +		}
> +	}
> +
> +	return -EINVAL;
> +}
> +
> +static int stm32_mdf_adc_filter_set_trig(struct iio_dev *indio_dev)
> +{
> +	struct stm32_mdf_adc *adc = iio_priv(indio_dev);
> +	struct iio_trigger *trig = indio_dev->trig;
> +	u32 trgsrc = 0;
> +	/* set trigger polarity to rising edge by default */
> +	u32 trgsens = STM32_MDF_TRGSENS_RISING_EDGE;
> +	int ret;
> +
> +	if (trig) {
> +		ret = stm32_mdf_adc_get_trig(indio_dev, trig);
> +		if (ret < 0)
> +			return ret;
> +	}
> +
> +	dev_dbg(adc->dev, "Set trigger source [%d] on filter [%d]\n", trgsrc, adc->fl_id);
> +
> +	return regmap_update_bits(adc->regmap, MDF_DFLTCR_REG,
> +				  MDF_DFLTCR_TRGSRC_MASK | MDF_DFLTCR_TRGSENS,
> +				 FIELD_PREP(MDF_DFLTCR_TRGSRC_MASK, trgsrc) |
> +				 FIELD_PREP(MDF_DFLTCR_TRGSENS, trgsens));
> +}

[Severity: High]
Does stm32_mdf_adc_filter_set_trig() leave trgsrc at 0 when a trigger is
attached?  The return value of stm32_mdf_adc_get_trig() is checked in ret
but never assigned to trgsrc, so MDF_DFLTCR_REG is always programmed with
trigger source 0 (TRGO) instead of the selected external timer trigger.

> +
> +static void stm32_mdf_adc_filter_clear_trig(struct iio_dev *indio_dev)
> +{
> +	struct stm32_mdf_adc *adc = iio_priv(indio_dev);
> +
> +	regmap_update_bits(adc->regmap, MDF_DFLTCR_REG,
> +			   MDF_DFLTCR_TRGSRC_MASK | MDF_DFLTCR_TRGSENS, 0);
> +}

[Severity: Medium]
In interleaved mode, should stm32_mdf_adc_filter_set_trig() and
stm32_mdf_adc_filter_clear_trig() also update the secondary interleaved
filters in adc->mdf->filter_list, and should stm32_mdf_adc_start_conv()
skip pulsing MDF_GCR_TRGO when indio_dev->trig is set?

Unlike stm32_mdf_adc_filter_set_mode(), these helpers only write filter 0's
MDF_DFLTCR_REG, leaving secondary interleaved filters configured for
TRGSRC = 0 (TRGO).  Because adc->trgo is set at probe time for interleaved
and synchronized master filters, stm32_mdf_adc_start_conv() still calls
stm32_mdf_core_trigger(adc->mdf) during buffer enable, starting the
TRGO-triggered filters immediately while filter 0 waits for the external
timer edge.

[ ... ]

> @@ -1377,6 +1479,7 @@ static const struct iio_info stm32_mdf_info_adc = {
>  	.write_raw = stm32_mdf_adc_write_raw,
>  	.read_raw = stm32_mdf_adc_read_raw,
>  	.read_label = stm32_mdf_adc_read_label,
> +	.validate_trigger = stm32_mdf_adc_get_trig,
>  };

[Severity: High]
Will wiring stm32_mdf_adc_get_trig() directly as .validate_trigger reject
every valid trigger?  stm32_mdf_adc_get_trig() returns a positive trgsrc
value (0x2..0xc) on match, whereas current_trigger_store() in
drivers/iio/industrialio-trigger.c treats any non-zero return from
validate_trigger() as an error and aborts assigning indio_dev->trig.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-upstream_mdf_v2-v2-0-7939d3c3720a@foss.st.com?part=9

  reply	other threads:[~2026-11-18 15:37 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 15:17 [PATCH v2 00/11] iio: adc: stm32: add mdf support for stm32mp2 Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 01/11] dt-bindings: iio: adc: add stm32mp2 mdf filter Olivier Moysan
2026-11-18 15:17 ` [PATCH v2 02/11] iio: adc: stm32-mdf: add core registration Olivier Moysan
2026-11-18 15:45   ` sashiko-bot
2026-11-19  9:44   ` Andy Shevchenko
2026-11-18 15:17 ` [PATCH v2 03/11] iio: adc: stm32-mdf: add cck clocks provider Olivier Moysan
2026-11-18 15:50   ` sashiko-bot
2026-11-18 15:17 ` [PATCH v2 04/11] iio: adc: stm32-mdf: add serial interfaces support Olivier Moysan
2026-11-18 15:42   ` sashiko-bot
2026-11-18 15:17 ` [PATCH v2 05/11] iio: adc: stm32-mdf: add digital filter device support Olivier Moysan
2026-11-18 15:40   ` sashiko-bot
2026-11-18 15:17 ` [PATCH v2 06/11] iio: adc: stm32-mdf: configure cic filters and sample rates Olivier Moysan
2026-11-18 15:34   ` sashiko-bot
2026-11-18 15:17 ` [PATCH v2 07/11] iio: adc: stm32-mdf: add direct iio conversion support Olivier Moysan
2026-11-18 15:51   ` sashiko-bot
2026-11-18 15:17 ` [PATCH v2 08/11] iio: adc: stm32-mdf: add dma buffered acquisition support Olivier Moysan
2026-11-18 15:55   ` sashiko-bot
2026-11-18 15:17 ` [PATCH v2 09/11] iio: adc: stm32-mdf: add external timer trigger support Olivier Moysan
2026-11-18 15:37   ` sashiko-bot [this message]
2026-11-18 15:17 ` [PATCH v2 10/11] iio: adc: stm32-mdf: add dmic audio filter support Olivier Moysan
2026-11-18 16:06   ` sashiko-bot
2026-11-18 15:17 ` [PATCH v2 11/11] ASoC: stm32: add mdf dai support Olivier Moysan
2026-11-18 16:08   ` sashiko-bot
2026-11-19 18:37 ` [PATCH v2 00/11] iio: adc: stm32: add mdf support for stm32mp2 Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221349@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=media-ci@linuxtv.org \
    --cc=olivier.moysan@foss.st.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.