All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ryan Brue" <ryanbrue.dev@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3] arm64: dts: mediatek: Add MT8173 Amazon suez
Date: Wed, 18 Nov 2026 17:17:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-221635@kernel.org> (raw)
In-Reply-To: <20261118-rbrue-suez-upstreaming-amazon-suez-dts-v3-1-c1a8b0febf35@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: mediatek: undocumented mediatek,mt8173-keypad
  compatible enabled
--

commit c33790cfc531e5cd7fbd7f7174f861a419969c8c
Author: Ryan Brue <ryanbrue.dev@gmail.com>

arm64: dts: mediatek: Add MT8173 Amazon suez

This commit adds the device tree for the MT8173-based Amazon Fire HD 10
(2017) tablet (codename suez).

> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts b/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts
> new file mode 100644
> index 0000000000000..68ccf10d1521b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-amazon-suez.dts

[ ... ]

> +&keyboard {
> +	/* Each key is reported in all eight rows of its column */
> +	keypad,num-rows = <8>;
> +	keypad,num-columns = <9>;
> +	linux,keymap = <MATRIX_KEY(0, 0, KEY_VOLUMEUP)
> +			MATRIX_KEY(0, 1, KEY_VOLUMEDOWN)>;
> +	debounce-delay-ms = <32>;
> +	wakeup-source;
> +	status = "okay";
> +};

[Severity: Low]
Does enabling &keyboard cause dtbs_check to fail on mt8173-amazon-suez.dtb
in this tree?

arch/arm64/boot/dts/mediatek/mt8173.dtsi sets keyboard@10010000's
compatible to "mediatek,mt8173-keypad", "mediatek,mt6779-keypad", while
Documentation/devicetree/bindings/input/mediatek,mt6779-keypad.yaml does
not yet list "mediatek,mt8173-keypad" in its compatible enum.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-rbrue-suez-upstreaming-amazon-suez-dts-v3-1-c1a8b0febf35@gmail.com?part=1

      reply	other threads:[~2026-11-18 17:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 17:04 [PATCH v3] arm64: dts: mediatek: Add MT8173 Amazon suez Ryan Brue
2026-11-18 17:17 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221635@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=ryanbrue.dev@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.