All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "David Heidelberg" <david@ixit.cz>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660
Date: Wed, 18 Nov 2026 17:33:20 +0000	[thread overview]
Message-ID: <sashiko-outbox-221657@kernel.org> (raw)
In-Reply-To: <20261118-pmi8998-vbus-v2-4-3c77a72b280a@ixit.cz>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: regulator: typo in fallback compatible for
  qcom,pm660-vbus-reg
--

commit d53eae4793d2d86b3e41fd0d2b1c0495b964d938
Author: David Heidelberg <david@ixit.cz>

dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660

This commit adds the qcom,pmi8998-vbus-reg and qcom,pm660-vbus-reg
compatible strings to the Qualcomm USB VBUS regulator DT binding schema.

> diff --git a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> index 024b34d0eb1a6..96f984060ce4d 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> +++ b/Documentation/devicetree/bindings/regulator/qcom,usb-vbus-regulator.yaml
> @@ -27,12 +27,17 @@ properties:
>        - enum:
>            - qcom,pm8150b-vbus-reg
>            - qcom,pm4125-vbus-reg
> +          - qcom,pmi8998-vbus-reg
>        - items:
>            - enum:
>                - qcom,pm6150-vbus-reg
>                - qcom,pm7250b-vbus-reg
>                - qcom,pmi632-vbus-reg
>            - const: qcom,pm8150b-vbus-reg
> +      - items:
> +          - enum:
> +              - qcom,pm660-vbus-reg
> +          - const: qcom,pm8998-vbus-reg

[Severity: Medium]
Should the fallback compatible for qcom,pm660-vbus-reg be
qcom,pmi8998-vbus-reg instead of qcom,pm8998-vbus-reg?

The standalone enum above and qcom_usb_vbus_regulator_match[] in
drivers/regulator/qcom_usb_vbus-regulator.c both use
qcom,pmi8998-vbus-reg, so a PM660 node using that fallback will fail
dtbs_check validation against this schema.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-pmi8998-vbus-v2-0-3c77a72b280a@ixit.cz?part=4

  reply	other threads:[~2026-11-18 17:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 17:25 [PATCH v2 00/12] Enable Qualcomm VBUS block on PMI8998 and PM660 David Heidelberg
2026-11-18 17:25 ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 01/12] regulator: qcom_usb_vbus: Fix the MODULE_LICENSE() string David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 02/12] regulator: qcom_usb_vbus: Add support for pmi8998 David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:43   ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 03/12] power: supply: qcom_smbx: Do not interfere with vbus driver David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 04/12] dt-bindings: regulator: qcom,usb-vbus-regulator: Add pmi8998 and pm660 David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:33   ` sashiko-bot [this message]
2026-11-18 18:10     ` David Heidelberg
2026-11-18 17:25 ` [PATCH v2 05/12] arm64: dts: qcom: pmi8998: Add node for PMIC VBUS booster David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 06/12] arm64: dts: qcom: pm660: " David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:35   ` sashiko-bot
2026-11-18 17:25 ` [PATCH v2 07/12] arm64: dts: qcom: sdm845-google: Enable vbus support David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 08/12] arm64: dts: qcom: sdm845-oneplus: " David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 09/12] arm64: dts: qcom: sdm845-shift-axolotl: " David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 10/12] arm64: dts: qcom: sdm845-lg: " David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 11/12] arm64: dts: qcom: sdm845-xiaomi-beryllium: " David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:25 ` [PATCH v2 12/12] arm64: dts: qcom: sdm670-google: " David Heidelberg
2026-11-18 17:25   ` David Heidelberg via B4 Relay
2026-11-18 17:37   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221657@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david@ixit.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.