From: sashiko-bot@kernel.org
To: "Karunika Choo" <karunika.choo@arm.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v3 10/10] drm/panthor: Skip devfreq when no OPP table is present
Date: Wed, 18 Nov 2026 18:11:07 +0000 [thread overview]
Message-ID: <sashiko-outbox-221729@kernel.org> (raw)
In-Reply-To: <20261118175332.519657-11-karunika.choo@arm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/panthor: premature -ENODEV check in
panthor_devfreq_init() skips DT OPP table
--
commit ab9f7c849faad8dd2154fb00865ae2985875a9a7
Author: Karunika Choo <karunika.choo@arm.com>
drm/panthor: Skip devfreq when no OPP table is present
This commit skips panthor devfreq initialization on Mali v15 AM systems
when no OPP table is present, guards the devfreq helpers against a NULL
devfreq pointer, and omits drm-maxfreq-panthor from fdinfo when fast_rate
is zero.
> diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
> index 2249b41ca4afe..d1814b5197221 100644
> --- a/drivers/gpu/drm/panthor/panthor_devfreq.c
> +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
> @@ -12,6 +12,7 @@
>
> #include "panthor_devfreq.h"
> #include "panthor_device.h"
> +#include "panthor_hw.h"
>
> /**
> * struct panthor_devfreq - Device frequency management
> @@ -164,6 +165,19 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
> */
> table = dev_pm_opp_get_opp_table(dev);
> if (IS_ERR_OR_NULL(table)) {
> + /*
> + * On v15 GPUs, frequency scaling is handled outside of panthor
> + * by the AM_GOVERNOR block, so the GPU DT node may not provide
> + * an OPP table. In such cases, do not initialize devfreq for
> + * panthor.
> + */
> + if (panthor_hw_is_gen5_am(ptdev->base.dev) &&
> + PTR_ERR(table) == -ENODEV) {
> + drmm_kfree(&ptdev->base, pdevfreq);
> + ptdev->devfreq = NULL;
> + return 0;
> + }
> +
> ret = devm_pm_opp_set_regulators(dev, reg_names);
> if (ret && ret != -ENODEV) {
> if (ret != -EPROBE_DEFER)
[Severity: Medium]
Does checking PTR_ERR(table) == -ENODEV right after
dev_pm_opp_get_opp_table(dev) skip devfreq even when the GPU DT node
provides an OPP table?
dev_pm_opp_get_opp_table() only searches the in-memory opp_tables list for
a table already registered (for example by a power domain) and returns
ERR_PTR(-ENODEV) before devm_pm_opp_of_add_table(dev) has parsed the
Device Tree. As a result, on arm,mali-gen5-am systems without a
pre-registered power-domain OPP table, panthor_devfreq_init() returns
early before devm_pm_opp_of_add_table(dev) is called, ignoring any OPP
table in the GPU DT node. Should the -ENODEV check for
panthor_hw_is_gen5_am() happen on the return value of
devm_pm_opp_of_add_table(dev) instead?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118175332.519657-1-karunika.choo@arm.com?part=10
next prev parent reply other threads:[~2026-11-18 18:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 17:53 [PATCH v3 00/10] drm/panthor: Add initial Mali v15 support Karunika Choo
2026-11-18 17:53 ` [PATCH v3 01/10] drm/panthor: Ignore -EOPNOTSUPP for shader-present nvmem lookup Karunika Choo
2026-11-18 17:53 ` [PATCH v3 02/10] drm/panthor: Rename neural accelerator feature macro to NX Karunika Choo
2026-11-18 17:59 ` sashiko-bot
2026-11-19 7:52 ` Boris Brezillon
2026-11-19 9:47 ` Liviu Dudau
2026-11-18 17:53 ` [PATCH v3 03/10] drm/panthor: Move register access helpers out of panthor_device.h Karunika Choo
2026-11-19 7:53 ` Boris Brezillon
2026-11-18 17:53 ` [PATCH v3 04/10] drm/panthor: Parse and store GPU_ID fields Karunika Choo
2026-11-19 7:53 ` Boris Brezillon
2026-11-18 17:53 ` [PATCH v3 05/10] drm/panthor: Add 64-bit GPU_ID decoding for v15 GPUs Karunika Choo
2026-11-19 8:01 ` Boris Brezillon
2026-11-18 17:53 ` [PATCH v3 06/10] drm/panthor: Move register base offsets to the HW description Karunika Choo
2026-11-19 8:01 ` Boris Brezillon
2026-11-18 17:53 ` [PATCH v3 07/10] drm/panthor: Derive MMU AS register addresses from base and stride Karunika Choo
2026-11-19 8:03 ` Boris Brezillon
2026-11-18 17:53 ` [PATCH v3 08/10] dt-bindings: gpu: mali-gen5-am: Add Mali 5th-Gen AM schema Karunika Choo
2026-11-19 8:04 ` Boris Brezillon
2026-11-18 17:53 ` [PATCH v3 09/10] drm/panthor: Add Mali v15 hardware support Karunika Choo
2026-11-19 8:08 ` Boris Brezillon
2026-11-18 17:53 ` [PATCH v3 10/10] drm/panthor: Skip devfreq when no OPP table is present Karunika Choo
2026-11-18 18:11 ` sashiko-bot [this message]
2026-11-19 8:12 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-221729@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=karunika.choo@arm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.