From: sashiko-bot@kernel.org
To: "Birger Koblitz" <mail@birger-koblitz.de>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH net-next] aqc111: Correct endianness handling in rx/tx_fixup
Date: Wed, 18 Nov 2026 18:29:01 +0000 [thread overview]
Message-ID: <sashiko-outbox-221761@kernel.org> (raw)
In-Reply-To: <20261117-aqc111-v1-1-27a54c4b54ca@birger-koblitz.de>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] net: usb: aqc111: missing Fixes trailers for rx/tx_fixup bugs
--
commit 3ac1508f147f366e674a4d0f2714eb425e64838d
Author: Birger Koblitz <mail@birger-koblitz.de>
> aqc111: Correct endianness handling in rx/tx_fixup
>
> The MAC supported by the aqc111 driver is very similar
> to the AX88179A. During the development of the driver for
> the AX88179A, the following issues in endianness-handling
> were found, which are also present in the aqc111 driver:
> CHECK drivers/net/usb/aqc111.c
> drivers/net/usb/aqc111.c:1094:34: warning: incorrect type in argument 1 (different base types)
> drivers/net/usb/aqc111.c:1094:34: expected restricted __le64 const [usertype] *p
> drivers/net/usb/aqc111.c:1094:34: got unsigned long long [usertype] *
> drivers/net/usb/aqc111.c:1122:45: warning: incorrect type in argument 1 (different base types)
> drivers/net/usb/aqc111.c:1122:45: expected restricted __le64 const [usertype] *p
> drivers/net/usb/aqc111.c:1122:45: got unsigned long long [usertype] *[assigned] pkt_desc_ptr
> drivers/net/usb/aqc111.c:1235:22: warning: incorrect type in assignment (different base types)
> drivers/net/usb/aqc111.c:1235:22: expected unsigned long long [usertype]
> drivers/net/usb/aqc111.c:1235:22: got restricted __le64 [usertype]
>
> Fix these problems and additionally also make sure that cloned
> skbs are always copied for expansion.
>
> Signed-off-by: Birger Koblitz <mail@birger-koblitz.de>
[Severity: Low]
This fixes bugs in aqc111_rx_fixup() and aqc111_tx_fixup(). Should the
commit message include Fixes: tags for the commits that introduced them:
Fixes: 361459cd9642 ("net: usb: aqc111: Implement RX data path")
Fixes: 4a3576d2bcc7 ("net: usb: aqc111: Implement TX data path")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-aqc111-v1-1-27a54c4b54ca@birger-koblitz.de?part=1
next prev parent reply other threads:[~2026-11-18 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 18:28 [PATCH net-next] aqc111: Correct endianness handling in rx/tx_fixup Birger Koblitz
2026-11-17 18:33 ` netdev-bot+sinfo
2026-11-18 18:29 ` sashiko-bot [this message]
2026-11-19 19:41 ` Andrew Lunn
2026-11-20 6:29 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-221761@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.