All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Pankaj Patil" <pankaj.patil@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor
Date: Wed, 18 Nov 2026 18:34:41 +0000	[thread overview]
Message-ID: <sashiko-outbox-221771@kernel.org> (raw)
In-Reply-To: <20261118-lid_pull_up_fix-v1-1-4bb84dc70067@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: glymur-crd: TLMM bias-pull-up contradicts
  external pull-up
--

commit 33a3a23eacc897dad84afcf17e419a24de929c16
Author: Pankaj Patil <pankaj.patil@oss.qualcomm.com>

arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor

This commit replaces bias-disable with bias-pull-up on gpio92 in the
hall-int-n-state pinctrl node for the lid Hall-effect sensor on Glymur
CRD.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index 3a9cd5f3ec2b8..74588f4f7a86e 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -819,7 +819,7 @@ edp_reg_en: edp-reg-en-state {
>  	hall_int_n_default: hall-int-n-state {
>  		pins = "gpio92";
>  		function = "gpio";
> -		bias-disable;
> +		bias-pull-up;
>  	};

[Severity: Medium]
Should hall_int_n_default enable bias-pull-up if the board already has
an external 10k ohm pull-up resistor?

In msm_config_group_set(), bias-pull-up enables the SoC's internal TLMM
pull-up resistor rather than describing an external board resistor.  If
an external 10k ohm pull-up is populated on gpio92, enabling the
internal pull-up in parallel draws extra leakage current whenever the
lid is closed and switch-lid (GPIO_ACTIVE_LOW) is held low; if the
external resistor is unpopulated and the internal pull-up is needed, the
commit message says the opposite.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-lid_pull_up_fix-v1-1-4bb84dc70067@oss.qualcomm.com?part=1

  reply	other threads:[~2026-11-18 18:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 18:22 [PATCH] arm64: dts: qcom: glymur-crd: Enable pull-up bias for lid sensor Pankaj Patil
2026-11-18 18:34 ` sashiko-bot [this message]
2026-11-20  8:36 ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221771@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=pankaj.patil@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.