All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Pasha Tatashin" <pasha.tatashin@soleen.com>,
	rppt@kernel.org, shuah@kernel.org, skhan@linuxfoundation.org,
	vipinsh@google.com, corbet@lwn.net, dmatlack@google.com,
	kexec@lists.infradead.org, pratyush@kernel.org,
	rdunlap@infradead.org, graf@amazon.com
Subject: Re: [PATCH v6 2/7] kho: link outgoing blocks lazily in kho_block
Date: Wed, 18 Nov 2026 21:37:51 +0000	[thread overview]
Message-ID: <sashiko-outbox-222015@kernel.org> (raw)
In-Reply-To: <20261118212845.2855249-3-pasha.tatashin@soleen.com>

> Currently, kho_block_add() links each preallocated block onto the
> serialized chain immediately, even while it is still empty. This
> assumes all preallocated blocks are populated together before the
> chain is referenced by KHO.
> 
> When sessions are serialized incrementally ahead of reboot, extra
> blocks may be preallocated for sessions that have not been serialized
> yet. Keeping those blocks linked leaves empty trailing blocks on the
> KHO chain.
> 
> Keep preallocated outgoing blocks unlinked in kho_block_add() and link
> each block lazily in kho_block_set_it_reserve_entry() when advancing
> into it. Also unlink blocks in kho_block_set_clear() and stop at
> unlinked blocks in kho_block_set_it_read_entry().
> 
> Signed-off-by: Pasha Tatashin <pasha.tatashin@soleen.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118212845.2855249-1-pasha.tatashin@soleen.com?part=2



  reply	other threads:[~2026-11-18 21:37 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 21:28 [PATCH v6 0/7] liveupdate: Add LIVEUPDATE_SESSION_FREEZE ioctl Pasha Tatashin
2026-11-18 21:28 ` [PATCH v6 1/7] liveupdate: Move file_set_ser handling to luo_session_serialize() Pasha Tatashin
2026-11-18 21:32   ` sashiko-bot
2026-11-18 21:28 ` [PATCH v6 2/7] kho: link outgoing blocks lazily in kho_block Pasha Tatashin
2026-11-18 21:37   ` sashiko-bot [this message]
2026-11-19 11:03   ` Mike Rapoport
2026-11-18 21:28 ` [PATCH v6 3/7] liveupdate: luo_session: support incremental session serialization Pasha Tatashin
2026-11-18 21:33   ` sashiko-bot
2026-11-18 21:28 ` [PATCH v6 4/7] liveupdate: luo_flb: serialize outgoing FLBs incrementally Pasha Tatashin
2026-11-18 21:34   ` sashiko-bot
2026-11-19 11:03   ` Mike Rapoport
2026-11-18 21:28 ` [PATCH v6 5/7] liveupdate: Add LIVEUPDATE_SESSION_FREEZE ioctl to freeze sessions early Pasha Tatashin
2026-11-18 21:36   ` sashiko-bot
2026-11-19 11:03   ` Mike Rapoport
2026-11-18 21:28 ` [PATCH v6 6/7] selftests: liveupdate: Add unit tests for LIVEUPDATE_SESSION_FREEZE Pasha Tatashin
2026-11-18 21:34   ` sashiko-bot
2026-11-18 21:28 ` [PATCH v6 7/7] selftests: liveupdate: Test LIVEUPDATE_SESSION_FREEZE across kexec Pasha Tatashin
2026-11-18 21:34   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222015@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dmatlack@google.com \
    --cc=graf@amazon.com \
    --cc=kexec@lists.infradead.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=pratyush@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=vipinsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.