From: sashiko-bot@kernel.org
To: "Orgad Shaneh" <orgads@gmail.com>, dwmw2@infradead.org, richard@nod.at
Cc: miquel.raynal@bootlin.com, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/2] jffs2: reschedule between the data CRC checks of an inode
Date: Wed, 18 Nov 2026 21:44:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-222025@kernel.org> (raw)
In-Reply-To: <20261118214045.107562-2-orgads@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] jffs2: missing Fixes: trailer for lost cond_resched() in
readinode
--
commit dc68a5ef42faf811ab61bd897a8b35c11291c24e
Author: Orgad Shaneh <orgads@gmail.com>
> jffs2: reschedule between the data CRC checks of an inode
>
> The first read of an inode checks the data CRC of each of its unchecked
> nodes, all in one call. On an Octeon board with an 8-bit NOR, a
> 46.6 MB file takes 13.8 s of kernel time there. Without kernel
> preemption, nothing else ran on that CPU in the meantime: an RT
> watchdog thread missed its deadline and the board rebooted. With
> this, the lookup takes as long, but the watchdog, the per-CPU
> workqueue and the other tasks of that CPU keep running.
>
> jffs2_get_inode_nodes() already reschedules per node while it reads
> the headers; do the same before each data check.
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>
[Severity: Low]
Prior to commit df8e96f39103 ("[JFFS2] Improve read_inode memory usage,
v2."), jffs2_do_read_inode_internal() called cond_resched() on each node
while checking data CRCs and building the fragtree, which was dropped when
that loop moved into jffs2_build_inode_fragtree(). Should this include:
Fixes: df8e96f39103 ("[JFFS2] Improve read_inode memory usage, v2.")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118214045.107562-1-orgads@gmail.com?part=2
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2026-11-18 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 21:40 [PATCH 1/2] jffs2: check the data CRC of a node in RAM, not through point() Orgad Shaneh
2026-11-18 21:40 ` Orgad Shaneh
2026-11-18 21:40 ` [PATCH 2/2] jffs2: reschedule between the data CRC checks of an inode Orgad Shaneh
2026-11-18 21:40 ` Orgad Shaneh
2026-11-18 21:44 ` sashiko-bot [this message]
2026-11-19 8:01 ` Orgad Shaneh
2026-11-19 8:01 ` Orgad Shaneh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222025@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=orgads@gmail.com \
--cc=richard@nod.at \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.