All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Joachim Eastwood" <joachim.eastwood@gmail.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/4] drm/bridge: synopsys: dw-hdmi-qp: Attach the next bridge in the chain
Date: Wed, 18 Nov 2026 22:05:09 +0000	[thread overview]
Message-ID: <sashiko-outbox-222076@kernel.org> (raw)
In-Reply-To: <20261118-dw-hdmi-qp-bridge_attach-v1-2-e370920bc7f3@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/bridge: dw-hdmi-qp: missing DRM_DISPLAY_CONNECTOR Kconfig
  select
--

commit 2fdd511539969260584719b2d1604f9b1b9ed26e
Author: Joachim Eastwood <joachim.eastwood@gmail.com>

drm/bridge: synopsys: dw-hdmi-qp: Attach the next bridge in the chain

This commit implements drm_bridge_funcs.attach for dw-hdmi-qp to look up and
attach the next bridge connected to output port 1.

> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
> index eed249aca1e23..200229e5d9afc 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
[ ... ]
> @@ -1024,7 +1028,33 @@ static void dw_hdmi_qp_bridge_hpd_disable(struct drm_bridge *bridge)
>  		hdmi->phy.ops->disable_hpd(hdmi, hdmi->phy.data);
>  }
>  
> +static int dw_hdmi_qp_bridge_attach(struct drm_bridge *bridge,
> +				    struct drm_encoder *encoder,
> +				    enum drm_bridge_attach_flags flags)
> +{
> +	struct dw_hdmi_qp *hdmi = bridge->driver_private;
> +	struct device_node *remote __free(device_node) =
> +		of_graph_get_remote_node(hdmi->dev->of_node,
> +					 DW_HDMI_QP_OUTPUT_PORT, -1);
> +
> +	/*
> +	 * The HDMI connector node is optional. When present, chain its bridge
> +	 * so that properties such as ddc-i2c-bus, hpd-gpios and supplies are
> +	 * honoured by the DRM bridge connector.
> +	 */
> +	if (!remote)
> +		return 0;
> +
> +	struct drm_bridge *next_bridge __free(drm_bridge_put) =
> +		of_drm_find_and_get_bridge(remote);
> +	if (!next_bridge)
> +		return -EPROBE_DEFER;

[Severity: High]
Should DRM_DW_HDMI_QP (or ROCKCHIP_DW_HDMI_QP) select DRM_DISPLAY_CONNECTOR
in Kconfig?

All in-tree RK3576 and RK3588 board device trees wire port 1 to an
"hdmi-connector" node, which is handled by display-connector.c under
CONFIG_DRM_DISPLAY_CONNECTOR.  Neither DRM_DW_HDMI_QP nor
ROCKCHIP_DW_HDMI_QP selects DRM_DISPLAY_CONNECTOR, so configs that previously
worked without it will now have of_drm_find_and_get_bridge() return NULL and
defer probe forever, preventing rockchip_drm_bind() from binding the display
subsystem.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-dw-hdmi-qp-bridge_attach-v1-0-e370920bc7f3@gmail.com?part=2

  reply	other threads:[~2026-11-18 22:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 21:45 [PATCH 0/4] drm/bridge: dw-hdmi-qp: Fix HDMI output on H96 MAX V58 board Joachim Eastwood
2026-11-18 21:45 ` Joachim Eastwood via B4 Relay
2026-11-18 21:45 ` Joachim Eastwood via B4 Relay
2026-11-18 21:45 ` [PATCH 1/4] drm/bridge: synopsys: dw-hdmi-qp: Propagate the bus format to the bridge input Joachim Eastwood
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay
2026-11-18 21:45 ` [PATCH 2/4] drm/bridge: synopsys: dw-hdmi-qp: Attach the next bridge in the chain Joachim Eastwood
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay
2026-11-18 22:05   ` sashiko-bot [this message]
2026-11-18 21:45 ` [PATCH 3/4] arm64: dts: rockchip: use i2c-gpio for hdmi ddc on rk3588-h96-max-v58 Joachim Eastwood
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay
2026-11-18 21:45 ` [PATCH 4/4] arm64: dts: rockchip: enable hdmi sound " Joachim Eastwood
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay
2026-11-18 21:45   ` Joachim Eastwood via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222076@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=joachim.eastwood@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.