From: sashiko-bot@kernel.org
To: "Zack McKevitt" <zachary.mckevitt@oss.qualcomm.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 3/4] drm/drm_ras: Extend DRM RAS interface to include telemetry nodes
Date: Wed, 18 Nov 2026 23:35:21 +0000 [thread overview]
Message-ID: <sashiko-outbox-222189@kernel.org> (raw)
In-Reply-To: <20261117233442.407877-4-zachary.mckevitt@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/drm_ras: telemetry-attrs mode flags attribute uses u8
instead of u32/uint
--
commit fd2287347a17ff8e49c9be2dea7e5b0d3b353084
Author: Zack McKevitt <zachary.mckevitt@oss.qualcomm.com>
drm/drm_ras: Extend DRM RAS interface to include telemetry nodes
This commit extends the DRM RAS netlink interface with a telemetry node
type and adds operations to list telemetry fields and read or write field
values.
> diff --git a/Documentation/netlink/specs/drm_ras.yaml b/Documentation/netlink/specs/drm_ras.yaml
> index a88fdab7a1c74..28a89aef1e016 100644
> --- a/Documentation/netlink/specs/drm_ras.yaml
> +++ b/Documentation/netlink/specs/drm_ras.yaml
[ ... ]
> @@ -100,6 +105,41 @@ attribute-sets:
> name: error-value
> type: u32
> doc: Current value of the error counter.
> + -
> + name: telemetry-attrs
> + attributes:
[ ... ]
> + -
> + name: mode
> + type: u8
> + enum: telemetry-field-mode
> + doc: >-
> + Bitmask of access modes (read/write) supported by the
> + telemetry field.
[Severity: Low]
Should the mode attribute in telemetry-attrs (and struct
drm_ras_telemetry_field.mode) use u32 or uint instead of u8?
Netlink attributes are padded to 4-byte alignment, so u8 saves no space on
the wire over a 32-bit attribute while permanently limiting the
telemetry-field-mode bitmask in the userspace interface to 8 flags.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117233442.407877-1-zachary.mckevitt@oss.qualcomm.com?part=3
next prev parent reply other threads:[~2026-11-18 23:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 23:34 [PATCH v4 0/4] Extend drm_ras for qaic telemetry Zack McKevitt
2026-11-17 23:34 ` [PATCH v4 1/4] drm/drm_ras: Reference-count nodes across netlink handlers Zack McKevitt
2026-11-17 23:34 ` [PATCH v4 2/4] drm/drm_ras: Remove admin-perm flag from list-nodes operation Zack McKevitt
2026-11-17 23:34 ` [PATCH v4 3/4] drm/drm_ras: Extend DRM RAS interface to include telemetry nodes Zack McKevitt
2026-11-18 23:35 ` sashiko-bot [this message]
2026-11-17 23:34 ` [PATCH v4 4/4] accel/qaic: Add callbacks for DRM RAS netlink telemetry Zack McKevitt
2026-11-18 23:35 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222189@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zachary.mckevitt@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.