All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: raoxu <raoxu@uniontech.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v2] leds: pwm: Fix active-low brightness with default-state keep
Date: Thu, 19 Nov 2026 02:38:59 +0000	[thread overview]
Message-ID: <sashiko-outbox-222327@kernel.org> (raw)
In-Reply-To: <3EE90AC92BE07EA9+20261119023351.3933065-1-raoxu@uniontech.com>

> From: Xu Rao <raoxu@uniontech.com>
> 
> With default-state set to "keep", led_pwm_add() derives the initial
> brightness from the PWM duty cycle without accounting for active-low
> LEDs. However, led_pwm_set() inverts the duty cycle for these LEDs.
> 
> For an enabled active-low PWM, zero duty corresponds to maximum LED
> brightness, while full duty corresponds to off. The current calculation
> reports the opposite values. This exposes an incorrect cached brightness
> to userspace and can restore the wrong value after suspend. With an
> optional enable GPIO, the cached brightness also determines the initial
> GPIO value.
> 
> Invert the computed brightness for active-low LEDs, matching the
> conversion in led_pwm_set(). Only derive brightness when the PWM is
> [ ... ]
> so retaining LED_OFF for a disabled PWM also deasserts that GPIO.
> 
> Fixes: 3d3d65bd2764 ("leds: pwm: add support for default-state device property")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xu Rao <raoxu@uniontech.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/3EE90AC92BE07EA9+20261119023351.3933065-1-raoxu@uniontech.com?part=1


      reply	other threads:[~2026-11-19  2:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  2:33 [PATCH v2] leds: pwm: Fix active-low brightness with default-state keep raoxu
2026-11-19  2:38 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222327@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=raoxu@uniontech.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.