From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795076819; b=GL40MkAZG9yOk2KcSwRSmMsywIkCeSlPot15D/UU/R5n26MN1wdxkpYYl2rfDF5vm3RM i1RoOJxKZR6EbUJOCoyWfUI1vefPIhAjOL9ehnKitKyaw9Uc6pWDkcqHNMNJMcZbCGGyr za9KcqgXxqXy2LcAkiM9UoL8ToNOftiZQFWzpUpcxpxjGAXZ6JVAX5wsNj5ayuGFxupbX 2DX/YnwpAQ8uX+d/aMUFk16T0kLX7b6FwPr9GeEo1uGy++rgxKrWOP0lIWWv6sZW0AX8q V5Rhh/JTJdky6TKh2d5uOSiSvdmdaVJ0oogLM5cZMSvw+cdjLF+sBhuE3kqiyVeqvbw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795076819; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=2nUzOUiLl/rliKZGphpwEUHVcG97xuXQod6AGDHIk4Y=; b=YdERP4tzvFGWTqgWdQLW1zol6L5bSGQNf0hTTjz+faWnYq6j/8lR8NPYuBwjZ+kPju4O mSRoe7LDkHY4ZNGZY5vtFACv720DPDjH7LpprkbNyFpfvyr+k46Z/La81R8OecZNOv1xF KHFS9CXWDXv92XOhjEol93EKvcJ4hCrY1oI4Wp95Ow06uHhWHN3XslOVwEQjMKoUGpAuT QRglht4xIShFaLlBLwfE49qKYNMdDW1dj9VHjhq0voClGBsdNRWqiv4CeRHMlsph39qtQ Vmm2ic4GKyKtsi22kNCj0b8/Y8SscgLZA5EiedIIEA+uV/MR4RjIS7zPZG4D5EOKytg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UEmCllkf; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD746606A325 for ; Thu, 19 Nov 2026 08:26:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UEmCllkf Received: by smtp.kernel.org (Postfix) with ESMTPSA id 365A01F000C8; Thu, 19 Nov 2026 08:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795076819; bh=2nUzOUiLl/rliKZGphpwEUHVcG97xuXQod6AGDHIk4Y=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UEmCllkfjEpk6drgcaxUS6JXXJnGCf3yuUosATPiiDuoFCkdVTSboi4HhsY17N4QT 8PONkhKmvyFFCysL/qwyUKRLYtKxrA78GKBbJgm8K/F9EalJbzXP7EQ3cqoglXQ8mn I82rgE681P8OqwrObauJZQfw2LYMMCbnZgjeQrnb4f0NU0sOs28Qz8H/K9j+sfL2R1 nYOErvwPTbRWcxVV9WDWTn52nwsvxcYdgl6z9F7CsEnnJeS33QcoYYS+LKCaTsLHj+ KnIzLp7salsBCVPkEsZ2h+fE3azfitEKFfC8oQcIM5cLGyqZXvLbKkXcjRkZdtINOg lObsWEL3vNG9g== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH] usb: dwc3: meson: g12a: disable vbus on removal Reply-To: sashiko-reviews@lists.linux.dev To: "Wang Haoran" Cc: linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <1795076109480-15-f562c8e5@mail.zgclab.edu.cn> References: <1795076109480-15-f562c8e5@mail.zgclab.edu.cn> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 19 Nov 2026 08:26:58 +0000 X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] usb: dwc3: meson-g12a: unbalanced vbus disable in dwc3_meson_g12a_remove() It also noticed 1 related pre-existing issue this patch does not introduce: - [High] usb: dwc3: meson-g12a: unclocked access in dwc3_meson_g12a_irq_thread() [1] -- commit c61c405ca43e5b0d976be117784027e8c9ce130d Author: Wang Haoran usb: dwc3: meson: g12a: disable vbus on removal This commit disables the vbus regulator in dwc3_meson_g12a_remove() to balance the regulator_enable() call in dwc3_meson_g12a_probe(). > diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-m= eson-g12a.c > index ca07e813fd64f..4d68b50722e76 100644 > --- a/drivers/usb/dwc3/dwc3-meson-g12a.c > +++ b/drivers/usb/dwc3/dwc3-meson-g12a.c > @@ -847,6 +847,9 @@ static void dwc3_meson_g12a_remove(struct platform_de= vice *pdev) > phy_exit(priv->phys[i]); > } > =20 > + if (priv->vbus) > + regulator_disable(priv->vbus); [Severity: Medium] Can this cause an unbalanced regulator_disable() on priv->vbus when the controller is removed while in device mode? When dwc3_meson_g12a_otg_mode_set() switches to PHY_MODE_USB_DEVICE, it already disables priv->vbus: drivers/usb/dwc3/dwc3-meson-g12a.c:dwc3_meson_g12a_otg_mode_set() { ... if (priv->vbus) { if (mode =3D=3D PHY_MODE_USB_DEVICE) ret =3D regulator_disable(priv->vbus); else ret =3D regulator_enable(priv->vbus); if (ret) return ret; } priv->otg_phy_mode =3D mode; ... } Should this check priv->otg_phy_mode =3D=3D PHY_MODE_USB_HOST before calling regulator_disable(priv->vbus), matching dwc3_meson_g12a_suspend()? > + > pm_runtime_disable(dev); > pm_runtime_put_noidle(dev); > pm_runtime_set_suspended(dev); [Severity: High] This problem wasn't introduced by this patch, but can dwc3_meson_g12a_irq_thread() read unclocked registers during driver removal [1]? The OTG interrupt is requested via devm_request_threaded_irq(), so it stays enabled until devres cleanup runs after dwc3_meson_g12a_remove() returns, while dwc3_meson_g12a_remove() disables the clocks via clk_bulk_disable_unprepare() before returning: CPU0 CPU1 dwc3_meson_g12a_remove() ... clk_bulk_disable_unprepare() dwc3_meson_g12a_irq_thread() dwc3_meson_g12a_get_id() regmap_read(priv->usb_glue_regmap, = ...) <-- unclocked register access devres_release_all() If an OTG interrupt fires in that window, reading priv->usb_glue_regmap with the clocks disabled triggers an asynchronous external abort. [1] https://sashiko.dev/#/bug/linux-901d8f75-b80e-43d7-b50d-1dc1755ce4f5 --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/1795076109480-15-f5= 62c8e5@mail.zgclab.edu.cn?part=3D1 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4C1360A2620 for ; Thu, 19 Nov 2026 08:27:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=uftaR8DO; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=UEmCllkf DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=7z8zqQICm6zOdclpR58fobU0i7XXS2itsv8JQU+hhuo=; b=uftaR8DODdQcjhyNmHrIRKp/qL r33CnWsAePct5zVBqWoZCEM6a66phKBR6ufk4hP+OTPoyh8ONOYJc60SVtEPDimAZtzVEshtqf3U2 KpqwHpgG6itz+VtK3c7IiPBnxzdjW0nvRTz+NYqwGk3k8YJhWxVqsoLbkyVF/ArvQNo6JnM3hljPx KgyJOsP55nBeDgYXQvpgKT3iMVjBfIOV374LqsFBtoCndaaSJoR7iO2i5GolcmZ822rSIbU0OAY6l 7PHh2jbxpmOcefnJNlghRxEY2C09c2JokYzq3xBC1MZ3rk3+zhieBl/lrQU9xwps7a2zELHoJN4oT y7v8PQ0w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTxTx-0000000BAvH-25k1; Thu, 19 Nov 2026 08:27:01 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTxTw-0000000BAuf-1Bda for linux-amlogic@lists.infradead.org; Thu, 19 Nov 2026 08:27:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id B986862941; Thu, 19 Nov 2026 08:26:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 365A01F000C8; Thu, 19 Nov 2026 08:26:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795076819; bh=2nUzOUiLl/rliKZGphpwEUHVcG97xuXQod6AGDHIk4Y=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UEmCllkfjEpk6drgcaxUS6JXXJnGCf3yuUosATPiiDuoFCkdVTSboi4HhsY17N4QT 8PONkhKmvyFFCysL/qwyUKRLYtKxrA78GKBbJgm8K/F9EalJbzXP7EQ3cqoglXQ8mn I82rgE681P8OqwrObauJZQfw2LYMMCbnZgjeQrnb4f0NU0sOs28Qz8H/K9j+sfL2R1 nYOErvwPTbRWcxVV9WDWTn52nwsvxcYdgl6z9F7CsEnnJeS33QcoYYS+LKCaTsLHj+ KnIzLp7salsBCVPkEsZ2h+fE3azfitEKFfC8oQcIM5cLGyqZXvLbKkXcjRkZdtINOg lObsWEL3vNG9g== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH] usb: dwc3: meson: g12a: disable vbus on removal To: "Wang Haoran" Cc: linux-usb@vger.kernel.org, linux-amlogic@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <1795076109480-15-f562c8e5@mail.zgclab.edu.cn> References: <1795076109480-15-f562c8e5@mail.zgclab.edu.cn> Date: Thu, 19 Nov 2026 08:26:58 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwKaXNzdWUgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gdXNiOiBkd2MzOiBtZXNv bi1nMTJhOiB1bmJhbGFuY2VkIHZidXMgZGlzYWJsZSBpbgogIGR3YzNfbWVzb25fZzEyYV9yZW1v dmUoKQpJdCBhbHNvIG5vdGljZWQgMSByZWxhdGVkIHByZS1leGlzdGluZyBpc3N1ZSB0aGlzIHBh dGNoIGRvZXMgbm90CmludHJvZHVjZToKLSBbSGlnaF0gdXNiOiBkd2MzOiBtZXNvbi1nMTJhOiB1 bmNsb2NrZWQgYWNjZXNzIGluCiAgZHdjM19tZXNvbl9nMTJhX2lycV90aHJlYWQoKSBbMV0KLS0K CmNvbW1pdCBjNjFjNDA1Y2E0M2U1YjBkOTc2YmUxMTc3ODQwMjdlOGM5Y2UxMzBkCkF1dGhvcjog V2FuZyBIYW9yYW4gPHdhbmdocjIwMjZAbWFpbC56Z2NsYWIuZWR1LmNuPgoKdXNiOiBkd2MzOiBt ZXNvbjogZzEyYTogZGlzYWJsZSB2YnVzIG9uIHJlbW92YWwKClRoaXMgY29tbWl0IGRpc2FibGVz IHRoZSB2YnVzIHJlZ3VsYXRvciBpbiBkd2MzX21lc29uX2cxMmFfcmVtb3ZlKCkgdG8KYmFsYW5j ZSB0aGUgcmVndWxhdG9yX2VuYWJsZSgpIGNhbGwgaW4gZHdjM19tZXNvbl9nMTJhX3Byb2JlKCku Cgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9kd2MzL2R3YzMtbWVzb24tZzEyYS5jIGIvZHJp dmVycy91c2IvZHdjMy9kd2MzLW1lc29uLWcxMmEuYwo+IGluZGV4IGNhMDdlODEzZmQ2NGYuLjRk NjhiNTA3MjJlNzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvZHdjMy9kd2MzLW1lc29uLWcx MmEuYwo+ICsrKyBiL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1tZXNvbi1nMTJhLmMKPiBAQCAtODQ3 LDYgKzg0Nyw5IEBAIHN0YXRpYyB2b2lkIGR3YzNfbWVzb25fZzEyYV9yZW1vdmUoc3RydWN0IHBs YXRmb3JtX2RldmljZSAqcGRldikKPiAgCQlwaHlfZXhpdChwcml2LT5waHlzW2ldKTsKPiAgCX0K PiAgCj4gKwlpZiAocHJpdi0+dmJ1cykKPiArCQlyZWd1bGF0b3JfZGlzYWJsZShwcml2LT52YnVz KTsKCltTZXZlcml0eTogTWVkaXVtXQpDYW4gdGhpcyBjYXVzZSBhbiB1bmJhbGFuY2VkIHJlZ3Vs YXRvcl9kaXNhYmxlKCkgb24gcHJpdi0+dmJ1cyB3aGVuIHRoZQpjb250cm9sbGVyIGlzIHJlbW92 ZWQgd2hpbGUgaW4gZGV2aWNlIG1vZGU/CgpXaGVuIGR3YzNfbWVzb25fZzEyYV9vdGdfbW9kZV9z ZXQoKSBzd2l0Y2hlcyB0byBQSFlfTU9ERV9VU0JfREVWSUNFLCBpdAphbHJlYWR5IGRpc2FibGVz IHByaXYtPnZidXM6Cgpkcml2ZXJzL3VzYi9kd2MzL2R3YzMtbWVzb24tZzEyYS5jOmR3YzNfbWVz b25fZzEyYV9vdGdfbW9kZV9zZXQoKSB7CiAgICAuLi4KCWlmIChwcml2LT52YnVzKSB7CgkJaWYg KG1vZGUgPT0gUEhZX01PREVfVVNCX0RFVklDRSkKCQkJcmV0ID0gcmVndWxhdG9yX2Rpc2FibGUo cHJpdi0+dmJ1cyk7CgkJZWxzZQoJCQlyZXQgPSByZWd1bGF0b3JfZW5hYmxlKHByaXYtPnZidXMp OwoJCWlmIChyZXQpCgkJCXJldHVybiByZXQ7Cgl9CgoJcHJpdi0+b3RnX3BoeV9tb2RlID0gbW9k ZTsKICAgIC4uLgp9CgpTaG91bGQgdGhpcyBjaGVjayBwcml2LT5vdGdfcGh5X21vZGUgPT0gUEhZ X01PREVfVVNCX0hPU1QgYmVmb3JlIGNhbGxpbmcKcmVndWxhdG9yX2Rpc2FibGUocHJpdi0+dmJ1 cyksIG1hdGNoaW5nIGR3YzNfbWVzb25fZzEyYV9zdXNwZW5kKCk/Cgo+ICsKPiAgCXBtX3J1bnRp bWVfZGlzYWJsZShkZXYpOwo+ICAJcG1fcnVudGltZV9wdXRfbm9pZGxlKGRldik7Cj4gIAlwbV9y dW50aW1lX3NldF9zdXNwZW5kZWQoZGV2KTsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBwcm9ibGVt IHdhc24ndCBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCBjYW4KZHdjM19tZXNvbl9nMTJh X2lycV90aHJlYWQoKSByZWFkIHVuY2xvY2tlZCByZWdpc3RlcnMgZHVyaW5nIGRyaXZlciByZW1v dmFsClsxXT8KClRoZSBPVEcgaW50ZXJydXB0IGlzIHJlcXVlc3RlZCB2aWEgZGV2bV9yZXF1ZXN0 X3RocmVhZGVkX2lycSgpLCBzbyBpdCBzdGF5cwplbmFibGVkIHVudGlsIGRldnJlcyBjbGVhbnVw IHJ1bnMgYWZ0ZXIgZHdjM19tZXNvbl9nMTJhX3JlbW92ZSgpIHJldHVybnMsCndoaWxlIGR3YzNf bWVzb25fZzEyYV9yZW1vdmUoKSBkaXNhYmxlcyB0aGUgY2xvY2tzIHZpYQpjbGtfYnVsa19kaXNh YmxlX3VucHJlcGFyZSgpIGJlZm9yZSByZXR1cm5pbmc6CgpDUFUwICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBDUFUxCmR3YzNfbWVzb25fZzEyYV9yZW1vdmUoKQogIC4uLgogIGNsa19i dWxrX2Rpc2FibGVfdW5wcmVwYXJlKCkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZHdjM19tZXNvbl9nMTJhX2lycV90aHJlYWQoKQogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGR3YzNfbWVzb25fZzEyYV9nZXRfaWQoKQogICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgcmVnbWFwX3JlYWQocHJpdi0+dXNiX2dsdWVfcmVnbWFwLCAu Li4pCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDwtLSB1bmNsb2Nr ZWQgcmVnaXN0ZXIgYWNjZXNzCmRldnJlc19yZWxlYXNlX2FsbCgpCgpJZiBhbiBPVEcgaW50ZXJy dXB0IGZpcmVzIGluIHRoYXQgd2luZG93LCByZWFkaW5nIHByaXYtPnVzYl9nbHVlX3JlZ21hcCB3 aXRoCnRoZSBjbG9ja3MgZGlzYWJsZWQgdHJpZ2dlcnMgYW4gYXN5bmNocm9ub3VzIGV4dGVybmFs IGFib3J0LgoKWzFdIGh0dHBzOi8vc2FzaGlrby5kZXYvIy9idWcvbGludXgtOTAxZDhmNzUtYjgw ZS00M2Q3LWI1MGQtMWRjMTc1NWNlNGY1CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6 Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzE3OTUwNzYxMDk0ODAtMTUtZjU2MmM4ZTVAbWFpbC56 Z2NsYWIuZWR1LmNuP3BhcnQ9MQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYW1sb2dpYyBtYWlsaW5nIGxpc3QKbGludXgtYW1sb2dpY0BsaXN0 cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtYW1sb2dpYwo=