All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Aveline Noir" <jm5905938@gmail.com>
Cc: damon@lists.linux.dev
Subject: Re: [PATCH] mm/damon/core: skip apply_probes() when no probes are installed
Date: Thu, 19 Nov 2026 08:50:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-222725@kernel.org> (raw)
In-Reply-To: <20261119-damon-skip-empty-probes-20261119-v1-1-ec3e81c1f26b@gmail.com>

> While measuring vaddr monitoring overhead, I noticed that kdamond calls
> apply_probes() every sampling interval even if no probes are installed.
> The vaddr callback walks the page tables for each region's sample, and
> paddr looks up a folio and takes a reference if it can. There are no
> probe hits to count in either case.
> 
> Skip the callback when the probe list is empty. Ordinary access checks
> still run, and installed probes with zero weight are still applied.
> 
> Signed-off-by: Aveline Noir <jm5905938@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-damon-skip-empty-probes-20261119-v1-1-ec3e81c1f26b@gmail.com?part=1


  reply	other threads:[~2026-11-19  8:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  8:39 [PATCH] mm/damon/core: skip apply_probes() when no probes are installed Aveline Noir
2026-11-19  8:50 ` sashiko-bot [this message]
2026-11-19 15:20 ` SJ Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222725@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=damon@lists.linux.dev \
    --cc=jm5905938@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.