From: sashiko-bot@kernel.org
To: "Jie Gan" <jie.gan@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH RFC 1/6] dt-bindings: soc: qcom: add QDCP provider
Date: Thu, 19 Nov 2026 09:12:45 +0000 [thread overview]
Message-ID: <sashiko-outbox-222794@kernel.org> (raw)
In-Reply-To: <20261119-introduce-qcom-qecp-feature-v1-1-b1a730d2c57a@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: soc: qcom: qcom,qdcp models virtual QMI driver
and lookup IDs
- [Low] dt-bindings: soc: qcom: unused labels in qcom,qdcp example fail
style check
--
commit 975ed970c6f545b1a481d1850cc2e7de01d28cd7
Author: Jie Gan <jie.gan@oss.qualcomm.com>
dt-bindings: soc: qcom: add QDCP provider
This commit adds a Devicetree binding schema for the Qualcomm Debug Control
Protocol (QDCP) firmware provider node and its QMI connection child nodes.
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,qdcp.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,qdcp.yaml
> new file mode 100644
> index 0000000000000..ee0a66b12dde7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,qdcp.yaml
> @@ -0,0 +1,81 @@
[ ... ]
> + This node does not represent a CoreSight graph device. It is a platform
> + driver that establishes the QMI connections used by consumer drivers such
> + as the Qualcomm QDCP STM source and QDCP-backed TMC/ETR sink.
> +
> + QECP exposes more than one independent QMI service (for example, a
> + separate service used by remote ETM/diag sources). Each QMI connection is
> + described as a child node of the "qcom,qdcp" node rather than as a
> + property of the node itself, so a single provider device can establish
> + more than one connection. A node without any "connection-N" child is valid
> + but provides nothing for consumers to reference.
> +
> +properties:
> + compatible:
> + const: qcom,qdcp
> +
> +patternProperties:
> + "^connection-[0-9]+$":
> + type: object
> + description:
> + A single QMI connection established by the QDCP provider. Consumers
> + reference this child node directly via their "qcom,qdcp" phandle, not
> + the top-level provider node.
> +
> + properties:
> + qcom,service-id:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + QMI service identifier for this connection.
> +
> + qcom,version:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + default: 1
> + description:
> + QMI service version for this connection.
> +
> + qcom,instance-id:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + QMI instance identifier for this connection.
[Severity: Medium]
Does this binding model a virtual Linux platform driver and its QMI lookup
parameters rather than hardware?
The top-level qcom,qdcp node has no hardware resources or SoC-specific
compatible string, and its resource-less connection-N child nodes exist only
to pass qcom,service-id, qcom,version and qcom,instance-id into the driver's
qmi_add_lookup() call, encoding driver implementation details in the
Devicetree ABI instead of keeping QMI service constants in driver match data
or passing provider arguments via phandle cells.
[ ... ]
> +examples:
> + - |
> + qdcp: qdcp {
> + compatible = "qcom,qdcp";
> +
> + qdcp_coresight: connection-0 {
> + qcom,service-id = <0x453>;
> + qcom,instance-id = <32>;
> + };
> + };
[Severity: Low]
Should the unreferenced qdcp and qdcp_coresight labels be dropped from the
example? Neither label is referenced in the example, which causes
scripts/dtc/dt-check-style --mode=strict to report unused-labels warnings.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-introduce-qcom-qecp-feature-v1-0-b1a730d2c57a@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-11-19 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:01 [PATCH RFC 0/6] Coresight: Introduce Qualcomm QDCP support for QECP-owned trace blocks Jie Gan
2026-11-19 9:01 ` [PATCH RFC 1/6] dt-bindings: soc: qcom: add QDCP provider Jie Gan
2026-11-19 9:12 ` sashiko-bot [this message]
2026-11-19 14:00 ` Krzysztof Kozlowski
2026-11-19 9:01 ` [PATCH RFC 2/6] soc: qcom: add QDCP firmware provider Jie Gan
2026-11-19 9:18 ` sashiko-bot
2026-11-19 9:01 ` [PATCH RFC 3/6] dt-bindings: arm: qcom: add QDCP STM source Jie Gan
2026-11-19 14:02 ` Krzysztof Kozlowski
2026-11-19 9:01 ` [PATCH RFC 4/6] coresight: " Jie Gan
2026-11-19 9:28 ` sashiko-bot
2026-11-19 9:01 ` [PATCH RFC 5/6] dt-bindings: arm: qcom: add QDCP TMC ETR sink Jie Gan
2026-11-19 9:01 ` [PATCH RFC 6/6] coresight: tmc: add QDCP ETR sysfs support Jie Gan
2026-11-19 9:25 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222794@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.