From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2 22/22] ARM: dts: BCM5301X: enable GMACs in boards that use them
Date: Thu, 19 Nov 2026 09:13:00 +0000 [thread overview]
Message-ID: <sashiko-outbox-222796@kernel.org> (raw)
In-Reply-To: <20261119085452.75708-23-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] ARM: dts: broadcom: gmac2 left disabled in
bcm53016-dlink-dwl-8610ap.dts
- [Low] ARM: dts: broadcom: duplicate &gmac2 block in
bcm4708-netgear-r6250.dts
--
commit c0782627fd863018b57e6570e61b8093bae3e6d0
Author: Rosen Penev <rosenp@gmail.com>
ARM: dts: BCM5301X: enable GMACs in boards that use them
This commit disables all four GMACs by default in bcm-ns.dtsi and
enables the active GMACs in each board DTS.
[ ... ]
> diff --git a/arch/arm/boot/dts/broadcom/bcm4708-netgear-r6250.dts b/arch/arm/boot/dts/broadcom/bcm4708-netgear-r6250.dts
> index 81c2e6652a27e..1b33265d897f2 100644
> --- a/arch/arm/boot/dts/broadcom/bcm4708-netgear-r6250.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm4708-netgear-r6250.dts
> @@ -146,3 +146,7 @@ port@8 {
> };
> };
> };
> +
> +&gmac2 {
> + status = "okay";
> +};
[Severity: Low]
This file already defines an &gmac2 block earlier for nvmem-cells:
arch/arm/boot/dts/broadcom/bcm4708-netgear-r6250.dts:
&gmac2 {
nvmem-cells = <&et0macaddr 0>;
nvmem-cell-names = "mac-address";
};
Should status = "okay" be placed inside that existing &gmac2 block
instead of adding a second one?
[ ... ]
> diff --git a/arch/arm/boot/dts/broadcom/bcm53016-dlink-dwl-8610ap.dts b/arch/arm/boot/dts/broadcom/bcm53016-dlink-dwl-8610ap.dts
> index c1f54391746fa..9f14d78f66f60 100644
> --- a/arch/arm/boot/dts/broadcom/bcm53016-dlink-dwl-8610ap.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm53016-dlink-dwl-8610ap.dts
> @@ -80,11 +80,15 @@ et1macaddr: et1macaddr {
> };
>
> &gmac0 {
> + status = "okay";
> +
> nvmem-cells = <&et0macaddr>;
> nvmem-cell-names = "mac-address";
> };
>
> &gmac1 {
> + status = "okay";
> +
> nvmem-cells = <&et1macaddr>;
> nvmem-cell-names = "mac-address";
> };
[Severity: Medium]
Should &gmac2 also be enabled on this board?
bcm53016-dlink-dwl-8610ap.dts does not enable the srab switch node, so
following the rule for boards without a switch node, leaving gmac2
disabled will break Ethernet connectivity if the bootloader leaves CPU
traffic routed to port 8.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119085452.75708-1-rosenp@gmail.com?part=22
prev parent reply other threads:[~2026-11-19 9:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 8:54 [PATCH v2 00/22] ARM: dts: BCM5301X: describe switches and use gmac2 as the CPU port Rosen Penev
2026-11-19 8:54 ` [PATCH v2 01/22] ARM: dts: BCM5301X: AC56U: specify switch Rosen Penev
2026-11-19 8:54 ` [PATCH v2 02/22] ARM: dts: BCM5301X: AC68U: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 03/22] ARM: dts: BCM5301X: N18U: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 04/22] ARM: dts: BCM5301X: R7000: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 05/22] ARM: dts: BCM5301X: EA6300: set gmac2 MAC address from nvram Rosen Penev
2026-11-19 8:54 ` [PATCH v2 06/22] ARM: dts: BCM5301X: EA6300: specify switch Rosen Penev
2026-11-19 8:54 ` [PATCH v2 07/22] ARM: dts: BCM5301X: phicomm-k3: add nvram node Rosen Penev
2026-11-19 8:54 ` [PATCH v2 08/22] ARM: dts: BCM5301X: phicomm-k3: specify switch Rosen Penev
2026-11-19 8:54 ` [PATCH v2 09/22] ARM: dts: BCM5301X: R6300 v2: add nvram node Rosen Penev
2026-11-19 8:54 ` [PATCH v2 10/22] ARM: dts: BCM5301X: R6300 v2: specify switch Rosen Penev
2026-11-19 8:54 ` [PATCH v2 11/22] ARM: dts: BCM5301X: EA6500 v2: add nvram node Rosen Penev
2026-11-19 8:54 ` [PATCH v2 12/22] ARM: dts: BCM5301X: EA6500 v2: specify switch Rosen Penev
2026-11-19 8:54 ` [PATCH v2 13/22] ARM: dts: BCM5301X: R8500: add nvram node Rosen Penev
2026-11-19 8:54 ` [PATCH v2 14/22] ARM: dts: BCM5301X: R8500: specify switch Rosen Penev
2026-11-19 8:54 ` [PATCH v2 15/22] ARM: dts: BCM5301X: WZR-900DHP: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 16/22] ARM: dts: BCM5301X: WZR-1750DHP: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 17/22] ARM: dts: BCM5301X: WXR-1900DHP: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 18/22] ARM: dts: BCM5301X: Archer C5 v2: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 19/22] ARM: dts: BCM5301X: Archer C9 v1: " Rosen Penev
2026-11-19 8:54 ` [PATCH v2 20/22] ARM: dts: BCM5301X: DIR-885L: use gmac2 Rosen Penev
2026-11-19 8:54 ` [PATCH v2 21/22] ARM: dts: BCM5301X: use gmac2 as the CPU port Rosen Penev
2026-11-19 8:54 ` [PATCH v2 22/22] ARM: dts: BCM5301X: enable GMACs in boards that use them Rosen Penev
2026-11-19 9:13 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222796@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.