All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tomohiro Misono" <misono.tomohiro@fujitsu.com>
Cc: linux-perf-users@vger.kernel.org, kvmarm@lists.linux.dev,
	"Oliver Upton" <oupton@kernel.org>,
	"Marc Zyngier" <maz@kernel.org>
Subject: Re: [PATCH v3 4/5] irqchip/gicv3: Add workaround for FUJITSU-MONAKA Erratum E#030003
Date: Thu, 19 Nov 2026 09:21:02 +0000	[thread overview]
Message-ID: <sashiko-outbox-222816@kernel.org> (raw)
In-Reply-To: <20261119-monaka-fix-for-upstream-v3-4-057df4d2ca3c@fujitsu.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] irqchip/gic-v3: unused variable gic_fujitsu_030003_erratum on
  ARM !SMP
--

commit f40f855ff6d7f791ef5d86b82bce961af1c3d29b
Author: Kohei Enju <enju.kohei@fujitsu.com>

irqchip/gicv3: Add workaround for FUJITSU-MONAKA Erratum E#030003

This commit adds a quirk for FUJITSU-MONAKA Erratum E#030003 to send SGIs
by writing to the target redistributor's GICR_ISPENDR0 register instead of
the ICC_SGI*R_EL1 system registers.

> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index 94873646d46fb..18f8b2b40543a 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -80,6 +80,8 @@ static DEFINE_STATIC_KEY_FALSE(gic_nvidia_t241_erratum);
>  
>  static DEFINE_STATIC_KEY_FALSE(gic_arm64_2941627_erratum);
>  
> +static DEFINE_STATIC_KEY_FALSE(gic_fujitsu_030003_erratum);
> +
>  static struct gic_chip_data gic_data __read_mostly;
>  static DEFINE_STATIC_KEY_TRUE(supports_deactivate_key);
>  

[Severity: Low]
Does defining gic_fujitsu_030003_erratum unconditionally trigger a
-Wunused-variable warning when building with CONFIG_ARM=y and
CONFIG_SMP=n?

Its only two users are gic_ipi_send_mask() (under #ifdef CONFIG_SMP) and
gic_enable_quirk_fujitsu_030003() (under #ifdef CONFIG_ARM64), so both are
compiled out on 32-bit ARM UP builds.  Marking it __maybe_unused (like
broken_rdists earlier in the file) or guarding it with #ifdef CONFIG_SMP
would avoid the warning.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-monaka-fix-for-upstream-v3-0-057df4d2ca3c@fujitsu.com?part=4

  reply	other threads:[~2026-11-19  9:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:04 [PATCH v3 0/5] arm64: Add workarounds for FUJITSU-MONAKA CPU Tomohiro Misono
2026-11-19  9:04 ` [PATCH v3 1/5] arm64: cputype: Add FUJITSU MONAKA definition Tomohiro Misono
2026-11-19  9:09   ` sashiko-bot
2026-11-19  9:04 ` [PATCH v3 2/5] arm64: tlb: Add tlbi workaround for FUJITSU-MONAKA Erratum E#030001 Tomohiro Misono
2026-11-19  9:30   ` sashiko-bot
2026-11-20  7:47     ` Tomohiro Misono (Fujitsu)
2026-11-19  9:04 ` [PATCH v3 3/5] perf: arm_pmu: Add workaround for FUJITSU-MONAKA Erratum E#030002 Tomohiro Misono
2026-11-19  9:16   ` sashiko-bot
2026-11-19  9:04 ` [PATCH v3 4/5] irqchip/gicv3: Add workaround for FUJITSU-MONAKA Erratum E#030003 Tomohiro Misono
2026-11-19  9:21   ` sashiko-bot [this message]
2026-11-20  9:53   ` kernel test robot
2026-11-19  9:04 ` [PATCH v3 5/5] arm64: Add workaround to replace WFE with NOP for FUJITSU-MONAKA Erratum E#030004 Tomohiro Misono
2026-11-19  9:19   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-222816@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=misono.tomohiro@fujitsu.com \
    --cc=oupton@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.