From: sashiko-bot@kernel.org
To: "Raag Jadav" <raag.jadav@intel.com>, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v3 2/2] drm/xe/wedge: Introduce xe_wedge_mode_is_no_reset()
Date: Thu, 19 Nov 2026 09:58:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-222890@kernel.org> (raw)
In-Reply-To: <20261119095151.2041411-3-raag.jadav@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/xe: unconverted no-reset wedge check in
guc_submit_hint_wedged()
--
commit 639a1a01865e9d03bd91aba733177709c6405dcb
Author: Raag Jadav <raag.jadav@intel.com>
drm/xe/wedge: Introduce xe_wedge_mode_is_no_reset()
This commit introduces the xe_wedge_mode_is_no_reset() helper and replaces
open-coded XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET checks across the driver.
[ ... ]
> diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
> index b5c916a764dbe..fc0f50307f2f5 100644
> --- a/drivers/gpu/drm/xe/xe_guc_submit.c
> +++ b/drivers/gpu/drm/xe/xe_guc_submit.c
> @@ -1435,7 +1435,7 @@ void xe_guc_submit_wedge(struct xe_guc *guc)
> if (!guc->submission_state.initialized)
> return;
>
> - if (xe->wedged.mode == XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET) {
> + if (xe_wedge_mode_is_no_reset(xe)) {
> mutex_lock(&guc->submission_state.lock);
> xa_for_each(&guc->submission_state.exec_queue_lookup, index, q)
> if (xe_exec_queue_get_unless_zero(q))
[Severity: Low]
Should guc_submit_hint_wedged() right below xe_guc_submit_wedge() also use
!xe_wedge_mode_is_no_reset(xe), like drm_ras_counter_get()?
drivers/gpu/drm/xe/xe_guc_submit.c:guc_submit_hint_wedged() {
struct xe_device *xe = guc_to_xe(guc);
if (xe->wedged.mode != XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET)
return false;
...
}
It is the only remaining open-coded check of xe->wedged.mode against
XE_WEDGED_MODE_UPON_ANY_HANG_NO_RESET outside xe_wedge_mode_is_no_reset().
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119095151.2041411-1-raag.jadav@intel.com?part=2
prev parent reply other threads:[~2026-11-19 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:51 [PATCH v3 0/2] Protect drm_ras against unplugged or wedged device Raag Jadav
2026-11-19 9:51 ` [PATCH v3 1/2] drm/xe/drm_ras: Protect " Raag Jadav
2026-11-19 9:51 ` [PATCH v3 2/2] drm/xe/wedge: Introduce xe_wedge_mode_is_no_reset() Raag Jadav
2026-11-19 9:58 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222890@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=raag.jadav@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.