From: sashiko-bot@kernel.org
To: "Yige Jiang" <yigejiang86@gmail.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH] virtio: Release the OF node when unregistering the device
Date: Thu, 19 Nov 2026 10:10:30 +0000 [thread overview]
Message-ID: <sashiko-outbox-222919@kernel.org> (raw)
In-Reply-To: <20261119085343.virtio-of-node-a02bd3cf522b@gmail.com>
> virtio_device_of_init() acquires the OF node reference once during device
> registration. virtio_dev_remove() currently puts it on each driver unbind,
> although rebinding the driver does not acquire a new reference. Repeated
> unbinds can therefore consume references not owned by the virtio device.
> Conversely, unregistering a device that never bound to a driver leaves
> the reference held.
>
> Move the put to unregister_virtio_device() so it is paired with device
> registration. Save the node pointer before device_unregister(), which
> can free the virtio device, and put it after unregister has completed the
> driver removal.
>
> Fixes: 694a1116b405 ("virtio: Bind virtio device to device-tree node")
> Reported-by: sashiko-bot <sashiko-bot@kernel.org>
> Link: https://lore.kernel.org/all/sashiko-outbox-203883@kernel.org/
> Cc: stable@vger.kernel.org
> Signed-off-by: Yige Jiang <yigejiang86@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119085343.virtio-of-node-a02bd3cf522b@gmail.com?part=1
prev parent reply other threads:[~2026-11-19 10:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 10:06 [PATCH] virtio: Release the OF node when unregistering the device Yige Jiang
2026-11-19 10:10 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222919@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=yigejiang86@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.