From: sashiko-bot@kernel.org
To: "Long Zhao" <longzhao@ambarella.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v12 5/6] arm64: dts: ambarella: add CV75 SoC and EVK
Date: Thu, 19 Nov 2026 10:31:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-222956@kernel.org> (raw)
In-Reply-To: <20261119-cv75-soc-v12-5-e5a03cca8b05@ambarella.com>
Thank you for your contribution! Sashiko AI review found 5 potential
issues to consider:
- [High] arm64: dts: ambarella: uart0 console fails probe due to unbound
pinctrl-0
- [Medium] arm64: dts: ambarella: apb simple-bus reg causes -EBUSY in
amba_device_add()
- [Medium] arm64: dts: ambarella: undocumented compatible strings and
properties in cv75
- [Medium] arm64: dts: ambarella: gpio nodes use unmatched periphid and
unprobed pinctrl
- [Low] arm64: dts: ambarella: cpu@1 unit-address mismatches reg =
<0x100> in cv75
--
commit e70f7e3684557e5b6677d7d83d584310569d7473
Author: Long Zhao <longzhao@ambarella.com>
arm64: dts: ambarella: add CV75 SoC and EVK
This commit adds the minimal Devicetree files for the Ambarella CV75 SoC and
CV75 EVK board, along with Makefile and arm64 defconfig entries.
> diff --git a/arch/arm64/boot/dts/ambarella/cv75.dtsi b/arch/arm64/boot/dts/ambarella/cv75.dtsi
> new file mode 100644
> index 0000000000000..c36b6af48237a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ambarella/cv75.dtsi
> @@ -0,0 +1,177 @@
[ ... ]
> + cpu@1 {
> + compatible = "arm,cortex-a76";
> + device_type = "cpu";
> + reg = <0x100>;
> + enable-method = "psci";
> + };
[Severity: Low]
Should this node be named cpu@100 to match reg = <0x100>? The mismatch
triggers a unit_address_vs_reg warning from dtc and fails dtbs_check against
cpus.yaml.
[ ... ]
> + ahb@ffe0000000 {
> + compatible = "simple-bus";
> + reg = <0xff 0xe0000000 0x0 0x01000000>;
> + ranges = <0xe0000000 0xff 0xe0000000 0x01000000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + s_scratchpad_syscon: scratchpad@e002e000 {
> + compatible = "ambarella,cv75-sec-scratchpad", "syscon";
> + reg = <0xe002e000 0x1000>;
> + };
> + };
> +
> + apb@ffe4000000 {
> + compatible = "simple-bus";
> + reg = <0xff 0xe4000000 0x0 0x01000000>;
> + ranges = <0xe4000000 0xff 0xe4000000 0x01000000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
[Severity: Medium]
Does specifying a reg property on apb@ffe4000000 (and ahb@ffe0000000) prevent
the child arm,primecell GPIO devices from registering?
When of_platform_bus_create() populates apb@ffe4000000, platform_device_add()
inserts [0xffe4000000 - 0xffe4ffffff] directly into iomem_resource. For the
child arm,primecell GPIO nodes, of_amba_device_create() calls
amba_device_add() with parent = &iomem_resource, which uses
request_resource(&iomem_resource, &dev->res) instead of nesting inside the bus
resource and fails with -EBUSY. Dropping reg from these simple-bus nodes (and
keeping ranges) avoids the top-level resource conflict and satisfies
simple-bus.yaml.
> +
> + uart0: serial@e4000000 {
> + compatible = "ambarella,cv75-uart", "snps,dw-apb-uart";
> + reg = <0xe4000000 0x1000>;
> + clocks = <&rct CV75_GCLK_UART0>;
> + interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
> + reg-shift = <2>;
> + reg-io-width = <4>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0_pins>;
> +
> + status = "disabled";
> + };
[Severity: High]
Will uart0 permanently defer probing on cv75-evk because pinctrl-0 references
&uart0_pins under pinctrl@e4010000?
No driver in the tree matches "ambarella,cv75-pinctrl", so no pinctrl_dev is
registered for pinctrl@e4010000. When serial@e4000000 is enabled as the
console in cv75-evk.dts, really_probe() -> pinctrl_bind_pins() ->
dt_to_map_one_config() cannot find the pinctrl supplier and returns
-EPROBE_DEFER whenever CONFIG_MODULES is enabled, leaving the board without a
serial console.
> +
> + pinctrl: pinctrl@e4010000 {
> + compatible = "ambarella,cv75-pinctrl";
> + reg = <0xe4010000 0x1000>;
> + ambarella,drive-strength-syscon = <&rct>;
> + ambarella,pull-syscon = <&s_scratchpad_syscon>;
> +
> + uart0_pins: uart0-pins {
> + function = "uart0";
> + groups = "uart0";
> + };
> + };
[Severity: Medium]
Are the Devicetree binding schemas for the new compatible strings and
properties in this file missing from the series?
"ambarella,cv75-sec-scratchpad", "ambarella,cv75-uart",
"ambarella,cv75-pinctrl" (along with ambarella,drive-strength-syscon and
ambarella,pull-syscon), and "ambarella,cv75-gpio" are not documented under
Documentation/devicetree/bindings/, causing make dtbs_check to fail on
cv75-evk.dtb.
> +
> + gpio0: gpio@e4013000 {
> + compatible = "ambarella,cv75-gpio", "arm,primecell";
> + reg = <0xe4013000 0x1000>;
> + clocks = <&rct CV75_GCLK_APB>;
> + clock-names = "apb_pclk";
> + interrupts = <GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&pinctrl 0 0 32>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + arm,primecell-periphid = <0x000e8061>;
> + };
[Severity: Medium]
Can gpio0, gpio1, and gpio2 bind to any in-tree driver with
arm,primecell-periphid = <0x000e8061> and gpio-ranges = <&pinctrl ...>?
Because "arm,primecell" is in compatible, these nodes are created as AMBA
devices that match only on periphid, and no AMBA driver in the tree matches
0x000e8061 (gpio-pl061 only matches 0x00041061 with 8 lines per block rather
than 32). In addition, gpio-ranges points to &pinctrl, which has no driver in
the tree and would cause of_gpiochip_add_pin_range() to defer with
-EPROBE_DEFER.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-cv75-soc-v12-0-e5a03cca8b05@ambarella.com?part=5
next prev parent reply other threads:[~2026-11-19 10:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 10:13 [PATCH v12 0/6] arm64: add Ambarella CV75 SoC support Long Zhao
2026-11-19 10:13 ` Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 1/6] dt-bindings: arm: add Ambarella CV75 platforms Long Zhao
2026-11-19 10:13 ` Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 2/6] dt-bindings: clock: add Ambarella CV75 RCT Long Zhao
2026-11-19 10:13 ` Long Zhao via B4 Relay
2026-11-19 10:13 ` [PATCH v12 3/6] arm64: add ARCH_AMBARELLA Long Zhao via B4 Relay
2026-11-19 10:13 ` Long Zhao
2026-11-19 10:13 ` [PATCH v12 4/6] clk: ambarella: add CV75 RCT clock controller Long Zhao via B4 Relay
2026-11-19 10:13 ` Long Zhao
2026-11-19 10:22 ` Andy Shevchenko
2026-11-19 10:13 ` [PATCH v12 5/6] arm64: dts: ambarella: add CV75 SoC and EVK Long Zhao via B4 Relay
2026-11-19 10:13 ` Long Zhao
2026-11-19 10:31 ` sashiko-bot [this message]
2026-11-19 10:13 ` [PATCH v12 6/6] MAINTAINERS: add ARM/AMBARELLA SoC support Long Zhao via B4 Relay
2026-11-19 10:13 ` Long Zhao
2026-11-19 14:18 ` [PATCH v12 0/6] arm64: add Ambarella CV75 " Arnd Bergmann
2026-11-19 14:40 ` Brian Masney
2026-11-19 14:30 ` patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-222956@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=longzhao@ambarella.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.