From: sashiko-bot@kernel.org
To: "Dmitry Antipov" <dmantipov@yandex.ru>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v3 2/2] HID: usbhid: free unsent raw output reports in usbhid_stop()
Date: Thu, 19 Nov 2026 11:07:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-223007@kernel.org> (raw)
In-Reply-To: <20261119105551.488524-2-dmantipov@yandex.ru>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] HID: usbhid: Fixes trailer cites c500c9714011 instead of
f129ea6d1efe
--
commit 589b15fa1479bdb0a0e176cff9a3a3493562ddb5
Author: Dmitry Antipov <dmantipov@yandex.ru>
> HID: usbhid: free unsent raw output reports in usbhid_stop()
>
> When HID device is stalled or disconnected, there might be an
> unsent (i.e. never passed via hid_submit_out()) output reports.
> So free their raw buffers in usbhid_stop() to avoid memory leaks.
> Adjust hid_irq_out() to prevent hid_submit_out() from using an
> uninitialized output pipe slot as well.
>
> This is a companion of commit f7744fa16b96 ("HID: usbhid: free
> raw_report buffers in usbhid_stop") and inspired by that one.
>
> Reported-by: syzbot+e2c057ea576d2644e2be@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=e2c057ea576d2644e2be
> Fixes: c500c9714011 ("HID: hid, make parsing event driven")
> Assisted-by: Sashiko-0.2.5:gemini-3.1-pro-preview
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
[Severity: Low]
At c500c9714011 ("HID: hid, make parsing event driven"), struct
usbhid_device stored struct hid_report pointers in out[] rather than
dynamically allocated raw_report buffers. The per-entry raw_report
allocation in usbhid->out[] was introduced by f129ea6d1efe ("HID: fix a
lockup regression when using force feedback on a PID device"), so should
the Fixes tag be:
Fixes: f129ea6d1efe ("HID: fix a lockup regression when using force feedback on a PID device")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119105551.488524-1-dmantipov@yandex.ru?part=2
prev parent reply other threads:[~2026-11-19 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 10:55 [PATCH v3 1/2] HID: usbhid: adjust output pipe FIFO size Dmitry Antipov
2026-11-19 10:55 ` [PATCH v3 2/2] HID: usbhid: free unsent raw output reports in usbhid_stop() Dmitry Antipov
2026-11-19 11:07 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223007@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.