All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Herve Codina" <herve.codina@bootlin.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 5/5] bus: simple-pm-bus: Populate child nodes at probe
Date: Thu, 19 Nov 2026 11:16:20 +0000	[thread overview]
Message-ID: <sashiko-outbox-223016@kernel.org> (raw)
In-Reply-To: <20261119110014.582363-6-herve.codina@bootlin.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bus: simple-pm-bus: invalid Fixes trailer SHA 628b8ca3e915
--

commit e4f7a29754a7ea513e3c43d4f852eb4379192762
Author: Herve Codina <herve.codina@bootlin.com>

bus: simple-pm-bus: Populate child nodes at probe

This commit updates simple_pm_bus_probe() in drivers/bus/simple-pm-bus.c
to populate child devices during probe for transparent bus matches via
of_platform_default_populate(), and updates simple_pm_bus_depopulate() to
depopulate directly when runtime PM is not enabled.

[Severity: Low]
In the commit message, the Fixes: trailer references commit 628b8ca3e915
("bus: simple-pm-bus: Remove child devices when the bus is unbound"),
which cannot be resolved in the repository and points to an unmerged
patch from earlier in the same series rather than a stable upstream
commit. Probing transparent bus-only devices in simple_pm_bus_probe() and
returning early without populating their child nodes during probe was
originally introduced in commit 98e96cf80045 ("drivers: bus:
simple-pm-bus: Add support for probing simple bus only devices").

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119110014.582363-1-herve.codina@bootlin.com?part=5

  reply	other threads:[~2026-11-19 11:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 11:00 [PATCH v10 0/5] lan966x pci device: Add support for SFPs, simple-bus part Herve Codina
2026-11-19 11:00 ` [PATCH v10 1/5] bus: simple-pm-bus: Avoid inconsistencies between probe() and remove() Herve Codina
2026-11-19 11:00 ` [PATCH v10 2/5] bus: simple-pm-bus: Remove the remove() function Herve Codina
2026-11-19 11:00 ` [PATCH v10 3/5] bus: simple-pm-bus: Remove child devices when the bus is unbound Herve Codina
2026-11-19 11:00 ` [PATCH v10 4/5] ARM: OMAP2+: pdata-quirks: Pass auxdata for simple-bus devices Herve Codina
2026-11-19 11:00 ` [PATCH v10 5/5] bus: simple-pm-bus: Populate child nodes at probe Herve Codina
2026-11-19 11:16   ` sashiko-bot [this message]
2026-11-19 11:25 ` [PATCH v10 0/5] lan966x pci device: Add support for SFPs, simple-bus part Herve Codina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223016@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=herve.codina@bootlin.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.