All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Guixiong Wei" <weiguixiong@bytedance.com>, dmaengine@vger.kernel.org
Cc: vkoul@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH] dmaengine: idxd: Restrict DSACAP reads to DSA devices
Date: Thu, 19 Nov 2026 11:26:47 +0000	[thread overview]
Message-ID: <sashiko-outbox-223029@kernel.org> (raw)
In-Reply-To: <20261119112212.92663-2-weiguixiong@bytedance.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dmaengine: idxd: missing Fixes trailer for unguarded DSACAP
  register reads
--

commit 20d136fa0348a2bd1e8670da1c059a69c7edbff4
Author: Guixiong Wei <weiguixiong@bytedance.com>

> dmaengine: idxd: Restrict DSACAP reads to DSA devices
>
> idxd_read_caps() reads DSACAP0-2 whenever the hardware version is 3 or
> later, regardless of the accelerator type. On IAA devices, offset 0x180
> is IAACAP, which is already read by the separate IAA capability path.
> The additional reads populate DSA capability fields that are not used
> by IAA devices.
>
> Restrict DSACAP reads to DSA devices, matching the device type check used
> for dsacaps sysfs visibility and SGL support.
>
> Signed-off-by: Guixiong Wei <weiguixiong@bytedance.com>

[Severity: Low]
Since this fixes the unguarded DSACAP0-2 reads in idxd_read_caps(),
should it include a Fixes: tag?

  Fixes: 8308510b9365 ("dmaengine: idxd: Expose DSA3.0 capabilities through sysfs")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119112212.92663-2-weiguixiong@bytedance.com?part=1

      reply	other threads:[~2026-11-19 11:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 11:22 [PATCH] dmaengine: idxd: Restrict DSACAP reads to DSA devices Guixiong Wei
2026-11-19 11:26 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223029@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vkoul@kernel.org \
    --cc=weiguixiong@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.