From: sashiko-bot@kernel.org
To: "Zhanpeng Zhang" <zhangzhanpeng.jasper@bytedance.com>
Cc: linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v13 02/11] riscv: add support for SBI Supervisor Software Events extension
Date: Thu, 19 Nov 2026 12:36:53 +0000 [thread overview]
Message-ID: <sashiko-outbox-223096@kernel.org> (raw)
In-Reply-To: <20261119120824.13969-15-zhangzhanpeng.jasper@bytedance.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] riscv: sbi_sse: field-spanning memcpy() on regs->a6 in do_sse()
- [High] riscv: sse: NULL tp dereference in handle_sse() during
__switch_to()
--
commit 498ea890d0b707a9ef408aa0d005f9d3ac0e2ea3
Author: Clément Léger <cleger@rivosinc.com>
riscv: add support for SBI Supervisor Software Events extension
This commit adds architectural support for the RISC-V SBI Supervisor
Software Events (SSE) extension, including dedicated per-event stacks,
entry/exit assembly, and context preservation across SSE handlers.
Link: https://lore.kernel.org/r/as79MHtNYd-VbUug@hu-himchau-blr.qualcomm.com/
> diff --git a/arch/riscv/kernel/sbi_sse.c b/arch/riscv/kernel/sbi_sse.c
> new file mode 100644
> index 0000000000000..032fcc07abcf7
> --- /dev/null
> +++ b/arch/riscv/kernel/sbi_sse.c
> @@ -0,0 +1,251 @@
[ ... ]
> +void noinstr do_sse(struct sse_event_arch_data *arch_evt,
> + struct pt_regs *regs, unsigned long hstatus)
> +{
> + struct riscv_sse_interrupted_context context = { regs, hstatus };
> + struct riscv_sse_interrupted_context *previous;
> + struct sbiret sret;
> +
> + nmi_enter();
> + instrumentation_begin();
> +
> + /* Retrieve missing GPRs from SBI */
> + sret = sbi_ecall(SBI_EXT_SSE, SBI_SSE_EVENT_ATTR_READ, arch_evt->evt_id,
> + SBI_SSE_ATTR_INTERRUPTED_A6,
> + (SBI_SSE_ATTR_INTERRUPTED_A7 -
> + SBI_SSE_ATTR_INTERRUPTED_A6) + 1,
> + (unsigned long)arch_evt->interrupted_phys, 0, 0);
> + if (sret.error) {
> + pr_warn("Failed to read interrupted registers for event %x: %ld\n",
> + arch_evt->evt_id, sret.error);
> + /* Let the client quiesce its source without using incomplete regs. */
> + sse_handle_event(arch_evt, NULL);
> + goto out;
> + }
> +
> + memcpy(®s->a6, arch_evt->interrupted,
> + sizeof(*arch_evt->interrupted));
> +
> + /* Make the interrupted frame visible while clients handle this event. */
> + previous = this_cpu_read(riscv_sse_interrupted_context);
> + this_cpu_write(riscv_sse_interrupted_context, &context);
> + sse_handle_event(arch_evt, regs);
> + this_cpu_write(riscv_sse_interrupted_context, previous);
> +
> + if (memcmp(®s->a6, arch_evt->interrupted,
> + sizeof(*arch_evt->interrupted))) {
> + memcpy(arch_evt->interrupted, ®s->a6,
> + sizeof(*arch_evt->interrupted));
[Severity: High]
Does copying sizeof(*arch_evt->interrupted) bytes across ®s->a6 trip
CONFIG_FORTIFY_SOURCE?
In struct pt_regs, a6 and a7 are individual unsigned long fields rather
than a 2-register struct_group, so __builtin_object_size(®s->a6, 1) is
sizeof(unsigned long) while sizeof(*arch_evt->interrupted) is
2 * sizeof(unsigned long). With CONFIG_FORTIFY_SOURCE=y, the first
memcpy() fails the build with __write_overflow_field() under
CONFIG_WERROR=y (and the second triggers __read_overflow2_field() under
W=1), or triggers a runtime fortify WARN_ONCE() inside NMI context when
an SSE event arrives. Copying and comparing a6 and a7 directly by field
avoids the field-spanning memcpy().
> diff --git a/arch/riscv/kernel/sbi_sse_entry.S b/arch/riscv/kernel/sbi_sse_entry.S
> new file mode 100644
> index 0000000000000..1e38fbb1c2a42
> --- /dev/null
> +++ b/arch/riscv/kernel/sbi_sse_entry.S
> @@ -0,0 +1,237 @@
[ ... ]
> + asm_per_cpu_with_cpu t2 __sbi_sse_entry_task t1 t3
> + REG_L tp, 0(t2)
> + bnez tp, .Lcurrent_task_found
> +
> + /* __switch_to() marks its transition window with a NULL entry task. */
> + REG_L tp, PT_TP(sp)
> +
> +.Lcurrent_task_found:
> + /* Nested exceptions temporarily replace these with the SSE stack. */
> + REG_L s6, TASK_TI_KERNEL_SP(tp)
[Severity: High]
Can a nested higher-priority SSE event see tp == NULL here when an SSE
interrupts __switch_to()?
__switch_to() zeroes __sbi_sse_entry_task while switching from prev to
next, relying on handle_sse() recovering current from the interrupted tp
register saved in PT_TP(sp). However, REG_L tp, 0(t2) loads NULL directly
into the live tp register before falling back to PT_TP(sp), and leaves
__sbi_sse_entry_task NULL while do_sse() runs:
__switch_to()
__sbi_sse_entry_task = NULL
<low-priority SSE>
handle_sse()
REG_S tp, PT_TP(sp)
REG_L tp, 0(t2) # tp becomes 0
<high-priority SSE>
handle_sse()
REG_S tp, PT_TP(sp) # saves 0
REG_L tp, 0(t2) # still 0
REG_L tp, PT_TP(sp) # reloads 0
REG_L s6, TASK_TI_KERNEL_SP(tp) <-- NULL pointer dereference
The same NULL tp window also occurs if do_sse() takes a nested synchronous
exception while __sbi_sse_entry_task is still NULL, because
handle_exception() swaps tp with CSR_SCRATCH (which handle_sse() cleared
to 0) for a few instructions before restoring tp.
Loading __sbi_sse_entry_task into a temporary register before overwriting
tp, or updating __sbi_sse_entry_task in lockstep with move tp, a1 in
__switch_to(), avoids exposing a NULL tp to nested SSE events.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119120824.13969-13-zhangzhanpeng.jasper@bytedance.com?part=2
next prev parent reply other threads:[~2026-11-19 12:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 12:08 [PATCH v13 00/11] riscv: add SBI Supervisor Software Events support Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:08 ` [PATCH v13 01/11] riscv: add SBI SSE extension definitions Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:14 ` sashiko-bot
2026-11-19 12:08 ` [PATCH v13 02/11] riscv: add support for SBI Supervisor Software Events extension Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:36 ` sashiko-bot [this message]
2026-11-19 12:08 ` [PATCH v13 03/11] riscv: sse: mask events during shutdown and kexec Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:38 ` sashiko-bot
2026-11-19 13:44 ` Clement Leger
2026-11-19 13:44 ` Clement Leger
2026-11-19 12:08 ` [PATCH v13 04/11] drivers: firmware: add riscv SSE support Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:38 ` sashiko-bot
2026-11-19 12:08 ` [PATCH v13 05/11] riscv: mm: avoid enabling interrupts for nofault page faults Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:27 ` sashiko-bot
2026-11-19 12:08 ` [PATCH v13 06/11] riscv: enable NMI-safe lockdep irqflags tracking Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:21 ` sashiko-bot
2026-11-19 13:46 ` Clement Leger
2026-11-19 13:46 ` Clement Leger
2026-11-19 12:08 ` [PATCH v13 07/11] perf: RISC-V: support callchains with SSE delivery Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:45 ` sashiko-bot
2026-11-19 12:08 ` [PATCH v13 08/11] perf: RISC-V: add support for SSE event Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:34 ` sashiko-bot
2026-11-19 12:08 ` [PATCH v13 09/11] MAINTAINERS: add RISC-V SSE maintainers and file coverage Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:08 ` [PATCH v13 10/11] selftests/riscv: add SSE test module Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:37 ` sashiko-bot
2026-11-19 12:08 ` [PATCH v13 11/11] selftests/riscv: add perf user-stack SSE copy regression test Zhanpeng Zhang
2026-11-19 12:08 ` Zhanpeng Zhang
2026-11-19 12:34 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223096@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zhangzhanpeng.jasper@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.