From: sashiko-bot@kernel.org
To: "Gautam Gala" <ggala@linux.ibm.com>, linux-s390@vger.kernel.org
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v1 1/2] KVM: s390: vsie: Do not overwrite guest 3 state on early validity icpt
Date: Thu, 19 Nov 2026 12:55:22 +0000 [thread overview]
Message-ID: <sashiko-outbox-223126@kernel.org> (raw)
In-Reply-To: <20261119124936.33396-2-ggala@linux.ibm.com>
> shadow_scb() calls prepare_cpuflags() first, which can reject the SCB
> provided by guest 2 with a validity interception. This happens before
> the guest state (gpsw, gg14, gg15, gcr, cputm, ckc, todpr, pp) and the
> control fields (gbea, fpf) are copied from the original SCB into the
> shadow SCB.
>
> The error path still calls unshadow_scb(), which copies that state from
> the shadow SCB back into the original one. The shadow SCB does not hold
> guest 3 state at this point:
>
> - For a new or recycled vsie page, get_vsie_page() has cleared the
> shadow SCB, so the guest 3 state in the guest 2 SCB is overwritten
> with zeroes.
> - For a cached vsie page that is looked up again by SCB address, the
> shadow SCB still holds the state from the end of the previous run,
> [ ... ]
> so that no stale interception data is passed on to guest 2.
>
> Fixes: a3508fbe9dc6 ("KVM: s390: vsie: initial support for nested virtualization")
> Reported-by: Christian Borntraeger <borntraeger@linux.ibm.com>
> Signed-off-by: Gautam Gala <ggala@linux.ibm.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119124936.33396-1-ggala@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-11-19 12:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 12:49 [PATCH v1 0/2] KVM: s390: vsie: Do not overwrite guest 3 state on early validity icpt Gautam Gala
2026-11-19 12:49 ` [PATCH v1 1/2] " Gautam Gala
2026-11-19 12:55 ` sashiko-bot [this message]
2026-11-19 12:49 ` [PATCH v1 2/2] KVM: s390: selftests: Add vsie validity interception tests Gautam Gala
2026-11-19 12:58 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223126@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=ggala@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.