All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yehyeong Lee" <yhlee@isslab.korea.ac.kr>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH v4 1/4] scsi: target: iscsi: retire an unsolicited NOP-In only once
Date: Thu, 19 Nov 2026 13:28:22 +0000	[thread overview]
Message-ID: <sashiko-outbox-223176@kernel.org> (raw)
In-Reply-To: <20261119131700.2722108-2-yhlee@isslab.korea.ac.kr>

> iscsit_process_nop_out() answers a NOP-Out carrying a TTT by looking the
> command up with iscsit_find_cmd_from_ttt(), which compares the tag and
> nothing else and leaves the command on conn_cmd_list, while
> iscsit_add_cmd_to_immediate_queue() allocates a fresh queue entry each
> time.  Two NOP-Outs with the same TTT queue the same command twice, and
> the tx thread's ISTATE_REMOVE handling releases it twice.  For the NOP-In
> itself that release is quiet - it is a slice of the session's tag pool,
> not a slab object - but it can land on whichever command has taken that
> tag in the meantime.
> 
> The same lookup also hands out a Reject, which the core allocates with
> targ_xfer_tag 0 and leaves on conn_cmd_list until it is sent, so a NOP-Out
> with a reserved ITT and TTT 0 is given the Reject instead of a NOP-In.
> That one does reach the slab, through the header the Reject kept in
> cmd->buf_ptr, and an initiator gets there one PDU after login on plain
> [ ... ]
> 
> Link: https://lore.kernel.org/all/1437516477-30554-4-git-send-email-sbaugh@catern.com/
> Fixes: e48354ce078c ("iscsi-target: Add iSCSI fabric support for target v4.1")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yehyeong Lee <yhlee@isslab.korea.ac.kr>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119131700.2722108-1-yhlee@isslab.korea.ac.kr?part=1


  reply	other threads:[~2026-11-19 13:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:16 [PATCH v4 0/4] isert: the commands the target core allocates itself Yehyeong Lee
2026-11-19 13:16 ` [PATCH v4 1/4] scsi: target: iscsi: retire an unsolicited NOP-In only once Yehyeong Lee
2026-11-19 13:28   ` sashiko-bot [this message]
2026-11-19 13:16 ` [PATCH v4 2/4] scsi: target: iscsi: do not arm the nopin timer on an iSER connection Yehyeong Lee
2026-11-19 13:26   ` sashiko-bot
2026-11-19 13:16 ` [PATCH v4 3/4] IB/isert: finish a Reject the target core allocated itself Yehyeong Lee
2026-11-19 13:26   ` sashiko-bot
2026-11-19 13:17 ` [PATCH v4 4/4] IB/isert: do not leak the receive descriptor of a dropped Data-Out Yehyeong Lee
2026-11-19 13:22   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223176@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yhlee@isslab.korea.ac.kr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.