All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Philipp Stanner" <phasta@kernel.org>
Cc: dri-devel@lists.freedesktop.org, media-ci@linuxtv.org
Subject: Re: [PATCH 3/3] drm/sched: Fix memory ordering with dma_fence_overwrite_timestamp()
Date: Thu, 19 Nov 2026 13:36:50 +0000	[thread overview]
Message-ID: <sashiko-outbox-223186@kernel.org> (raw)
In-Reply-To: <20261119131830.2535266-5-phasta@kernel.org>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/sched: missing kernel-doc for
  drm_sched_overwrite_scheduled_timestamp()
--

commit 4813d16b1085e58469356c4e77e1cbeb576347c5
Author: Philipp Stanner <phasta@kernel.org>

drm/sched: Fix memory ordering with dma_fence_overwrite_timestamp()

This commit replaces the manual timestamp flag check and assignment in
drm_sched_get_finished_job() with dma_fence_overwrite_timestamp() via a
new drm_sched_overwrite_scheduled_timestamp() helper.

> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 99252674e2668..a065a6d2eb1c3 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
[ ... ]
> @@ -898,6 +899,22 @@ drm_sched_select_entity(struct drm_gpu_scheduler *sched)
>  	return IS_ERR(entity) ? NULL : entity;
>  }
>  
> +/**
> + * drm_sched_overwrite_scheduled_timestamp - make timestamp more accurate
> + *
> + * Overwrites the timestamp of the provided scheduled fence with the one from
> + * the finished fence, if the scheduled fence is already signaled. Does nothing
> + * otherwise.
> + */
> +static void
> +drm_sched_overwrite_scheduled_timestamp(struct dma_fence *finished,
> +					struct dma_fence *scheduled)
> +{
> +	ktime_t timestamp = dma_fence_timestamp(finished);
> +
> +	dma_fence_overwrite_timestamp(scheduled, timestamp);
> +}

[Severity: Low]
This kernel-doc comment omits @finished and @scheduled descriptions,
which causes scripts/kernel-doc warnings when building with W=1 or
generating documentation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119131830.2535266-2-phasta@kernel.org?part=3

      reply	other threads:[~2026-11-19 13:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 13:18 [PATCH 0/3] dma-fence: Fix timestamp memory ordering Philipp Stanner
2026-11-19 13:18 ` [PATCH 1/3] dma-buf/dma-fence: Ensure correct ordering in dma_fence_timestamp() Philipp Stanner
2026-11-19 13:42   ` sashiko-bot
2026-11-20  9:33   ` Christian König
2026-11-20 13:23     ` Philipp Stanner
2026-11-19 13:18 ` [PATCH 2/3] dma-buf: dma-fence: Add dma_fence_overwrite_timestamp() Philipp Stanner
2026-11-20  9:38   ` Christian König
2026-11-20 10:01     ` Philipp Stanner
2026-11-19 13:18 ` [PATCH 3/3] drm/sched: Fix memory ordering with dma_fence_overwrite_timestamp() Philipp Stanner
2026-11-19 13:36   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223186@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=media-ci@linuxtv.org \
    --cc=phasta@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.