All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jani Nikula" <jani.nikula@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: drop unnecessary display/ includes
Date: Thu, 19 Nov 2026 15:24:59 +0000	[thread overview]
Message-ID: <sashiko-outbox-223379@kernel.org> (raw)
In-Reply-To: <20261119151644.4097956-1-jani.nikula@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/i915: build failure in intel_uncore_init_mmio() due to
  missing header
--

commit 7bc6738060c0255c4ddc88b8481bd154e455c1f4
Author: Jani Nikula <jani.nikula@intel.com>

drm/i915: drop unnecessary display/ includes

This commit removes display/intel_crtc.h from i915_initial_plane.c and
display/intel_display_core.h from intel_uncore.c.

> diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> index e360e4f9d9a2d..925c52f4494b0 100644
> --- a/drivers/gpu/drm/i915/intel_uncore.c
> +++ b/drivers/gpu/drm/i915/intel_uncore.c
> @@ -27,7 +27,6 @@
>  #include <drm/drm_managed.h>
>  #include <drm/drm_print.h>
>  
> -#include "display/intel_display_core.h"
>  #include "gt/intel_engine_regs.h"
>  #include "gt/intel_gt.h"
>  #include "gt/intel_gt_regs.h"

[Severity: High]
Does removing display/intel_display_core.h break the build in
intel_uncore_init_mmio()?

drivers/gpu/drm/i915/intel_uncore.c:intel_uncore_init_mmio() {
    ...
	if (HAS_FPGA_DBG_UNCLAIMED(display))
		uncore->flags |= UNCORE_HAS_FPGA_DBG_UNCLAIMED;
    ...
}

HAS_FPGA_DBG_UNCLAIMED() is defined in display/intel_display_device.h (which
was previously pulled in via display/intel_display_core.h) and dereferences
struct intel_display, which is defined in display/intel_display_core.h.
Without that header, compiling intel_uncore.c fails with an implicit
declaration error for HAS_FPGA_DBG_UNCLAIMED().

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119151644.4097956-1-jani.nikula@intel.com?part=1

  parent reply	other threads:[~2026-11-19 15:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 15:16 [PATCH 1/2] drm/i915: drop unnecessary display/ includes Jani Nikula
2026-11-19 15:16 ` [PATCH 2/2] drm/i915: move FBC_RT_BASE register macros to intel_gt_regs.h Jani Nikula
2026-11-19 15:38   ` Ville Syrjälä
2026-11-20 14:38     ` Jani Nikula
2026-11-19 15:24 ` sashiko-bot [this message]
2026-11-19 16:30 ` ✓ CI.KUnit: success for series starting with [1/2] drm/i915: drop unnecessary display/ includes Patchwork
2026-11-19 16:37 ` [PATCH 1/2] " Ville Syrjälä
2026-11-19 17:07 ` ✓ Xe.CI.BAT: success for series starting with [1/2] " Patchwork
2026-11-19 18:17 ` ✓ i915.CI.BAT: " Patchwork
2026-11-20 19:43 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-223379@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.