From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795102003; b=hkl7wa1sr35jxtFERO1ms2cRB+pTNSifaKtO8maiA7Vbg1+EY2vrlNIr3Ng/2LDNzeo/ BhewT4tFtV0YPozvTvWqwrUX3x/SWGkJMG0VXgfLs6jutt/IGhFukFJwWZU3W/mzxXEwt uyRDAez0xa60+x7UqTFRA7ysZYdAD3DGxYQ/FSdb8u4zDtROKWQY9tAXjmsr+PLGbPARr /jJUTz/gXcZcsbkraNnGMoy6YNzw351fRAhJ2Jvx8a3o6jHQhFfPpgj5FnRwowJbx7x8j 4BRDjWOnUtThxjW/FQ+qJPoeAGIFYOdT4RF0cKFm8X4qGdeC8nU4HmwyNJKZ80539Xw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795102003; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=w5xpY7nzvsPGQqyIoOdUke8GvoCz7BF4Gu6054u1XQc=; b=YFe5NkKC4QGEvbKI2xcWrUVy9vLXDHEs/9jTLMjCJXeRNxVtm74XRItPtsJkp2lgxDce 7bb/TDZQb90u3Isock8BujzRIbVD+fvTcqJYPbdx2f2zAoJJV9MQPPLH3nYrNYUynEVhA /VGd4cU59UXEpK6CwRyiNyU6yX8VVG9BW8ruc2JtUkTyoHmiwH1jf63WjuTd6vEfRm5/a PQ5Dfisx106TLN4HVy3ojR4DWfLlMV4zUPBI/yN6MerHg3VYeIWUOeQYI0HhszIwlsrOQ w2NccQuiiXx4m/VVuVXRpRvw9vWOe0VjPfSLvpYJj6pHwTKvmv7uCm1uqjdGEj3oTlw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YCAELgZL; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20794606A320; Thu, 19 Nov 2026 15:26:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YCAELgZL Received: by smtp.kernel.org (Postfix) with ESMTPSA id 301C91F000C4; Thu, 19 Nov 2026 15:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795102002; bh=w5xpY7nzvsPGQqyIoOdUke8GvoCz7BF4Gu6054u1XQc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YCAELgZLnyccb+gqD/QJgU2oBXlle/EsPEtwMYZxow1Mkv+RQ/0penhOKQCnQcJOZ RvjRW8uBgm3mO8mHp0buX9RKvHPAbtncJYRcZxHFYDBHjnjvoGjFzSYRvxyczLPCJJ yMW79LUytWT/LzP05FRDSmJew0bOpqm9y4lDeZf75qg92eX5GGGe5lNNJ3DNosV72m Qnbrq8fV1s3ca1pDcu3D2I5OXd/JWxvNuYWPdVNiAv1UB47A6Y2P9QHGw3XrNsyVtT J1+DHlsef9P9qcIY2UNBCpnD7Z3i2q2xI1uEp9CJ/DXeArw5Ywwo9/i3eWL3rmqhoA HwopVspC2Fe3Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v15 14/23] scsi: ufs: mediatek: Use the common PHY framework Reply-To: sashiko-reviews@lists.linux.dev To: "Louis-Alexis Eyraud" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-scsi@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261119-mt8196-ufs-v15-14-aae1eb0382e8@collabora.com> References: <20261119-mt8196-ufs-v15-0-aae1eb0382e8@collabora.com> <20261119-mt8196-ufs-v15-14-aae1eb0382e8@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 19 Nov 2026 15:26:41 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 3 potential issues to consider: - [High] scsi: ufs: mediatek: premature phy_exit() and power leak in ufs_mtk_exit() - [High] scsi: ufs: mediatek: missing error rollback in ufs_mtk_runtime_suspend() - [Medium] scsi: ufs: mediatek: PHY power leak and error in ufs_mtk_runtime_resume() -- commit dd9f3229e4978dc4fda07cd42dec5399df0226ee Author: Nicolas Frattaroli scsi: ufs: mediatek: Use the common PHY framework This commit switches the MediaTek UFS driver from manual OF PHY device handling in probe and runtime PM to acquiring and managing the PHY via the common PHY framework in the ufshcd variant callbacks. > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-media= tek.c > index fec0fb24e7a2c..a78e015e329a5 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c [ ... ] > @@ -1321,11 +1291,22 @@ static int ufs_mtk_init(struct ufs_hba *hba) > =20 > return 0; > =20 > +out_phy_exit: > + phy_exit(host->mphy); > out_variant_clear: > ufshcd_set_variant(hba, NULL); > return err; > } > =20 > +static void ufs_mtk_exit(struct ufs_hba *hba) > +{ > + struct ufs_mtk_host *host =3D ufshcd_get_variant(hba); > + > + ufs_mtk_mphy_power_on(hba, false); > + > + phy_exit(host->mphy); > +} [Severity: High] Does ufs_mtk_exit() call phy_exit(host->mphy) while a second phy_power_on() reference is still held? ufs_mtk_init() acquires two phy_power_on() references on host->mphy: one in ufs_mtk_mphy_power_on(hba, true) and another in ufs_mtk_setup_clocks(hba, true, POST_CHANGE) via ufs_mtk_pwr_ctrl(hba, true). During teardown, ufshcd_hba_exit() invokes ufshcd_vops_exit(hba) before ufshcd_setup_clocks(hba, false): drivers/ufs/core/ufshcd.c:ufshcd_hba_exit() { ... ufshcd_exit_clk_gating(hba); if (hba->eh_wq) destroy_workqueue(hba->eh_wq); ufs_debugfs_hba_exit(hba); ufshcd_vops_exit(hba); ufshcd_setup_vreg(hba, false); ufshcd_setup_clocks(hba, false); ... } In ufs_mtk_exit(), ufs_mtk_mphy_power_on(hba, false) drops only one phy_power_on() reference (leaving mphy->power_count at 1) and turns off the 0.9V supply before phy_exit(host->mphy) runs. On driver removal, ufshcd_remove() leaves hba->uic_link_state as UIC_LINK_ACTIVE_STATE, so the subsequent ufshcd_setup_clocks(hba, false) skips ufs_mtk_pwr_ctrl(hba, false) and permanently leaks the remaining phy_power_on() reference, PHY clocks, and runtime PM reference. On an early ufshcd_init() failure while the link is still off, ufshcd_setup_clocks(hba, false) instead calls phy_power_off(host->mphy) and accesses M-PHY registers after phy_exit() has run and the 0.9V supply has been disabled. [ ... ] > @@ -2522,9 +2467,8 @@ static int ufs_mtk_system_resume(struct device *dev) > static int ufs_mtk_runtime_suspend(struct device *dev) > { > struct ufs_hba *hba =3D dev_get_drvdata(dev); > - struct ufs_mtk_host *host =3D ufshcd_get_variant(hba); > struct arm_smccc_res res; > - int ret =3D 0; > + int ret; > =20 > ret =3D ufshcd_runtime_suspend(dev); > if (ret) > @@ -2535,8 +2479,13 @@ static int ufs_mtk_runtime_suspend(struct device *= dev) > if (ufs_mtk_is_rtff_mtcmos(hba)) > ufs_mtk_mtcmos_ctrl(false, res); > =20 > - if (host->phy_dev) > - pm_runtime_put_sync(host->phy_dev); > + if (!ufshcd_is_link_active(hba)) { > + ret =3D ufs_mtk_mphy_power_on(hba, false); > + if (ret) { > + dev_err(dev, "Failed to power off PHY: %pe\n", ERR_PTR(ret)); > + return ret; > + } > + } > =20 > return 0; > } [Severity: High] If ufs_mtk_mphy_power_on(hba, false) fails here, does returning an error without rolling back leave the controller powered down while runtime PM considers dev active? At this point ufshcd_runtime_suspend(dev), ufs_mtk_dev_vreg_set_lpm(hba, true), and ufs_mtk_mtcmos_ctrl(false, res) have already gated clocks, disabled interrupts, placed device regulators into LPM, and turned off MTCMOS. When a runtime_suspend callback returns an error, rpm_suspend() aborts the suspend and leaves the device in RPM_ACTIVE, so subsequent I/O or register accesses will touch unpowered hardware without running ufs_mtk_runtime_resume(). Also, powering off the PHY after ufs_mtk_mtcmos_ctrl(false, res) runs in the same order as ufs_mtk_runtime_resume() rather than the reverse order. > @@ -2544,14 +2493,17 @@ static int ufs_mtk_runtime_suspend(struct device = *dev) > static int ufs_mtk_runtime_resume(struct device *dev) > { > struct ufs_hba *hba =3D dev_get_drvdata(dev); > - struct ufs_mtk_host *host =3D ufshcd_get_variant(hba); > struct arm_smccc_res res; > + int ret; > =20 > if (ufs_mtk_is_rtff_mtcmos(hba)) > ufs_mtk_mtcmos_ctrl(true, res); > =20 > - if (host->phy_dev) > - pm_runtime_get_sync(host->phy_dev); > + ret =3D ufs_mtk_mphy_power_on(hba, true); > + if (ret) { > + dev_err(dev, "Failed to power on PHY: %pe\n", ERR_PTR(ret)); > + return ret; > + } > =20 > ufs_mtk_dev_vreg_set_lpm(hba, false); > =20 [Severity: Medium] Can powering on the M-PHY in ufs_mtk_runtime_resume() leave the PHY and 0.9V supply enabled across system suspend? If hba->dev runtime-resumes while the ufs_device_wlun child remains runtime-suspended, ufs_mtk_runtime_resume() sets host->mphy_powered_on and enables the PHY. If system suspend then runs before hba->dev autosuspends (when ufshcd_rpm_ok_for_spm() is true), ufshcd_wl_suspend() skips ufs_mtk_suspend(), and ufs_mtk_system_suspend() does not call ufs_mtk_mphy_power_on(hba, false): drivers/ufs/host/ufs-mediatek.c:ufs_mtk_system_suspend() { ... ret =3D ufshcd_system_suspend(dev); if (ret) goto out; if (pm_runtime_suspended(hba->dev)) goto out; ufs_mtk_dev_vreg_set_lpm(hba, true); if (ufs_mtk_is_rtff_mtcmos(hba)) ufs_mtk_mtcmos_ctrl(false, res); ... } This leaves the M-PHY and 0.9V regulator powered on during system sleep while MTCMOS and clocks are off. In addition, if ufs_mtk_mphy_power_on(hba, true) or ufshcd_runtime_resume(dev) fails in ufs_mtk_runtime_resume(), the preceding MTCMOS, PHY, and regulator state changes are not unwound while dev remains RPM_SUSPENDED. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261119-mt8196-ufs= -v15-0-aae1eb0382e8@collabora.com?part=3D14 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB495606A325 for ; Thu, 19 Nov 2026 15:26:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=zSSA2R5w; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=YCAELgZL DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=z7bLEcRh8P9BL6RepDLYBO0qx8i/kSTncwKCR1958nk=; b=zSSA2R5w3gmeVEYkXrj9tqh5FN TqUGvIz5GHG9pmiMYTsNiH8QoxamF+oilgWG8gKO/z8L+5S/cndOSbJawYSwOSNqDl/Q5OLjTOfnn 02q69e4QTuduUB1h3CV9M3h+8xMA2biIrExfUmmkHprrETFEjn8soYbW4Yvtk2iHetcU3HYaEWFav verAD/kYF0XjhuRL1Wz9SeV600SqdNr3ODlGk85uySFeUQzgNEW6RyeYEorfNxZC+jqLrpw3HjJj9 WSaBXD3IkFXsvp2v4M6OofwTDUHB0qq4ruhqJ2iDa16Uejtm5A+x5gXEo8L2L8jPC+BGnM5Bfjnjc SbowW7WQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU427-0000000CRgI-1pmX; Thu, 19 Nov 2026 15:26:43 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xU426-0000000CRgA-47xj for linux-phy@lists.infradead.org; Thu, 19 Nov 2026 15:26:43 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id B9C4C41340; Thu, 19 Nov 2026 15:26:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 301C91F000C4; Thu, 19 Nov 2026 15:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795102002; bh=w5xpY7nzvsPGQqyIoOdUke8GvoCz7BF4Gu6054u1XQc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=YCAELgZLnyccb+gqD/QJgU2oBXlle/EsPEtwMYZxow1Mkv+RQ/0penhOKQCnQcJOZ RvjRW8uBgm3mO8mHp0buX9RKvHPAbtncJYRcZxHFYDBHjnjvoGjFzSYRvxyczLPCJJ yMW79LUytWT/LzP05FRDSmJew0bOpqm9y4lDeZf75qg92eX5GGGe5lNNJ3DNosV72m Qnbrq8fV1s3ca1pDcu3D2I5OXd/JWxvNuYWPdVNiAv1UB47A6Y2P9QHGw3XrNsyVtT J1+DHlsef9P9qcIY2UNBCpnD7Z3i2q2xI1uEp9CJ/DXeArw5Ywwo9/i3eWL3rmqhoA HwopVspC2Fe3Q== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v15 14/23] scsi: ufs: mediatek: Use the common PHY framework To: "Louis-Alexis Eyraud" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-scsi@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261119-mt8196-ufs-v15-14-aae1eb0382e8@collabora.com> References: <20261119-mt8196-ufs-v15-0-aae1eb0382e8@collabora.com> <20261119-mt8196-ufs-v15-14-aae1eb0382e8@collabora.com> Date: Thu, 19 Nov 2026 15:26:41 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtIaWdoXSBzY3NpOiB1ZnM6IG1lZGlh dGVrOiBwcmVtYXR1cmUgcGh5X2V4aXQoKSBhbmQgcG93ZXIgbGVhayBpbgogIHVmc19tdGtfZXhp dCgpCi0gW0hpZ2hdIHNjc2k6IHVmczogbWVkaWF0ZWs6IG1pc3NpbmcgZXJyb3Igcm9sbGJhY2sg aW4KICB1ZnNfbXRrX3J1bnRpbWVfc3VzcGVuZCgpCi0gW01lZGl1bV0gc2NzaTogdWZzOiBtZWRp YXRlazogUEhZIHBvd2VyIGxlYWsgYW5kIGVycm9yIGluCiAgdWZzX210a19ydW50aW1lX3Jlc3Vt ZSgpCi0tCgpjb21taXQgZGQ5ZjMyMjllNDk3OGRjNGZkYTA3Y2Q0MmRlYzUzOTlkZjAyMjZlZQpB dXRob3I6IE5pY29sYXMgRnJhdHRhcm9saSA8bmljb2xhcy5mcmF0dGFyb2xpQGNvbGxhYm9yYS5j b20+CgpzY3NpOiB1ZnM6IG1lZGlhdGVrOiBVc2UgdGhlIGNvbW1vbiBQSFkgZnJhbWV3b3JrCgpU aGlzIGNvbW1pdCBzd2l0Y2hlcyB0aGUgTWVkaWFUZWsgVUZTIGRyaXZlciBmcm9tIG1hbnVhbCBP RiBQSFkgZGV2aWNlCmhhbmRsaW5nIGluIHByb2JlIGFuZCBydW50aW1lIFBNIHRvIGFjcXVpcmlu ZyBhbmQgbWFuYWdpbmcgdGhlIFBIWSB2aWEKdGhlIGNvbW1vbiBQSFkgZnJhbWV3b3JrIGluIHRo ZSB1ZnNoY2QgdmFyaWFudCBjYWxsYmFja3MuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3Vmcy9o b3N0L3Vmcy1tZWRpYXRlay5jIGIvZHJpdmVycy91ZnMvaG9zdC91ZnMtbWVkaWF0ZWsuYwo+IGlu ZGV4IGZlYzBmYjI0ZTdhMmMuLmE3OGUwMTVlMzI5YTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91 ZnMvaG9zdC91ZnMtbWVkaWF0ZWsuYwo+ICsrKyBiL2RyaXZlcnMvdWZzL2hvc3QvdWZzLW1lZGlh dGVrLmMKClsgLi4uIF0KCj4gQEAgLTEzMjEsMTEgKzEyOTEsMjIgQEAgc3RhdGljIGludCB1ZnNf bXRrX2luaXQoc3RydWN0IHVmc19oYmEgKmhiYSkKPiAgCj4gIAlyZXR1cm4gMDsKPiAgCj4gK291 dF9waHlfZXhpdDoKPiArCXBoeV9leGl0KGhvc3QtPm1waHkpOwo+ICBvdXRfdmFyaWFudF9jbGVh cjoKPiAgCXVmc2hjZF9zZXRfdmFyaWFudChoYmEsIE5VTEwpOwo+ICAJcmV0dXJuIGVycjsKPiAg fQo+ICAKPiArc3RhdGljIHZvaWQgdWZzX210a19leGl0KHN0cnVjdCB1ZnNfaGJhICpoYmEpCj4g K3sKPiArCXN0cnVjdCB1ZnNfbXRrX2hvc3QgKmhvc3QgPSB1ZnNoY2RfZ2V0X3ZhcmlhbnQoaGJh KTsKPiArCj4gKwl1ZnNfbXRrX21waHlfcG93ZXJfb24oaGJhLCBmYWxzZSk7Cj4gKwo+ICsJcGh5 X2V4aXQoaG9zdC0+bXBoeSk7Cj4gK30KCltTZXZlcml0eTogSGlnaF0KRG9lcyB1ZnNfbXRrX2V4 aXQoKSBjYWxsIHBoeV9leGl0KGhvc3QtPm1waHkpIHdoaWxlIGEgc2Vjb25kCnBoeV9wb3dlcl9v bigpIHJlZmVyZW5jZSBpcyBzdGlsbCBoZWxkPwoKdWZzX210a19pbml0KCkgYWNxdWlyZXMgdHdv IHBoeV9wb3dlcl9vbigpIHJlZmVyZW5jZXMgb24gaG9zdC0+bXBoeTogb25lCmluIHVmc19tdGtf bXBoeV9wb3dlcl9vbihoYmEsIHRydWUpIGFuZCBhbm90aGVyIGluCnVmc19tdGtfc2V0dXBfY2xv Y2tzKGhiYSwgdHJ1ZSwgUE9TVF9DSEFOR0UpIHZpYQp1ZnNfbXRrX3B3cl9jdHJsKGhiYSwgdHJ1 ZSkuICBEdXJpbmcgdGVhcmRvd24sIHVmc2hjZF9oYmFfZXhpdCgpIGludm9rZXMKdWZzaGNkX3Zv cHNfZXhpdChoYmEpIGJlZm9yZSB1ZnNoY2Rfc2V0dXBfY2xvY2tzKGhiYSwgZmFsc2UpOgoKZHJp dmVycy91ZnMvY29yZS91ZnNoY2QuYzp1ZnNoY2RfaGJhX2V4aXQoKSB7CgkuLi4KCQl1ZnNoY2Rf ZXhpdF9jbGtfZ2F0aW5nKGhiYSk7CgkJaWYgKGhiYS0+ZWhfd3EpCgkJCWRlc3Ryb3lfd29ya3F1 ZXVlKGhiYS0+ZWhfd3EpOwoJCXVmc19kZWJ1Z2ZzX2hiYV9leGl0KGhiYSk7CgkJdWZzaGNkX3Zv cHNfZXhpdChoYmEpOwoJCXVmc2hjZF9zZXR1cF92cmVnKGhiYSwgZmFsc2UpOwoJCXVmc2hjZF9z ZXR1cF9jbG9ja3MoaGJhLCBmYWxzZSk7CgkuLi4KfQoKSW4gdWZzX210a19leGl0KCksIHVmc19t dGtfbXBoeV9wb3dlcl9vbihoYmEsIGZhbHNlKSBkcm9wcyBvbmx5IG9uZQpwaHlfcG93ZXJfb24o KSByZWZlcmVuY2UgKGxlYXZpbmcgbXBoeS0+cG93ZXJfY291bnQgYXQgMSkgYW5kIHR1cm5zIG9m Zgp0aGUgMC45ViBzdXBwbHkgYmVmb3JlIHBoeV9leGl0KGhvc3QtPm1waHkpIHJ1bnMuCgpPbiBk cml2ZXIgcmVtb3ZhbCwgdWZzaGNkX3JlbW92ZSgpIGxlYXZlcyBoYmEtPnVpY19saW5rX3N0YXRl IGFzClVJQ19MSU5LX0FDVElWRV9TVEFURSwgc28gdGhlIHN1YnNlcXVlbnQgdWZzaGNkX3NldHVw X2Nsb2NrcyhoYmEsIGZhbHNlKQpza2lwcyB1ZnNfbXRrX3B3cl9jdHJsKGhiYSwgZmFsc2UpIGFu ZCBwZXJtYW5lbnRseSBsZWFrcyB0aGUgcmVtYWluaW5nCnBoeV9wb3dlcl9vbigpIHJlZmVyZW5j ZSwgUEhZIGNsb2NrcywgYW5kIHJ1bnRpbWUgUE0gcmVmZXJlbmNlLiAgT24gYW4KZWFybHkgdWZz aGNkX2luaXQoKSBmYWlsdXJlIHdoaWxlIHRoZSBsaW5rIGlzIHN0aWxsIG9mZiwKdWZzaGNkX3Nl dHVwX2Nsb2NrcyhoYmEsIGZhbHNlKSBpbnN0ZWFkIGNhbGxzIHBoeV9wb3dlcl9vZmYoaG9zdC0+ bXBoeSkKYW5kIGFjY2Vzc2VzIE0tUEhZIHJlZ2lzdGVycyBhZnRlciBwaHlfZXhpdCgpIGhhcyBy dW4gYW5kIHRoZSAwLjlWIHN1cHBseQpoYXMgYmVlbiBkaXNhYmxlZC4KClsgLi4uIF0KCj4gQEAg LTI1MjIsOSArMjQ2Nyw4IEBAIHN0YXRpYyBpbnQgdWZzX210a19zeXN0ZW1fcmVzdW1lKHN0cnVj dCBkZXZpY2UgKmRldikKPiAgc3RhdGljIGludCB1ZnNfbXRrX3J1bnRpbWVfc3VzcGVuZChzdHJ1 Y3QgZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCB1ZnNfaGJhICpoYmEgPSBkZXZfZ2V0X2Ry dmRhdGEoZGV2KTsKPiAtCXN0cnVjdCB1ZnNfbXRrX2hvc3QgKmhvc3QgPSB1ZnNoY2RfZ2V0X3Zh cmlhbnQoaGJhKTsKPiAgCXN0cnVjdCBhcm1fc21jY2NfcmVzIHJlczsKPiAtCWludCByZXQgPSAw Owo+ICsJaW50IHJldDsKPiAgCj4gIAlyZXQgPSB1ZnNoY2RfcnVudGltZV9zdXNwZW5kKGRldik7 Cj4gIAlpZiAocmV0KQo+IEBAIC0yNTM1LDggKzI0NzksMTMgQEAgc3RhdGljIGludCB1ZnNfbXRr X3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpkZXYpCj4gIAlpZiAodWZzX210a19pc19y dGZmX210Y21vcyhoYmEpKQo+ICAJCXVmc19tdGtfbXRjbW9zX2N0cmwoZmFsc2UsIHJlcyk7Cj4g IAo+IC0JaWYgKGhvc3QtPnBoeV9kZXYpCj4gLQkJcG1fcnVudGltZV9wdXRfc3luYyhob3N0LT5w aHlfZGV2KTsKPiArCWlmICghdWZzaGNkX2lzX2xpbmtfYWN0aXZlKGhiYSkpIHsKPiArCQlyZXQg PSB1ZnNfbXRrX21waHlfcG93ZXJfb24oaGJhLCBmYWxzZSk7Cj4gKwkJaWYgKHJldCkgewo+ICsJ CQlkZXZfZXJyKGRldiwgIkZhaWxlZCB0byBwb3dlciBvZmYgUEhZOiAlcGVcbiIsIEVSUl9QVFIo cmV0KSk7Cj4gKwkJCXJldHVybiByZXQ7Cj4gKwkJfQo+ICsJfQo+ICAKPiAgCXJldHVybiAwOwo+ ICB9CgpbU2V2ZXJpdHk6IEhpZ2hdCklmIHVmc19tdGtfbXBoeV9wb3dlcl9vbihoYmEsIGZhbHNl KSBmYWlscyBoZXJlLCBkb2VzIHJldHVybmluZyBhbiBlcnJvcgp3aXRob3V0IHJvbGxpbmcgYmFj ayBsZWF2ZSB0aGUgY29udHJvbGxlciBwb3dlcmVkIGRvd24gd2hpbGUgcnVudGltZSBQTQpjb25z aWRlcnMgZGV2IGFjdGl2ZT8KCkF0IHRoaXMgcG9pbnQgdWZzaGNkX3J1bnRpbWVfc3VzcGVuZChk ZXYpLCB1ZnNfbXRrX2Rldl92cmVnX3NldF9scG0oaGJhLAp0cnVlKSwgYW5kIHVmc19tdGtfbXRj bW9zX2N0cmwoZmFsc2UsIHJlcykgaGF2ZSBhbHJlYWR5IGdhdGVkIGNsb2NrcywKZGlzYWJsZWQg aW50ZXJydXB0cywgcGxhY2VkIGRldmljZSByZWd1bGF0b3JzIGludG8gTFBNLCBhbmQgdHVybmVk IG9mZgpNVENNT1MuICBXaGVuIGEgcnVudGltZV9zdXNwZW5kIGNhbGxiYWNrIHJldHVybnMgYW4g ZXJyb3IsIHJwbV9zdXNwZW5kKCkKYWJvcnRzIHRoZSBzdXNwZW5kIGFuZCBsZWF2ZXMgdGhlIGRl dmljZSBpbiBSUE1fQUNUSVZFLCBzbyBzdWJzZXF1ZW50IEkvTwpvciByZWdpc3RlciBhY2Nlc3Nl cyB3aWxsIHRvdWNoIHVucG93ZXJlZCBoYXJkd2FyZSB3aXRob3V0IHJ1bm5pbmcKdWZzX210a19y dW50aW1lX3Jlc3VtZSgpLiAgQWxzbywgcG93ZXJpbmcgb2ZmIHRoZSBQSFkgYWZ0ZXIKdWZzX210 a19tdGNtb3NfY3RybChmYWxzZSwgcmVzKSBydW5zIGluIHRoZSBzYW1lIG9yZGVyIGFzCnVmc19t dGtfcnVudGltZV9yZXN1bWUoKSByYXRoZXIgdGhhbiB0aGUgcmV2ZXJzZSBvcmRlci4KCj4gQEAg LTI1NDQsMTQgKzI0OTMsMTcgQEAgc3RhdGljIGludCB1ZnNfbXRrX3J1bnRpbWVfc3VzcGVuZChz dHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHN0YXRpYyBpbnQgdWZzX210a19ydW50aW1lX3Jlc3VtZShz dHJ1Y3QgZGV2aWNlICpkZXYpCj4gIHsKPiAgCXN0cnVjdCB1ZnNfaGJhICpoYmEgPSBkZXZfZ2V0 X2RydmRhdGEoZGV2KTsKPiAtCXN0cnVjdCB1ZnNfbXRrX2hvc3QgKmhvc3QgPSB1ZnNoY2RfZ2V0 X3ZhcmlhbnQoaGJhKTsKPiAgCXN0cnVjdCBhcm1fc21jY2NfcmVzIHJlczsKPiArCWludCByZXQ7 Cj4gIAo+ICAJaWYgKHVmc19tdGtfaXNfcnRmZl9tdGNtb3MoaGJhKSkKPiAgCQl1ZnNfbXRrX210 Y21vc19jdHJsKHRydWUsIHJlcyk7Cj4gIAo+IC0JaWYgKGhvc3QtPnBoeV9kZXYpCj4gLQkJcG1f cnVudGltZV9nZXRfc3luYyhob3N0LT5waHlfZGV2KTsKPiArCXJldCA9IHVmc19tdGtfbXBoeV9w b3dlcl9vbihoYmEsIHRydWUpOwo+ICsJaWYgKHJldCkgewo+ICsJCWRldl9lcnIoZGV2LCAiRmFp bGVkIHRvIHBvd2VyIG9uIFBIWTogJXBlXG4iLCBFUlJfUFRSKHJldCkpOwo+ICsJCXJldHVybiBy ZXQ7Cj4gKwl9Cj4gIAo+ICAJdWZzX210a19kZXZfdnJlZ19zZXRfbHBtKGhiYSwgZmFsc2UpOwo+ ICAKCltTZXZlcml0eTogTWVkaXVtXQpDYW4gcG93ZXJpbmcgb24gdGhlIE0tUEhZIGluIHVmc19t dGtfcnVudGltZV9yZXN1bWUoKSBsZWF2ZSB0aGUgUEhZIGFuZAowLjlWIHN1cHBseSBlbmFibGVk IGFjcm9zcyBzeXN0ZW0gc3VzcGVuZD8KCklmIGhiYS0+ZGV2IHJ1bnRpbWUtcmVzdW1lcyB3aGls ZSB0aGUgdWZzX2RldmljZV93bHVuIGNoaWxkIHJlbWFpbnMKcnVudGltZS1zdXNwZW5kZWQsIHVm c19tdGtfcnVudGltZV9yZXN1bWUoKSBzZXRzIGhvc3QtPm1waHlfcG93ZXJlZF9vbgphbmQgZW5h YmxlcyB0aGUgUEhZLiAgSWYgc3lzdGVtIHN1c3BlbmQgdGhlbiBydW5zIGJlZm9yZSBoYmEtPmRl dgphdXRvc3VzcGVuZHMgKHdoZW4gdWZzaGNkX3JwbV9va19mb3Jfc3BtKCkgaXMgdHJ1ZSksIHVm c2hjZF93bF9zdXNwZW5kKCkKc2tpcHMgdWZzX210a19zdXNwZW5kKCksIGFuZCB1ZnNfbXRrX3N5 c3RlbV9zdXNwZW5kKCkgZG9lcyBub3QgY2FsbAp1ZnNfbXRrX21waHlfcG93ZXJfb24oaGJhLCBm YWxzZSk6Cgpkcml2ZXJzL3Vmcy9ob3N0L3Vmcy1tZWRpYXRlay5jOnVmc19tdGtfc3lzdGVtX3N1 c3BlbmQoKSB7CgkuLi4KCXJldCA9IHVmc2hjZF9zeXN0ZW1fc3VzcGVuZChkZXYpOwoJaWYgKHJl dCkKCQlnb3RvIG91dDsKCglpZiAocG1fcnVudGltZV9zdXNwZW5kZWQoaGJhLT5kZXYpKQoJCWdv dG8gb3V0OwoKCXVmc19tdGtfZGV2X3ZyZWdfc2V0X2xwbShoYmEsIHRydWUpOwoKCWlmICh1ZnNf bXRrX2lzX3J0ZmZfbXRjbW9zKGhiYSkpCgkJdWZzX210a19tdGNtb3NfY3RybChmYWxzZSwgcmVz KTsKCS4uLgp9CgpUaGlzIGxlYXZlcyB0aGUgTS1QSFkgYW5kIDAuOVYgcmVndWxhdG9yIHBvd2Vy ZWQgb24gZHVyaW5nIHN5c3RlbSBzbGVlcAp3aGlsZSBNVENNT1MgYW5kIGNsb2NrcyBhcmUgb2Zm LiAgSW4gYWRkaXRpb24sIGlmCnVmc19tdGtfbXBoeV9wb3dlcl9vbihoYmEsIHRydWUpIG9yIHVm c2hjZF9ydW50aW1lX3Jlc3VtZShkZXYpIGZhaWxzIGluCnVmc19tdGtfcnVudGltZV9yZXN1bWUo KSwgdGhlIHByZWNlZGluZyBNVENNT1MsIFBIWSwgYW5kIHJlZ3VsYXRvciBzdGF0ZQpjaGFuZ2Vz IGFyZSBub3QgdW53b3VuZCB3aGlsZSBkZXYgcmVtYWlucyBSUE1fU1VTUEVOREVELgoKLS0gClNh c2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MTEx OS1tdDgxOTYtdWZzLXYxNS0wLWFhZTFlYjAzODJlOEBjb2xsYWJvcmEuY29tP3BhcnQ9MTQKCi0t IApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=