From: sashiko-bot@kernel.org
To: "Karunika Choo" <karunika.choo@arm.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 2/9] drm/panthor: Rename neural accelerator feature macro to NX
Date: Thu, 19 Nov 2026 15:50:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-223427@kernel.org> (raw)
In-Reply-To: <20261119154604.2519184-3-karunika.choo@arm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/panthor: commit message does not explain why GPU_FEATURES_NX
is renamed
--
commit 5e9eb3b7663e54adfe7c44a448b5ceec6839bd33
Author: Karunika Choo <karunika.choo@arm.com>
> drm/panthor: Rename neural accelerator feature macro to NX
>
> Rename GPU_FEATURES_NEURAL_ENGINE to GPU_FEATURES_NX.
> Update the panthor_hw helper to use the new name.
>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
> Signed-off-by: Karunika Choo <karunika.choo@arm.com>
[Severity: Low]
This isn't a bug, but the commit message only restates the rename without
explaining why GPU_FEATURES_NEURAL_ENGINE is being renamed to
GPU_FEATURES_NX while panthor_hw_has_neural() keeps the neural naming.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119154604.2519184-1-karunika.choo@arm.com?part=2
next prev parent reply other threads:[~2026-11-19 15:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 15:45 [PATCH v4 0/9] drm/panthor: Add initial Mali v15 support Karunika Choo
2026-11-19 15:45 ` [PATCH v4 1/9] drm/panthor: Ignore -EOPNOTSUPP for shader-present nvmem lookup Karunika Choo
2026-11-19 15:45 ` [PATCH v4 2/9] drm/panthor: Rename neural accelerator feature macro to NX Karunika Choo
2026-11-19 15:50 ` sashiko-bot [this message]
2026-11-19 15:45 ` [PATCH v4 3/9] drm/panthor: Move register access helpers out of panthor_device.h Karunika Choo
2026-11-19 15:45 ` [PATCH v4 4/9] drm/panthor: Parse and store GPU_ID fields Karunika Choo
2026-11-19 15:45 ` [PATCH v4 5/9] drm/panthor: Move register base offsets to the HW description Karunika Choo
2026-11-19 15:45 ` [PATCH v4 6/9] drm/panthor: Derive MMU AS register addresses from base and stride Karunika Choo
2026-11-19 15:45 ` [PATCH v4 7/9] drm/panthor: Skip devfreq when explicitly disabled Karunika Choo
2026-11-19 16:01 ` Boris Brezillon
2026-11-19 15:45 ` [PATCH v4 8/9] dt-bindings: gpu: mali-gen5-am: Add Mali 5th-Gen AM schema Karunika Choo
2026-11-19 15:45 ` [PATCH v4 9/9] drm/panthor: Add Mali v15 hardware support Karunika Choo
2026-11-19 16:06 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223427@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=karunika.choo@arm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.