From: sashiko-bot@kernel.org
To: "Patrick Delaunay" <patrick.delaunay@foss.st.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v2] arm64: dts: st: add PSCI idle state to STM32MP23 CPU domains
Date: Thu, 19 Nov 2026 17:51:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-223728@kernel.org> (raw)
In-Reply-To: <20261119184209.v2.1.If2b6b99285c1e60ca11b6e7fccf7d9b130ca20dd@changeid>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: st: stm32mp231 cpu-sleep local-timer-stop conflicts
with always-on
--
commit 7e079de649dbd4d8c4228cc0cad8b0197a5e36f1
Author: Patrick Delaunay <patrick.delaunay@foss.st.com>
arm64: dts: st: add PSCI idle state to STM32MP23 CPU domains
This commit adds a PSCI cpu-sleep idle state and references it from the
STM32MP23 CPU power domains so the power-domain governor can manage them in
OSI mode.
Link: https://lore.kernel.org/all/20261030102907.1.I0ef2a7ac525ef18fa683368382d93e98cc36ee25@changeid/
> diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> index fefbf6f4f1537..27231e140fbb5 100644
> --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> @@ -24,6 +24,19 @@ cpu0: cpu@0 {
> power-domains = <&cpu0_pd>;
> power-domain-names = "psci";
> };
> +
> + idle-states {
> + entry-method = "psci";
> +
> + cpu_sleep: cpu-sleep {
> + compatible = "arm,idle-state";
> + arm,psci-suspend-param = <0x00000002>;
> + local-timer-stop;
> + entry-latency-us = <150>;
> + exit-latency-us = <200>;
> + min-residency-us = <1000>;
> + };
> + };
> };
[Severity: High]
Does setting local-timer-stop on cpu_sleep while the arm,armv8-timer node in
stm32mp231.dtsi still has always-on cause the CPU to enter PSCI suspend with
its local timer stopped and no broadcast wakeup timer armed?
arch/arm64/boot/dts/st/stm32mp231.dtsi {
...
timer {
compatible = "arm,armv8-timer";
interrupt-parent = <&intc>;
interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>,
<GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>;
always-on;
};
...
}
Because always-on is present on the timer node, arch_timer_of_init() sets
arch_timer_c3stop to false and __arch_timer_setup() omits
CLOCK_EVT_FEAT_C3STOP on the local clockevent device. When
cpuidle_enter_state() enters cpu_sleep, tick_broadcast_enter() ->
tick_broadcast_oneshot_control() sees CLOCK_EVT_FEAT_C3STOP clear and
returns 0 immediately without arming a broadcast timer or returning -EBUSY
to fall back to WFI, leaving the CPU asleep until an external non-timer
interrupt arrives.
The commit message adds a Link: to the separate patch "arm64: dts: st: mark
STM32MP23 timer as stopping in suspend", but that prerequisite is not applied
in this tree (and is not pulled in when backporting via Fixes:).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119184209.v2.1.If2b6b99285c1e60ca11b6e7fccf7d9b130ca20dd@changeid?part=1
next prev parent reply other threads:[~2026-11-19 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:42 [PATCH v2] arm64: dts: st: add PSCI idle state to STM32MP23 CPU domains Patrick Delaunay
2026-11-19 17:51 ` sashiko-bot [this message]
2026-11-20 12:58 ` Amelie Delaunay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223728@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=patrick.delaunay@foss.st.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.