From: sashiko-bot@kernel.org
To: "Leon Romanovsky" <leon@kernel.org>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
linux-pci@vger.kernel.org, linux-sound@vger.kernel.org,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH v3 09/31] USB: Pin modules for unregistered interface claims
Date: Thu, 19 Nov 2026 19:29:27 +0000 [thread overview]
Message-ID: <sashiko-outbox-223895@kernel.org> (raw)
In-Reply-To: <20261118-device-trust-core-v3-9-d655875c4bfb@nvidia.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] usb: core: premature claim_owner release in
usb_set_configuration()
--
commit afd725f56c3717b2e1f97538c7c8fdee117c4deb
Author: Leon Romanovsky <leon@kernel.org>
USB: Pin modules for unregistered interface claims
This commit pins the owning driver module in struct usb_interface.claim_owner
when an interface is claimed before registration, and releases that reference
upon interface registration or claim teardown.
> diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c
> index 0a6fdf2e88f4e..b7bd9226d2627 100644
> --- a/drivers/usb/core/driver.c
> +++ b/drivers/usb/core/driver.c
[ ... ]
> @@ -619,6 +634,7 @@ static void usb_unbind_claim(struct usb_interface *iface)
> usb_unbind_interface(dev);
> dev_set_drvdata(dev, NULL);
> dev->driver = NULL;
> + usb_put_claim_owner(iface);
> }
>
> /**
> @@ -653,6 +669,7 @@ void usb_driver_release_interface(struct usb_driver *driver,
> if (device_is_bound(dev)) {
> device_unlock(dev);
> device_release_driver(dev);
> + usb_put_claim_owner(iface);
> return;
> }
>
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index e56079398d26e..306978caaf1ef 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
[ ... ]
> @@ -2269,6 +2270,7 @@ int usb_set_configuration(struct usb_device *dev, int configuration)
> */
> for (i = 0; i < nintf; ++i) {
> struct usb_interface *intf = cp->interface[i];
> + struct module *claim_owner;
>
> if (intf->dev.of_node &&
> !of_device_is_available(intf->dev.of_node)) {
> @@ -2282,12 +2284,16 @@ int usb_set_configuration(struct usb_device *dev, int configuration)
> dev_name(&intf->dev), configuration,
> intf->cur_altsetting->desc.bInterfaceNumber);
> device_enable_async_suspend(&intf->dev);
> + device_lock(&intf->dev);
> + claim_owner = xchg(&intf->claim_owner, NULL);
> + device_unlock(&intf->dev);
> ret = device_add(&intf->dev);
> if (ret) {
> device_lock(&intf->dev);
> intf->unregistering = 1;
> device_unlock(&intf->dev);
> }
> + module_put(claim_owner);
> if (ret != 0) {
> dev_err(&dev->dev, "device_add(%s) --> %d\n",
> dev_name(&intf->dev), ret);
[Severity: Medium]
Does clearing intf->claim_owner before device_add() and calling
module_put(claim_owner) unconditionally drop the module reference too early
when device_add() leaves a pre-claimed interface unbound in the driver core
(!device_is_bound(&intf->dev))?
Commit "USB: Unwind interface claims after registration or binding failure"
later in the series handles the cases where device_add() fails or
__device_attach_locked() clears intf->dev.driver on binding failure, but if
USB bus autoprobing (/sys/bus/usb/drivers_autoprobe) is disabled between
usb_driver_claim_interface() and device_initial_probe() inside device_add(),
device_add() returns 0 while intf->dev.driver remains set and
device_is_bound(&intf->dev) remains false.
Because usb_set_configuration() has already dropped claim_owner (making
usb_put_claim_owner() in usb_unbind_claim() and the device_is_bound() branch
of usb_driver_release_interface() a no-op after device_add()), releasing the
registered-but-unbound claimed interface via usb_driver_release_interface()
-> usb_unbind_claim() runs without a claim_owner reference. Once the driver's
disconnect() callback detaches the control interface from klist_devices, a
concurrent delete_module() can see an empty klist_devices and free the module
while disconnect() is still executing (or leave a dangling intf->dev.driver
pointer for drivers such as snd-usb-audio that do not release claimed sibling
interfaces from disconnect()).
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-device-trust-core-v3-0-d655875c4bfb@nvidia.com?part=9
next prev parent reply other threads:[~2026-11-19 19:29 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 19:26 [PATCH v3 00/31] driver core: Authorize device trust before driver binding Leon Romanovsky
2026-11-18 19:26 ` [PATCH v3 01/31] wifi: mac80211_hwsim: lock device for manual " Leon Romanovsky
2026-11-19 0:32 ` driver core: Authorize device trust before " bluez.test.bot
2026-11-19 19:29 ` [PATCH v3 01/31] wifi: mac80211_hwsim: lock device for manual " sashiko-bot
2026-11-18 19:26 ` [PATCH v3 02/31] Bluetooth: btusb: Fix MediaTek ISO claim locking Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 03/31] USB: Lock interfaces during manual driver binding Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 04/31] USB: serial: Register USB drivers with their owning module Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 05/31] USB: Reject claims of DT-disabled interfaces Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 06/31] USB: Release interface claims according to binding state Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 07/31] USB: Reject claims after interface registration failure Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 08/31] ALSA: usb-audio: Release interface claims when probe fails Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 09/31] USB: Pin modules for unregistered interface claims Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot [this message]
2026-11-18 19:26 ` [PATCH v3 10/31] USB: Add helpers to release unpublished " Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 11/31] USB: Unwind interface claims after registration or binding failure Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 12/31] PNP: Attach card devices through the driver core Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 13/31] cdx: Propagate DMA configuration errors Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 14/31] driver core: Report deferred probes through sysfs drivers_probe Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 15/31] driver core: Add a compatibility API for manual driver attachment Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 16/31] Input: gameport - use the compatibility driver attachment API Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 17/31] Input: serio " Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 18/31] net: phy: Use " Leon Romanovsky
2026-11-18 20:21 ` Andrew Lunn
2026-11-19 7:18 ` Leon Romanovsky
2026-11-19 13:30 ` Andrew Lunn
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 19/31] driver core: Introduce a generic device trust level Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 20/31] driver core: Expose device trust authorization interfaces Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 21/31] driver core: Accept device trust policy on the kernel command line Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 22/31] driver core: Accept device trust policy by driver name Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 23/31] driver core: Expose committed device trust level Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 24/31] driver core: Cover trust authorization and binding with KUnit Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 25/31] driver core: Document trust admission and initrd authorization Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 26/31] PCI: Use device trust for platform restrictions Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 27/31] iommu: Use device trust for DMA restrictions Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 28/31] driver core: Allow driver attachment with the device lock held Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:26 ` [PATCH v3 29/31] USB: Retain the result of configuration requests Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:27 ` [PATCH v3 30/31] USB: Authorize interfaces through device trust Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
2026-11-18 19:27 ` [PATCH v3 31/31] USB: Authorize devices " Leon Romanovsky
2026-11-19 19:29 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223895@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=leon@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.