From: sashiko-bot@kernel.org
To: "Sander Speetjens" <sander.speetjens@gmail.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 2/2] firmware: raspberrypi: Register PMIC hwmon driver on Pi 5
Date: Thu, 19 Nov 2026 19:51:16 +0000 [thread overview]
Message-ID: <sashiko-outbox-223975@kernel.org> (raw)
In-Reply-To: <20261119-hwmon-da9091-v3-2-15956035d7b5@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] hwmon: raspberrypi-pmic: invalid hyphen in hwmon name in
rpi_pmic_probe()
--
commit 9f0a6e3ed58944e55b16d88389defd31010b2d46
Author: Sander Speetjens <sander.speetjens@gmail.com>
firmware: raspberrypi: Register PMIC hwmon driver on Pi 5
This commit registers and unregisters the raspberrypi-pmic-hwmon platform
device on BCM2712-based Raspberry Pi 5 systems.
> diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
> index d4f4753d39656..4184cc072a373 100644
> --- a/drivers/firmware/raspberrypi.c
> +++ b/drivers/firmware/raspberrypi.c
[ ... ]
> @@ -249,6 +250,23 @@ static void rpi_register_clk_driver(struct device *dev, struct rpi_firmware *fw)
> fw->clk_dev = pdev;
> }
>
> +static void rpi_register_pmic_driver(struct device *dev, struct rpi_firmware *fw)
> +{
> + struct platform_device *pdev;
> +
> + /* Only present on Pi 5 (bcm2712) */
> + if (!(of_machine_is_compatible("brcm,bcm2712") ||
> + of_machine_is_compatible("brcm,bcm2712-d0")))
> + return;
> +
> + pdev = platform_device_register_data(dev, "raspberrypi-pmic-hwmon",
> + -1, NULL, 0);
[Severity: Medium]
Does registering the "raspberrypi-pmic-hwmon" device trigger a hwmon warning
at boot because rpi_pmic_probe() registers a hwmon device with a hyphen in
its name?
drivers/hwmon/raspberrypi-pmic-hwmon.c:rpi_pmic_probe() {
...
hwmon_dev =
devm_hwmon_device_register_with_info(dev,
"rpi-pmic", data, &rpi_pmic_chip_info, NULL);
...
}
__hwmon_device_register() rejects '-' in hwmon chip names with a dev_warn()
("hwmon: 'rpi-pmic' is not a valid name attribute, please fix") because
userspace tools such as libsensors use '-' as a chip-name delimiter.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-hwmon-da9091-v3-0-15956035d7b5@gmail.com?part=2
prev parent reply other threads:[~2026-11-19 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 19:41 [PATCH v3 0/2] hwmon: add Raspberry Pi 5 PMIC driver Sander Speetjens
2026-11-19 19:41 ` [PATCH v3 1/2] hwmon: add Raspberry Pi " Sander Speetjens
2026-11-19 19:51 ` sashiko-bot
2026-11-19 19:41 ` [PATCH v3 2/2] firmware: raspberrypi: Register PMIC hwmon driver on Pi 5 Sander Speetjens
2026-11-19 19:51 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-223975@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=sander.speetjens@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.