From: sashiko-bot@kernel.org
To: "David Matlack" <dmatlack@google.com>,
kexec@lists.infradead.org, linux-mm@kvack.org,
linux-pci@vger.kernel.org
Cc: "Adithya Jayachandran" <ajayachandra@nvidia.com>,
"Alexander Graf" <graf@amazon.com>,
"Alex Williamson" <alex@shazbot.org>,
"Alex Williamson" <alex.williamson@nvidia.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Chris Down" <chris@chrisdown.name>,
"Chris Li" <chrisl@kernel.org>,
"David Rientjes" <rientjes@google.com>,
"Jacob Pan" <jacob.pan@linux.microsoft.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Josh Hilke" <jrhilke@google.com>,
"Leon Romanovsky" <leonro@nvidia.com>,
"Lukas Wunner" <lukas@wunner.de>,
"Mike Rapoport" <rppt@kernel.org>,
"Parav Pandit" <parav@nvidia.com>,
"Pasha Tatashin" <pasha.tatashin@soleen.com>,
"Pranjal Shrivastava" <praan@google.com>,
"Pratyush Yadav" <pratyush@kernel.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Saeed Mahameed" <saeedm@nvidia.com>,
"Samiullah Khawaja" <skhawaja@google.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Vipin Sharma" <vipinsh@google.com>,
"William Tu" <witu@nvidia.com>, "Yi Liu" <yi.l.liu@intel.com>
Subject: Re: [PATCH v11 01/13] PCI: liveupdate: Set up FLB handler for the PCI core
Date: Thu, 19 Nov 2026 22:38:17 +0000 [thread overview]
Message-ID: <sashiko-outbox-224136@kernel.org> (raw)
In-Reply-To: <20261118223704.3286085-2-dmatlack@google.com>
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] PCI: liveupdate: pci_flb_finish() logs unpopulated args->data
- [Low] PCI: liveupdate: separate __free() declaration and init in
pci_flb_preserve()
--
commit 525f211f02fbb47d85199fbccf703e0ddc3e892e
Author: David Matlack <dmatlack@google.com>
PCI: liveupdate: Set up FLB handler for the PCI core
This commit introduces a File-Lifecycle-Bound (FLB) handler and KHO ABI
for the PCI core so that PCI core state (struct pci_ser) can be allocated,
preserved, retrieved, and freed across a Live Update kexec.
> diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c
> new file mode 100644
> index 0000000000000..173433f64d002
> --- /dev/null
> +++ b/drivers/pci/liveupdate.c
[ ... ]
> +static int pci_flb_preserve(struct liveupdate_flb_op_args *args)
> +{
> + struct pci_flb_outgoing *outgoing __free(kfree) = NULL;
> + struct pci_ser *ser;
> +
> + outgoing = kzalloc_obj(*outgoing);
> + if (!outgoing)
> + return -ENOMEM;
[Severity: Low]
This isn't a bug, but per the Cleanup API conventions, outgoing can be
defined and initialized in a single statement:
struct pci_flb_outgoing *outgoing __free(kfree) = kzalloc_obj(*outgoing);
[ ... ]
> +static void pci_flb_finish(struct liveupdate_flb_op_args *args)
> +{
> + pr_debug("Finished struct pci_ser (0x%llx)\n", args->data);
> + kho_restore_free(args->obj);
> +}
[Severity: Low]
Will pci_flb_finish() always log 0x0 for the address of struct pci_ser?
liveupdate_flb_put_incoming() zero-initializes args and only populates
args.flb and args.obj before calling flb->ops->finish(&args) (matching
the struct liveupdate_flb_op_args contract where @data is only provided
to .unpreserve() and .retrieve()). Logging virt_to_phys(args->obj) would
print the actual physical address.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118223704.3286085-1-dmatlack@google.com?part=1
next prev parent reply other threads:[~2026-11-19 22:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 22:36 [PATCH v11 00/13] PCI: liveupdate: PCI core support for Live Update David Matlack
2026-11-18 22:36 ` [PATCH v11 01/13] PCI: liveupdate: Set up FLB handler for the PCI core David Matlack
2026-11-19 22:38 ` sashiko-bot [this message]
2026-11-18 22:36 ` [PATCH v11 02/13] PCI: liveupdate: Track outgoing preserved PCI devices David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:36 ` [PATCH v11 03/13] PCI: liveupdate: Track incoming " David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:36 ` [PATCH v11 04/13] PCI: liveupdate: Document driver binding responsibilities David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:36 ` [PATCH v11 05/13] PCI: liveupdate: Auto-preserve upstream bridges across Live Update David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:36 ` [PATCH v11 06/13] PCI: liveupdate: Preserve bus numbers during " David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:36 ` [PATCH v11 07/13] PCI: Refactor matching logic for pci_dev_acs_ops David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:36 ` [PATCH v11 08/13] PCI: Save and restore the ACS Control register and Egress Control Vector David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-20 14:44 ` Pranjal Shrivastava
2026-11-18 22:37 ` [PATCH v11 09/13] PCI: liveupdate: Adopt ACS controls in incoming preserved devices David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-20 0:10 ` Alex Williamson
2026-11-20 15:17 ` Pranjal Shrivastava
2026-11-18 22:37 ` [PATCH v11 10/13] PCI: liveupdate: Adopt ARI Forwarding Enable on preserved bridges David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:37 ` [PATCH v11 11/13] PCI: liveupdate: Freeze preservation status during shutdown David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:37 ` [PATCH v11 12/13] PCI: liveupdate: Do not disable bus mastering on preserved devices during kexec David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-18 22:37 ` [PATCH v11 13/13] Documentation: PCI: Add documentation for Live Update David Matlack
2026-11-19 22:38 ` sashiko-bot
2026-11-19 11:17 ` [PATCH v11 00/13] PCI: liveupdate: PCI core support " Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224136@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ajayachandra@nvidia.com \
--cc=alex.williamson@nvidia.com \
--cc=alex@shazbot.org \
--cc=bhelgaas@google.com \
--cc=chris@chrisdown.name \
--cc=chrisl@kernel.org \
--cc=corbet@lwn.net \
--cc=dmatlack@google.com \
--cc=graf@amazon.com \
--cc=jacob.pan@linux.microsoft.com \
--cc=jgg@nvidia.com \
--cc=jrhilke@google.com \
--cc=kexec@lists.infradead.org \
--cc=leonro@nvidia.com \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=parav@nvidia.com \
--cc=pasha.tatashin@soleen.com \
--cc=praan@google.com \
--cc=pratyush@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=saeedm@nvidia.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=skhawaja@google.com \
--cc=vipinsh@google.com \
--cc=witu@nvidia.com \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.