From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26641606A320 for ; Thu, 19 Nov 2026 22:38:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=EklAqqn0; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=OL/Xy+ag DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=SC8h+zDQaBZWH6G2HF3lPpzecIAbPoNIyVZcCrTdZfY=; b=EklAqqn0O0ziz3Can78O5OCcvn mTS04wq+yzIObgLdAzrZmtj4aE0bthX+oCavU/RqrpOR4SX+MBb6LV5EIoAdqsZ0+pBQLm0DxaIWj 66Pf5eE+EVAYdYaIhOOlUXSwl6Uv29/ZJgWIKNWGSztLshh01iKJihyHUuVQiimYPtpfwdp+K6wdb lyB/SuCQOVxrlRVNp5GZ6QTBtwsJfNfSIGPj79uBy8fVxWJKQbcGG3EdHe/ocqQ+FbsjMcUQdvD7e +7Yc017Aw8cKpwr2ZIIveYJkIMW46Te4WawxN6rM2MFS9OV4BifjMkroMQ/ED2bYFXGcy202rFxMU Mh+hawyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUAm7-0000000Daaz-33vT; Thu, 19 Nov 2026 22:38:39 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xUAm4-0000000DaWo-342q for kexec@lists.infradead.org; Thu, 19 Nov 2026 22:38:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 730344029E; Thu, 19 Nov 2026 22:38:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E96EF1F000C0; Thu, 19 Nov 2026 22:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1795127916; bh=SC8h+zDQaBZWH6G2HF3lPpzecIAbPoNIyVZcCrTdZfY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=OL/Xy+agxNjttpyvulvD2puIJoN9OHjCLeeXHxNOdpGcs/pH2lYU4EdUETX5zAkUD UDjimiUsEk00GPq2eR0kVX+nFd508/XdmRU+ldYfl+Q78FSXRRI7oLN/OOewoUSQDh zhaYbzVPH+hiC2fNGTMu8do80O2BXKcywQsWi1ZVuaXn9pbGG0vkRdHeF/H6opLPcu 4u7b4bf7xAn1szzjdmQVSr7lUz1QBhPywk3CIwmFFtF3EHCqHnbgY0Vju5arJaXbOI qPH2E9ozTlZawBN0JDJSC5gxqrXdYYwyIz8/gC+N9JsjtfRKOwjnL7iP4ZKe3kgiXi MKAT0ZUdC6hKA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 08/13] PCI: Save and restore the ACS Control register and Egress Control Vector To: "David Matlack" , kexec@lists.infradead.org, linux-pci@vger.kernel.org Cc: "Adithya Jayachandran" , "Alexander Graf" , "Alex Williamson" , "Alex Williamson" , "Bjorn Helgaas" , "Chris Down" , "Chris Li" , "David Rientjes" , "Jacob Pan" , "Jason Gunthorpe" , "Jonathan Corbet" , "Josh Hilke" , "Leon Romanovsky" , "Lukas Wunner" , "Mike Rapoport" , "Parav Pandit" , "Pasha Tatashin" , "Pranjal Shrivastava" , "Pratyush Yadav" , "Randy Dunlap" , "Saeed Mahameed" , "Samiullah Khawaja" , "Shuah Khan" , "Vipin Sharma" , "William Tu" , "Yi Liu" In-Reply-To: <20261118223704.3286085-9-dmatlack@google.com> References: <20261118223704.3286085-1-dmatlack@google.com> <20261118223704.3286085-9-dmatlack@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 19 Nov 2026 22:38:33 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > Save the ACS Control register and the ACS Egress Control Vector in > pci_save_state() and write them back in pci_restore_state(), instead of > recomputing the ACS controls from scratch with pci_enable_acs(). >=20 > This makes ACS symmetric with the rest of a device's saved state. Today > pci_save_state() ignores ACS entirely and pci_restore_state() re-enables > the ACS controls from the kernel's current ACS policy. As a result, a > device can come out of a reset with different ACS controls than it went > in with, e.g. any controls programmed outside of pci_enable_acs() are > silently dropped. >=20 > This also lets a later patch adopt the ACS controls established by a > previous kernel across a Live Update rather than assigning new ones > through pci_enable_acs(). >=20 > [ ... ] > keep that configuration outside of the ACS Control register, so don't > allocate an ACS save buffer for them. Keep configuring ACS from scratch > on restore for any device that has no saved ACS state. >=20 > Signed-off-by: David Matlack Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261118223704.3286= 085-1-dmatlack@google.com?part=3D8