From: sashiko-bot@kernel.org
To: "Nizat Mikayilli" <nacht@dxdmail.cc>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 6/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Add battery fuel gauge
Date: Thu, 19 Nov 2026 22:47:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-224158@kernel.org> (raw)
In-Reply-To: <20261119-b4-gts9wifi-followups-v1-6-2e2388589a62@dxdmail.cc>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: undocumented compatible
siliconmitus,sm5714-fuel-gauge
--
commit 86693e3820c815a003cf0d7756433d76382ae959
Author: Nizat Mikayilli <nacht@dxdmail.cc>
arm64: dts: qcom: sm8550-samsung-gts9wifi: Add battery fuel gauge
This commit adds the Silicon Mitus SM5714 fuel gauge on I2C hub 8 and the
8400 mAh simple-battery node for the Samsung Galaxy Tab S9 Wi-Fi.
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-samsung-gts9wifi.dts b/arch/arm64/boot/dts/qcom/sm8550-samsung-gts9wifi.dts
> index 8323eb8377103..511bdd05d49bc 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-samsung-gts9wifi.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-samsung-gts9wifi.dts
[ ... ]
> @@ -604,6 +610,18 @@ cirrus,gpio-ctrl2 {
> };
> };
>
> +&i2c_hub_8 {
> + clock-frequency = <400000>;
> +
> + status = "okay";
> +
> + fuel-gauge@71 {
> + compatible = "siliconmitus,sm5714-fuel-gauge";
> + reg = <0x71>;
> + monitored-battery = <&battery>;
> + };
> +};
[Severity: Medium]
Is "siliconmitus,sm5714-fuel-gauge" documented in a Devicetree binding
schema under Documentation/devicetree/bindings/? Without a binding
schema, dtbs_check and checkpatch will report an undocumented compatible
string for sm8550-samsung-gts9wifi.dtb.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-b4-gts9wifi-followups-v1-0-2e2388589a62@dxdmail.cc?part=6
prev parent reply other threads:[~2026-11-19 22:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 22:40 [PATCH 0/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Enable more peripherals Nizat Mikayilli
2026-11-19 22:40 ` Nizat Mikayilli via B4 Relay
2026-11-19 22:40 ` [PATCH 1/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Enable CDSP Nizat Mikayilli
2026-11-19 22:40 ` Nizat Mikayilli via B4 Relay
2026-11-19 22:40 ` [PATCH 2/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Add GPIO vibrator Nizat Mikayilli
2026-11-19 22:40 ` Nizat Mikayilli via B4 Relay
2026-11-19 22:40 ` [PATCH 3/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Add rear flash LED Nizat Mikayilli
2026-11-19 22:40 ` Nizat Mikayilli via B4 Relay
2026-11-19 22:40 ` [PATCH 4/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Add board thermistors Nizat Mikayilli
2026-11-19 22:40 ` Nizat Mikayilli via B4 Relay
2026-11-19 22:40 ` [PATCH 5/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Enable PM8550VS-C Nizat Mikayilli
2026-11-19 22:40 ` Nizat Mikayilli via B4 Relay
2026-11-19 22:40 ` [PATCH 6/6] arm64: dts: qcom: sm8550-samsung-gts9wifi: Add battery fuel gauge Nizat Mikayilli
2026-11-19 22:40 ` Nizat Mikayilli via B4 Relay
2026-11-19 22:47 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224158@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=nacht@dxdmail.cc \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.