All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Danny Gonzalez" <digonzal@google.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 2/2] PCI/ATS: Disable ATS when ACS TB is set upstream
Date: Fri, 20 Nov 2026 00:34:05 +0000	[thread overview]
Message-ID: <sashiko-outbox-224269@kernel.org> (raw)
In-Reply-To: <20261120002311.394649-3-digonzal@google.com>

> Enabling ATS allows an endpoint to cache translations and initiate DMA
> requests with Translated addresses, which an upstream bridge with ACS
> Translation Blocking (PCI_ACS_TB) set will block as ACS Violations.
> Because pci_enable_acs() preserves existing PCI_ACS_CTRL bits (e.g., from
> firmware, a kexec kernel, or "pci=config_acs=") without relaxing them,
> PCI_ACS_TB may remain set on upstream bridges.
> 
> Update pci_ats_supported() to walk upstream bridges and return false if
> any bridge has PCI_ACS_TB set, leaving the endpoint to use Untranslated
> addresses. Ignore bridges whose config read fails or returns an error
> response (PCI_POSSIBLE_ERROR()) so inaccessible bridges are not treated
> as having PCI_ACS_TB set.
> 
> Tested by booting a machine with an endpoint advertising the ATS Capability
> behind a Root Port with PCI_ACS_TB set; verified ATS is disabled and the
> system boots cleanly.
> 
> Signed-off-by: Danny Gonzalez <digonzal@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120002311.394649-1-digonzal@google.com?part=2


      reply	other threads:[~2026-11-20  0:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  0:23 [PATCH v3 0/2] PCI/ATS: Disable ATS when ACS TB is set upstream Danny Gonzalez
2026-11-20  0:23 ` [PATCH v3 1/2] iommu: Track whether pci_dev_reset_iommu_done() needs to restore state Danny Gonzalez
2026-11-20  0:33   ` sashiko-bot
2026-11-20  0:23 ` [PATCH v3 2/2] PCI/ATS: Disable ATS when ACS TB is set upstream Danny Gonzalez
2026-11-20  0:34   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224269@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=digonzal@google.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.