All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ricardo Pardini" <ricardo@pardini.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: rockchip: Add Mekotronics R58X-Pro
Date: Fri, 20 Nov 2026 00:56:08 +0000	[thread overview]
Message-ID: <sashiko-outbox-224280@kernel.org> (raw)
In-Reply-To: <20261120-rk3588-mekotronics-r58x-pro-v1-3-4e70c077c7b4@pardini.net>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] arm64: dts: rockchip: keep usb3-phy on usb_host1_xhci to
  disable U3 port
- [Medium] arm64: dts: rockchip: pull-up on active-high bt_wake_host_irq
  pin
- [Low] arm64: dts: rockchip: missing pinctrl entry for hdmi0
  frl-enable-gpios
--

commit e79dea5ac70e03e57bbea1fad7fc98344b2d0678
Author: Ricardo Pardini <ricardo@pardini.net>

arm64: dts: rockchip: Add Mekotronics R58X-Pro

This commit adds the device tree for the Mekotronics R58X-Pro, an
industrial mini PC based on the Rockchip RK3588 SoC.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-mekotronics-r58x-pro.dts b/arch/arm64/boot/dts/rockchip/rk3588-mekotronics-r58x-pro.dts
> new file mode 100644
> index 0000000000000..af83b14dda80e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-mekotronics-r58x-pro.dts
> @@ -0,0 +1,1215 @@

[ ... ]

> +&hdmi0 {
> +	frl-enable-gpios = <&gpio4 RK_PB1 GPIO_ACTIVE_LOW>;
> +	status = "okay";
> +};

[Severity: Low]
Should &hdmi0 also define a pinctrl entry for the frl-enable-gpios pin
(<4 RK_PB1 RK_FUNC_GPIO &pcfg_pull_none>) and include it in pinctrl-0,
rather than leaving GPIO4_B1's pull configuration to bootloader defaults?

[ ... ]

> +	wireless-bluetooth {
> +		bt_reset_pin: bt-reset-pin {
> +			rockchip,pins = <1 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>;
> +		};
> +
> +		bt_wake_host_irq: bt-wake-host-irq {
> +			rockchip,pins = <1 RK_PB0 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +
> +		bt_wake_pin: bt-wake-pin {
> +			rockchip,pins = <1 RK_PA4 RK_FUNC_GPIO &pcfg_pull_down>;
> +		};
> +	};

[ ... ]

> +&uart6 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&uart6m1_xfer &uart6m1_ctsn &uart6m1_rtsn>;
> +	uart-has-rtscts;
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "brcm,bcm43438-bt";
> +		clocks = <&hym8563>;
> +		clock-names = "lpo";
> +		device-wakeup-gpios = <&gpio1 RK_PA4 GPIO_ACTIVE_HIGH>;
> +		interrupt-parent = <&gpio1>;
> +		interrupts = <RK_PB0 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "host-wakeup";

[Severity: Medium]
Should bt_wake_host_irq use &pcfg_pull_down instead of &pcfg_pull_up?

With IRQ_TYPE_LEVEL_HIGH on host-wakeup, hci_bcm configures the controller
for active-high host wake (idle-low) and requests IRQF_TRIGGER_RISING.
Pulling GPIO1_B0 high holds the line in its active state when idle, which
can prevent rising-edge wakeup detection or cause spurious wakeups.

[ ... ]

> +/* USBDP PHY1 lanes are all used by the DP connector, so this is USB 2.0 only */
> +&usb_host1_xhci {
> +	dr_mode = "host";
> +	maximum-speed = "high-speed";
> +	phys = <&u2phy1_otg>;
> +	phy-names = "usb2-phy";
> +	status = "okay";
> +};
> +
> +&usb_host2_xhci {
> +	status = "okay";
> +};

[ ... ]

> +&usbdp_phy1 {
> +	rockchip,dp-lane-mux = <0 1 2 3>;
> +	status = "okay";
> +};

[Severity: High]
Does dropping <&usbdp_phy1 PHY_TYPE_USB3> from &usb_host1_xhci leave its
USB3 port enabled without a running PIPE clock when all four usbdp_phy1
lanes are assigned to DisplayPort?

drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_usb3_phy_init() {
	...
	/* DP only or high-speed, disable U3 port */
	if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) {
		rk_udphy_u3_port_disable(udphy, true);
		return 0;
	}
	...
}

On RK3588, the DWC3 controller takes its PIPE clock from the USBDP PHY by
default, and rk_udphy_u3_port_disable() writes usb3otg1_cfg in usb_grf to
disable the USB3 port and switch the PIPE clock to the UTMI fallback clock.
Because &usb_host1_xhci overrides phys and phy-names to drop "usb3-phy",
dwc3 never calls phy_init() on usbdp_phy1's USB3 PHY, so xHCI register
accesses on usb_host1_xhci can hang or trigger a fatal SError.  Keeping the
default phys and phy-names from rk3588-extra.dtsi alongside maximum-speed =
"high-speed" allows rk_udphy_usb3_phy_init() to disable the USB3 port.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-rk3588-mekotronics-r58x-pro-v1-0-4e70c077c7b4@pardini.net?part=3

      reply	other threads:[~2026-11-20  0:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  0:39 [PATCH 0/3] arm64: dts: rockchip: Add Mekotronics R58X-Pro Ricardo Pardini
2026-11-20  0:39 ` Ricardo Pardini via B4 Relay
2026-11-20  0:39 ` Ricardo Pardini via B4 Relay
2026-11-20  0:39 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add Mekotronics Ricardo Pardini
2026-11-20  0:39   ` Ricardo Pardini via B4 Relay
2026-11-20  0:39   ` Ricardo Pardini via B4 Relay
2026-11-20  0:39 ` [PATCH 2/3] dt-bindings: arm: rockchip: Add Mekotronics R58X-Pro Ricardo Pardini
2026-11-20  0:39   ` Ricardo Pardini via B4 Relay
2026-11-20  0:39   ` Ricardo Pardini via B4 Relay
2026-11-20  0:39 ` [PATCH 3/3] arm64: dts: " Ricardo Pardini
2026-11-20  0:39   ` Ricardo Pardini via B4 Relay
2026-11-20  0:39   ` Ricardo Pardini via B4 Relay
2026-11-20  0:56   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224280@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ricardo@pardini.net \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.