All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Changyul Lee" <lcy8047@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net] net/mlx5e: Skip hairpin entries not ready in debugfs dump
Date: Fri, 20 Nov 2026 01:27:22 +0000	[thread overview]
Message-ID: <sashiko-outbox-224304@kernel.org> (raw)
In-Reply-To: <20261119012707.555494-1-lcy8047@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] net/mlx5e: Fixes tag cites 0e414518d6d8 instead of 8a0594c09610
--

commit 1d92be457073f4715654759b7679a4d4615c15c5
Author: Changyul Lee <lcy8047@gmail.com>

> net/mlx5e: Skip hairpin entries not ready in debugfs dump
>
> Hairpin entries are added to the table before creation completes.
> Reading hairpin_table_dump can therefore dereference a NULL pointer
> while creation is in progress, or an error pointer if creation fails.
>
> Skip entries that are still being created or whose creation failed.
>
> Fixes: 0e414518d6d8 ("net/mlx5e: Add hairpin debugfs files")
> Signed-off-by: Changyul Lee <lcy8047@gmail.com>

[Severity: Low]
In 0e414518d6d8 ("net/mlx5e: Add hairpin debugfs files"),
debugfs_hairpin_table_dump_show() only read hpe->peer_vhca_id, hpe->prio
and refcount_read(&hpe->refcnt), which are initialized before the entry is
added to tc->hairpin_tbl.  The hpe->hp dereferences were added later by
8a0594c09610 ("net/mlx5e: Add more information to hairpin table dump").

Should the Fixes tag be:

  Fixes: 8a0594c09610 ("net/mlx5e: Add more information to hairpin table dump")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261119012707.555494-1-lcy8047@gmail.com?part=1

      parent reply	other threads:[~2026-11-20  1:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  1:27 [PATCH net] net/mlx5e: Skip hairpin entries not ready in debugfs dump Changyul Lee
2026-11-19 18:28 ` Tariq Toukan
2026-11-19 18:59   ` Changyul Lee
2026-11-20  1:27 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224304@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lcy8047@gmail.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.