All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vinay Belgaumkar" <vinay.belgaumkar@intel.com>,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v5 2/2] drm/xe: Add sysfs to disable RPe
Date: Fri, 20 Nov 2026 02:35:50 +0000	[thread overview]
Message-ID: <sashiko-outbox-224373@kernel.org> (raw)
In-Reply-To: <20261120021606.1360244-4-vinay.belgaumkar@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/xe: missing mutex_unlock() on error path in pc_init_freqs()
--

commit 8eaf500b6aad45a924c81aec805cef3e5c7913ef
Author: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

drm/xe: Add sysfs to disable RPe

This commit adds a use_rpe sysfs attribute to control whether GuC SLPC
elevates the minimum GT frequency to the efficient frequency (RPe), and
disables RPe before stashing or adjusting frequency bounds.

> diff --git a/drivers/gpu/drm/xe/xe_guc_pc.c b/drivers/gpu/drm/xe/xe_guc_pc.c
> index 7e9700f16bfb6..68e54e0b756de 100644
> --- a/drivers/gpu/drm/xe/xe_guc_pc.c
> +++ b/drivers/gpu/drm/xe/xe_guc_pc.c

[ ... ]

> @@ -1178,6 +1210,11 @@ static int pc_init_freqs(struct xe_guc_pc *pc)
>  
>  	pc_init_pcode_freq(pc);
>  
> +	/* Restore use_rpe */
> +	ret = pc_set_ignore_eff_freq(pc, !pc->use_rpe);
> +	if (unlikely(ret))
> +		return ret;
> +
>  	/*
>  	 * The frequencies are really ready for use only after the user
>  	 * requested ones got restored.

[Severity: High]
Does this error return leave pc->freq_lock held when
pc_set_ignore_eff_freq() fails?  pc_init_freqs() acquires pc->freq_lock
at the start and releases it at the out label, so returning directly here
will deadlock any later caller that takes pc->freq_lock.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120021606.1360244-3-vinay.belgaumkar@intel.com?part=2

  reply	other threads:[~2026-11-20  2:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  2:16 [PATCH v5 1/2] drm/xe: Disallow freq changes while mert cap is active Vinay Belgaumkar
2026-11-20  2:16 ` [PATCH v5 2/2] drm/xe: Add sysfs to disable RPe Vinay Belgaumkar
2026-11-20  2:35   ` sashiko-bot [this message]
2026-11-20  2:29 ` [PATCH v5 1/2] drm/xe: Disallow freq changes while mert cap is active sashiko-bot
2026-11-20  4:54 ` ✓ CI.KUnit: success for series starting with [v5,1/2] " Patchwork
2026-11-20  5:29 ` ✗ Xe.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224373@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.