From: sashiko-bot@kernel.org
To: "Michael J. Ruhl" <michael.j.ruhl@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v20 15/19] drm/xe/vsec: Support late bind fw information
Date: Fri, 20 Nov 2026 02:44:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-224379@kernel.org> (raw)
In-Reply-To: <20261120021929.473553-36-michael.j.ruhl@intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/xe/vsec: missing runtime PM and FW wait in
xe_pmt_discovery_read()
--
commit e59bd8c1a9c29d7e8aa32d98749713101a75f4bf
Author: Michael J. Ruhl <michael.j.ruhl@intel.com>
drm/xe/vsec: Support late bind fw information
This commit defers Crescent Island VSEC registration until the OOBMSM
late-bind firmware is ready and waits for firmware readiness in the PMT
read and write callbacks.
> diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c
> index 4c54f44d89adf..b6add588c0932 100644
> --- a/drivers/gpu/drm/xe/xe_vsec.c
> +++ b/drivers/gpu/drm/xe/xe_vsec.c
[ ... ]
> @@ -465,6 +528,10 @@ static int xe_pmt_read_reg(struct device *dev, u32 guid, u32 *reg, u32 offset)
> disc_addr += inst + offset;
>
> xe_pm_runtime_get(xe);
> + if (!wait_for_fw(xe)) {
> + ret = -ENODATA;
> + goto runtime_exit;
> + }
>
> scoped_guard(mutex, &xe->pmt.lock) {
> xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
> @@ -472,6 +539,7 @@ static int xe_pmt_read_reg(struct device *dev, u32 guid, u32 *reg, u32 offset)
> *reg = readl(disc_addr);
> }
>
> +runtime_exit:
> xe_pm_runtime_put(xe);
>
> drm_dev_exit(idx);
[Severity: Medium]
Should xe_pmt_discovery_read() also acquire runtime PM and call
wait_for_fw(xe) before reading discovery data from
CRI_IDX_TELEM_DISCOVERY?
drivers/gpu/drm/xe/xe_vsec.c:xe_pmt_discovery_read() {
...
scoped_guard(mutex, &xe->pmt.lock) {
xe->soc_remapper.set_telem_region(xe, CRI_IDX_TELEM_DISCOVERY);
memcpy_fromio(disc_data, disc_addr, PMT_DISC_DWORDS * sizeof(u32));
}
...
}
When a PMT auxiliary driver probes or rebinds after a D3cold resume,
pm_runtime_get_sync() on the parent device returns while
xe_late_bind_pm_resume() is still reloading the OOBMSM firmware
asynchronously on late_bind.wq. pmt_get_headers() then calls
xe_pmt_discovery_read(), which accesses the discovery window before the
firmware is ready.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120021929.473553-21-michael.j.ruhl@intel.com?part=15
next prev parent reply other threads:[~2026-11-20 2:44 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 2:19 [PATCH v20 00/19] Crescent Island PMT support Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 01/19] platform/x86/intel/pmt: Introduce a callback for discovery data Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 02/19] platform/x86/intel/pmt: Use the pre-populated header info for crashlog Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 03/19] drm/xe/vsec: VSEC requires soc-remapper Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 04/19] drm/xe/vsec: Do not register BMG PMT for VF Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 05/19] drm/xe/vsec: Correct locking order Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 06/19] drm/xe/vsec: Use correct pm state get Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 07/19] drm/xe/vsec: Add DOC text for VSEC Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 08/19] drm/xe/vsec: Support possible hotplug exit Michael J. Ruhl
2026-11-20 2:30 ` sashiko-bot
2026-11-20 2:19 ` [PATCH v20 09/19] drm/xe/vsec: Refactor BattleMage PMT defines Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 10/19] drm/xe/vsec: Update VSEC probe order Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 11/19] drm/xe/vsec: Add base_offset to allow for more flexibilty Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 12/19] drm/xe/vsec: Support Crescent Island PMT Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 13/19] drm/xe/vsec: Crescent Island PMT decode Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 14/19] drm/xe/vsec: Crescent Island PMT callbacks Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 15/19] drm/xe/vsec: Support late bind fw information Michael J. Ruhl
2026-11-20 2:44 ` sashiko-bot [this message]
2026-11-20 2:19 ` [PATCH v20 16/19] drm/xe/vsec: Add PMT GUID internal access Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 17/19] drm/xe/vsec: Update PMT " Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 18/19] drm/xe/vsec: Refactor platform check Michael J. Ruhl
2026-11-20 2:19 ` [PATCH v20 19/19] drm/xe/vsec: Support survivability mode for CRI Michael J. Ruhl
2026-11-20 5:31 ` ✗ CI.checkpatch: warning for Crescent Island PMT support (rev21) Patchwork
2026-11-20 5:33 ` ✓ CI.KUnit: success " Patchwork
2026-11-20 6:09 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224379@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=michael.j.ruhl@intel.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.