From: sashiko-bot@kernel.org
To: "John Hubbard" <jhubbard@nvidia.com>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH 3/9] gpu: nova-core: falcon: factor out the BROM and BOOTVEC programming
Date: Fri, 20 Nov 2026 04:49:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-224475@kernel.org> (raw)
In-Reply-To: <20261120044704.165223-4-jhubbard@nvidia.com>
> The r000 boot protocol requires the driver to program the BROM registers
> and the BOOTVEC register of the GSP falcon for a binary that GSP-RM has
> placed in the framebuffer, as the PIO and DMA load paths already do for
> a firmware image.
>
> In order to make the programming available to a caller that has no
> firmware image, factor it out of the two load paths, into a falcon
> method that receives the BROM parameters and the boot address.
>
> No functional changes.
>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120044704.165223-1-jhubbard@nvidia.com?part=3
next prev parent reply other threads:[~2026-11-20 4:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 4:46 [PATCH 0/9] gpu: nova-core: run falcon binaries for the r000 GSP-RM John Hubbard
2026-11-20 4:46 ` [PATCH 1/9] rust: pci: add domain_nr() accessor John Hubbard
2026-11-20 4:54 ` sashiko-bot
2026-11-20 4:46 ` [PATCH 2/9] gpu: nova-core: falcon: factor out the wait for the GSP suspend John Hubbard
2026-11-20 4:49 ` sashiko-bot
2026-11-20 4:46 ` [PATCH 3/9] gpu: nova-core: falcon: factor out the BROM and BOOTVEC programming John Hubbard
2026-11-20 4:49 ` sashiko-bot [this message]
2026-11-20 4:46 ` [PATCH 4/9] gpu: nova-core: gsp: factor out the core reset and the core resume John Hubbard
2026-11-20 4:49 ` sashiko-bot
2026-11-20 4:47 ` [PATCH 5/9] gpu: nova-core: gsp: fix resume_gsp_rm()'s error messages John Hubbard
2026-11-20 4:49 ` sashiko-bot
2026-11-20 4:47 ` [PATCH 6/9] gpu: nova-core: falcon: select the BAR2 engine ID for framebuffer DMA John Hubbard
2026-11-20 4:53 ` sashiko-bot
2026-11-20 4:47 ` [PATCH 7/9] gpu: nova-core: gsp: add the r000 load-and-execute HS binary handler John Hubbard
2026-11-20 4:53 ` sashiko-bot
2026-11-20 4:47 ` [PATCH 8/9] gpu: nova-core: gsp: add the r000 load-and-execute bootloader handler John Hubbard
2026-11-20 4:52 ` sashiko-bot
2026-11-20 4:47 ` [PATCH 9/9] gpu: nova-core: gsp: add the load-and-execute event dispatcher John Hubbard
2026-11-20 4:51 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224475@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jhubbard@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.