All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Zhu Jun" <zhujun2@cmss.chinamobile.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] tools/leds: Build the full hardware brightness path
Date: Fri, 20 Nov 2026 06:21:57 +0000	[thread overview]
Message-ID: <sashiko-outbox-224556@kernel.org> (raw)
In-Reply-To: <20261120061840.98122-1-zhujun2@cmss.chinamobile.com>

> The path includes both the LED class directory and the attribute
> name, but snprintf() limits the entire result to the LED name size.
> This truncates valid paths and causes open() to fail. Allow room
> for the whole path and check for truncation before opening it.
> 
> Fixes: ae3473231e77 ("tools/leds: Add led_hw_brightness_mon program")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120061840.98122-1-zhujun2@cmss.chinamobile.com?part=1


      reply	other threads:[~2026-11-20  6:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  6:18 [PATCH] tools/leds: Build the full hardware brightness path Zhu Jun
2026-11-20  6:21 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224556@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=zhujun2@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.