From: sashiko-bot@kernel.org
To: "Seonghyeon Lim" <forfortuna@naver.com>
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v2 1/2] can: virtio: fix RX/TX stall on interrupt before NAPI is enabled
Date: Fri, 20 Nov 2026 07:12:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-224601@kernel.org> (raw)
In-Reply-To: <20261120-virtio-can-ready-v2-1-0defda2af8cb@naver.com>
> From: Seonghyeon Lim <forfortuna@naver.com>
>
> virtio_can_open() sends the START command before it enables NAPI. Once
> the device has started, an RX or TX interrupt can arrive in between.
> The interrupt handler then disables the virtqueue callback and calls
> napi_schedule(), which does nothing because NAPI is still disabled.
> napi_enable() does not schedule a poll either, and only the poll
> function re-enables the callback, so the queue can stall until the
> device happens to send another interrupt.
>
> Schedule NAPI once after napi_enable(), as virtio-net does in
> virtnet_napi_do_enable(). This processes buffers that are already used
> and re-enables the callback.
>
> Fixes: 083082a4e6d8 ("can: virtio: Add virtio CAN driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Seonghyeon Lim <forfortuna@naver.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-virtio-can-ready-v2-0-0defda2af8cb@naver.com?part=1
next prev parent reply other threads:[~2026-11-20 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 6:56 [PATCH v2 0/2] can: virtio: fix NAPI stall and virtqueue use before DRIVER_OK Seonghyeon Lim
2026-11-20 6:56 ` Seonghyeon Lim via B4 Relay
2026-11-20 6:56 ` [PATCH v2 1/2] can: virtio: fix RX/TX stall on interrupt before NAPI is enabled Seonghyeon Lim
2026-11-20 6:56 ` Seonghyeon Lim via B4 Relay
2026-11-20 7:12 ` sashiko-bot [this message]
2026-11-20 6:56 ` [PATCH v2 2/2] can: virtio: fix virtqueue use before DRIVER_OK Seonghyeon Lim
2026-11-20 6:56 ` Seonghyeon Lim via B4 Relay
2026-11-20 7:03 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224601@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=forfortuna@naver.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.