All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Gautam Gala" <ggala@linux.ibm.com>
Cc: linux-s390@vger.kernel.org, "Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>
Subject: Re: [PATCH v1 2/2] KVM: s390: make kvm_s390_vm_stop_migration() void
Date: Fri, 20 Nov 2026 07:58:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-224671@kernel.org> (raw)
In-Reply-To: <20261120075345.116521-3-ggala@linux.ibm.com>

> kvm_s390_vm_stop_migration() returns 0 on all paths; it cannot fail.
> Its caller in s390_kvm_mmu_prepare_memory_region() wraps it in
> WARN(), producing a condition that is always false. The arm64 stub
> returns -EINVAL but is unreachable because
> kvm_s390_is_migration_mode() returns false there.
> 
> Change the return type to void and drop the dead WARN(). The
> KVM_S390_VM_MIGRATION_STOP attribute handler sets its result to 0
> explicitly; userspace behavior is unchanged since stopping
> migration never failed.
> 
> Signed-off-by: Gautam Gala <ggala@linux.ibm.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120075345.116521-1-ggala@linux.ibm.com?part=2


  reply	other threads:[~2026-11-20  7:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20  7:53 [PATCH v1 0/2] KVM: s390: fix migration mode teardown in memslot handling Gautam Gala
2026-11-20  7:53 ` [PATCH v1 1/2] KVM: s390: reserve mmu cache before stopping migration mode Gautam Gala
2026-11-20  7:57   ` sashiko-bot
2026-11-20  7:53 ` [PATCH v1 2/2] KVM: s390: make kvm_s390_vm_stop_migration() void Gautam Gala
2026-11-20  7:58   ` sashiko-bot [this message]
2026-11-20 10:30   ` Andreas Grapentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224671@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=ggala@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.