From: sashiko-bot@kernel.org
To: "Jacky Chou" <jacky_chou@aspeedtech.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next v7 3/7] net: ftgmac100: Add AST2700 compatible support
Date: Fri, 20 Nov 2026 09:32:59 +0000 [thread overview]
Message-ID: <sashiko-outbox-224856@kernel.org> (raw)
In-Reply-To: <20261119-support_ast2700-v7-3-33c8ca2d0dd7@aspeedtech.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] net: ftgmac100: missing MAC reset deassertion for AST2700 in
ftgmac100_probe()
--
commit bc0b615a5df5edb854a72ea5c88c72e247810b61
Author: Jacky Chou <jacky_chou@aspeedtech.com>
net: ftgmac100: Add AST2700 compatible support
This commit adds match data and the "aspeed,ast2700-mac" compatible
string so AST2700 FTGMAC100 device tree nodes can bind to the driver.
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 6d2fe5c2f3903..67b1fa464a421 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
[ ... ]
> @@ -2017,7 +2018,8 @@ static int ftgmac100_probe(struct platform_device *pdev)
>
> if (priv->mac_id == FTGMAC100_AST2400 ||
> priv->mac_id == FTGMAC100_AST2500 ||
> - priv->mac_id == FTGMAC100_AST2600) {
> + priv->mac_id == FTGMAC100_AST2600 ||
> + priv->mac_id == FTGMAC100_AST2700) {
> priv->rxdes0_edorr_mask = BIT(30);
> priv->txdes0_edotr_mask = BIT(30);
> priv->is_aspeed = true;
[Severity: High]
Does ftgmac100_probe() leave the AST2700 MAC held in hardware reset?
On AST2400, AST2500, and AST2600, the MAC clock gates define a coupled
reset_idx, so enabling the clock in ftgmac100_setup_clk() automatically
deasserts the MAC reset. On AST2700, ast2700_clk_enable() only clears
the clock stop bit in SCU1_CLK_STOP and does not release the separate
SCU1_RESET_MAC0..2 resets:
drivers/clk/aspeed/clk-ast2700.c:ast2700_clk_enable() {
struct clk_gate *gate = to_clk_gate(hw);
u32 clk = BIT(gate->bit_idx);
if (readl(gate->reg) & clk)
writel(clk, gate->reg + 0x04);
return 0;
}
Unless the bootloader has already enabled the clock and released the
reset, ftgmac100_initial_mac() reads FTGMAC100_OFFSET_MAC_MADR and
FTGMAC100_OFFSET_MAC_LADR before priv->clk is enabled and before
priv->rst is acquired. Moreover, ftgmac100_probe() never calls
reset_control_deassert(priv->rst), and ftgmac100_reset_and_config_mac()
only toggles priv->rst for PHY_INTERFACE_MODE_RMII, leaving RGMII
interfaces in reset so ftgmac100_reset_mac() fails with -EIO.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261119-support_ast2700-v7-0-33c8ca2d0dd7@aspeedtech.com?part=3
next prev parent reply other threads:[~2026-11-20 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 9:32 [PATCH net-next v7 0/7] net: ftgmac100: Add AST2700 support Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 1/7] dt-bindings: net: ftgmac100: Make Aspeed compatibles standalone Jacky Chou
2026-11-20 9:32 ` sashiko-bot
2026-11-19 9:32 ` [PATCH net-next v7 2/7] dt-bindings: net: ftgmac100: Add AST2700 compatible Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 3/7] net: ftgmac100: Add AST2700 compatible support Jacky Chou
2026-11-20 9:32 ` sashiko-bot [this message]
2026-11-19 9:32 ` [PATCH net-next v7 4/7] net: ftgmac100: Enable AST2700 RMII support Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 5/7] net: ftgmac100: Require phy-mode for AST2700 Jacky Chou
2026-11-20 9:33 ` sashiko-bot
2026-11-19 9:32 ` [PATCH net-next v7 6/7] net: ftgmac100: Add AST2700 upper DMA address support Jacky Chou
2026-11-19 9:32 ` [PATCH net-next v7 7/7] net: ftgmac100: Allow building on ARM64 Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224856@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacky_chou@aspeedtech.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.