All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: phucduc.bui@gmail.com
Cc: linux-sound@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: atmel: mchp-pdmc: Mark IMR as volatile
Date: Fri, 20 Nov 2026 10:16:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-224919@kernel.org> (raw)
In-Reply-To: <20261120100408.8053-2-phucduc.bui@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ASoC: atmel: mchp-pdmc: inaccurate Fixes trailer citing
  50291652af52
--

commit 2524e29a52dc348922861fcb11ff3299de1fc52e
Author: bui duc phuc <phucduc.bui@gmail.com>

> ASoC: atmel: mchp-pdmc: Mark IMR as volatile
>
> The interrupt handler reads ISR and IMR to determine which interrupts
> are pending. While ISR is marked as volatile, IMR is not, causing
> regmap to return its cached value instead of reading the hardware.
>
> Add IMR to the volatile registers.
>
> Fixes: c5682e2ba132 ("ASoC: mchp-pdmc: fix poc noise at capture startup")
> Fixes: 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>

[Severity: Low]
In 50291652af52 ("ASoC: atmel: mchp-pdmc: add PDMC driver"),
mchp_pdmc_regmap_config did not enable regmap caching, so regmap_read()
on MCHP_PDMC_IMR always read from hardware.  Regmap caching
(.cache_type = REGCACHE_FLAT) was enabled in e8c8e9de4ee3 ("ASoC:
mchp-pdmc: use runtime pm for clock power saving") without marking
MCHP_PDMC_IMR volatile.

Should the second Fixes: tag reference e8c8e9de4ee3 ("ASoC: mchp-pdmc:
use runtime pm for clock power saving") instead of 50291652af52 ("ASoC:
atmel: mchp-pdmc: add PDMC driver")?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120100408.8053-1-phucduc.bui@gmail.com?part=1

  reply	other threads:[~2026-11-20 10:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:04 [PATCH 0/2] ASoC: atmel: Mark interrupt registers as volatile phucduc.bui
2026-11-20 10:04 ` [PATCH 1/2] ASoC: atmel: mchp-pdmc: Mark IMR " phucduc.bui
2026-11-20 10:16   ` sashiko-bot [this message]
2026-11-20 10:28     ` Bui Duc Phuc
2026-11-20 10:04 ` [PATCH 2/2] ASoC: atmel: mchp-spdiftx: Mark interrupt registers " phucduc.bui
2026-11-20 10:10   ` sashiko-bot
2026-11-20 10:22     ` Bui Duc Phuc
2026-11-20 10:26       ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224919@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=phucduc.bui@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.