All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Vikash Garodia" <vikash.garodia@oss.qualcomm.com>
Cc: virtualization@lists.linux.dev,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v8 3/4] iommu/of: Make OF_IOMMU depend on OF_ADDRESS
Date: Fri, 20 Nov 2026 10:42:26 +0000	[thread overview]
Message-ID: <sashiko-outbox-224951@kernel.org> (raw)
In-Reply-To: <20261120-add_iommu_ranges-v8-3-d90486973b73@oss.qualcomm.com>

> Currently, the OF_IOMMU code is built when OF and IOMMU_API are enabled.
> However, the code also uses OF address parsing helpers, which are only
> available when OF_ADDRESS is enabled. Since this dependency is not
> expressed in Kconfig, when OF_ADDRESS is disabled the code relies on
> CONFIG_OF_ADDRESS guards and a __maybe_unused annotation to avoid
> compilation issues.
> 
> The only architecture supporting OF without OF_ADDRESS is SPARC, which
> does not use OF_IOMMU. Therefore, make the OF_IOMMU code depend on
> OF_ADDRESS so that it is built only when the required address parsing
> support is available, avoiding the CONFIG_OF_ADDRESS guards and
> __maybe_unused annotation in the code. No functional change is intended.
> 
> Suggested-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Co-developed-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
> Signed-off-by: Vishnu Reddy <busanna.reddy@oss.qualcomm.com>
> Signed-off-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-add_iommu_ranges-v8-0-d90486973b73@oss.qualcomm.com?part=3


  reply	other threads:[~2026-11-20 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 10:35 [PATCH v8 0/4] of_iommu: add support for "iommu-ranges" Vikash Garodia
2026-11-20 10:35 ` [PATCH v8 1/4] iommu/dma: Keep reserved regions below the IOVA rbtree anchor Vikash Garodia
2026-11-20 10:43   ` sashiko-bot
2026-11-20 10:35 ` [PATCH v8 2/4] iommu: Use resource_size_t for reserved region length Vikash Garodia
2026-11-20 10:45   ` sashiko-bot
2026-11-20 10:35 ` [PATCH v8 3/4] iommu/of: Make OF_IOMMU depend on OF_ADDRESS Vikash Garodia
2026-11-20 10:42   ` sashiko-bot [this message]
2026-11-20 10:35 ` [PATCH v8 4/4] iommu/of: Add support for "iommu-ranges" on a device node Vikash Garodia
2026-11-20 10:50   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-224951@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=eperezma@redhat.com \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=vikash.garodia@oss.qualcomm.com \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.