From: sashiko-bot@kernel.org
To: "Joy Zou" <joy.zou@oss.nxp.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support
Date: Fri, 20 Nov 2026 11:11:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-224996@kernel.org> (raw)
In-Reply-To: <20261120-b4-imx937-frdm-v2-3-5e27ceec02df@oss.nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: freescale: mismatch between imx937.dtsi GPU OPP
and commit message
--
commit afd999f203571f5f314e686dbc42facdd65a3d63
Author: Joy Zou <joy.zou@oss.nxp.com>
arm64: dts: freescale: add i.MX937 FRDM board support
This commit adds imx937.dtsi and imx937-frdm.dts, reusing imx952.dtsi and
imx952-frdm.dtsi to support the NXP i.MX937 FRDM board.
> diff --git a/arch/arm64/boot/dts/freescale/imx937.dtsi b/arch/arm64/boot/dts/freescale/imx937.dtsi
> new file mode 100644
> index 0000000000000..7912a9c282d8c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx937.dtsi
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: (GPL-2.0-only OR MIT)
> +/*
> + * Copyright 2026 NXP
> + */
> +
> +#include "imx952.dtsi"
> +
> +&gpu_opp_table {
> + opp-1000000000 {
> + status = "disabled";
> + };
> +};
[Severity: Medium]
Should imx937.dtsi disable the 1.0 GHz OPP in gpu_opp_table, or does the
commit message describe the wrong hardware difference?
The commit message states that i.MX937 drops the local dimming and ISP
blocks and runs its Cortex-A55 cores at a lower maximum frequency, with no
mention of the GPU. However, the only override in imx937.dtsi disables
opp-1000000000 in gpu_opp_table, which is the operating-points-v2 table
for gpu@4d900000 in imx952.dtsi, capping the Mali GPU at 800 MHz while
leaving Cortex-A55 frequencies managed by the IMX952_PERF_A55 SCMI
performance domain unchanged.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-b4-imx937-frdm-v2-0-5e27ceec02df@oss.nxp.com?part=3
prev parent reply other threads:[~2026-11-20 11:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 11:09 [PATCH v2 0/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
2026-11-20 11:09 ` [PATCH v2 1/3] dt-bindings: arm: fsl: add i.MX937 FRDM board Joy Zou
2026-11-20 11:12 ` sashiko-bot
2026-11-20 17:11 ` Frank Li
2026-11-20 11:09 ` [PATCH v2 2/3] arm64: dts: imx952-frdm: model CAN/GPIO selector as gpio-mux Joy Zou
2026-11-20 11:09 ` [PATCH v2 3/3] arm64: dts: freescale: add i.MX937 FRDM board support Joy Zou
2026-11-20 11:11 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-224996@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=joy.zou@oss.nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.